Skip to content

Only do TT cutoffs in qsearch when being off-PV #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealGioviok merged 2 commits into from
Feb 8, 2026
Merged

Only do TT cutoffs in qsearch when being off-PV #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2810630
Only do TT cutoffs in qsearch when being off-PV
pkrisz99 Feb 3, 2026
e96d842
Format
TheRealGioviok Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ Value Worker::search(
}

if (depth <= 0) {
return quiesce<IS_MAIN>(pos, ss, alpha, beta, ply);
return quiesce<IS_MAIN, PV_NODE>(pos, ss, alpha, beta, ply);
}

const bool ROOT_NODE = ply == 0;
Expand Down Expand Up @@ -528,7 +528,7 @@ Value Worker::search(
// Razoring
if (!PV_NODE && !excluded && !is_in_check && depth <= tuned::razor_depth
&& ss->static_eval + tuned::razor_margin * depth < alpha) {
const Value razor_score = quiesce<IS_MAIN>(pos, ss, alpha, beta, ply);
const Value razor_score = quiesce<IS_MAIN, PV_NODE>(pos, ss, alpha, beta, ply);
if (razor_score <= alpha) {
return razor_score;
}
Expand Down Expand Up @@ -558,8 +558,8 @@ Value Worker::search(
Position pos_after = pos.move(m, m_td.push_psqt_state(), &m_searcher.tt);
repetition_info.push(pos_after.get_hash_key(), pos_after.is_reversible(m));

Value probcut_value =
-quiesce<IS_MAIN>(pos_after, ss + 1, -probcut_beta, -probcut_beta + 1, ply + 1);
Value probcut_value = -quiesce<IS_MAIN, false>(pos_after, ss + 1, -probcut_beta,
-probcut_beta + 1, ply + 1);

if (probcut_value >= probcut_beta) {
probcut_value =
Expand Down Expand Up @@ -901,7 +901,7 @@ Value Worker::search(
return best_value;
}

template<bool IS_MAIN>
template<bool IS_MAIN, bool PV_NODE>
Value Worker::quiesce(const Position& pos, Stack* ss, Value alpha, Value beta, i32 ply) {
ss->pv.clear();

Expand Down Expand Up @@ -942,18 +942,15 @@ Value Worker::quiesce(const Position& pos, Stack* ss, Value alpha, Value beta, i

// TT Probing
auto tt_data = m_searcher.tt.probe(pos, ply);
if (tt_data
if (!PV_NODE && tt_data
&& (tt_data->bound() == Bound::Exact
|| (tt_data->bound() == Bound::Lower && tt_data->score >= beta)
|| (tt_data->bound() == Bound::Upper && tt_data->score <= alpha))) {
return tt_data->score;
}

bool is_in_check = pos.is_in_check();
bool ttpv =
tt_data
? tt_data->ttpv()
: false; // TODO: if we ever get to needing ttpv patches in quiescence, we might want to add PV_NODE handling in here also
bool is_in_check = pos.is_in_check();
bool ttpv = PV_NODE || (tt_data && tt_data->ttpv());
Value correction = 0;
Value raw_eval = -VALUE_INF;
Value static_eval = -VALUE_INF;
Expand Down Expand Up @@ -1006,7 +1003,7 @@ Value Worker::quiesce(const Position& pos, Stack* ss, Value alpha, Value beta, i
repetition_info.push(pos_after.get_hash_key(), pos_after.is_reversible(m));

// Get search value
Value value = -quiesce<IS_MAIN>(pos_after, ss + 1, -beta, -alpha, ply + 1);
Value value = -quiesce<IS_MAIN, PV_NODE>(pos_after, ss + 1, -beta, -alpha, ply + 1);

// TODO: encapsulate this and any other future adjustment to do "on going back" into a proper function
repetition_info.pop();
Expand Down
2 changes: 1 addition & 1 deletion src/search.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class alignas(128) Worker {
template<bool IS_MAIN, bool PV_NODE>
Value search(
const Position& pos, Stack* ss, Value alpha, Value beta, Depth depth, i32 ply, bool cutnode);
template<bool IS_MAIN>
template<bool IS_MAIN, bool PV_NODE>
Value quiesce(const Position& pos, Stack* ss, Value alpha, Value beta, i32 ply);
Value evaluate(const Position& pos);
Value adj_shuffle(const Position& pos, Value value);
Expand Down
Loading