[ADD] Estate: init #1028
Open
[ADD] Estate: init #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…line (L7) deletation
clbr-odoo
reviewed
Nov 19, 2025
Contributor
clbr-odoo
left a comment
clbr-odoo
left a comment
There was a problem hiding this comment.
Very good job, continue like this !
The module name in the commit title should be lower case, it's the technical name of the module, which is equivalent to the folder name.
haall-odoo
force-pushed
the
19.0-tutorial-haall
branch
from
d717a89 to
ac39bed
Compare
clbr-odoo
reviewed
Nov 21, 2025
| _name = "estate.property" | ||
| _description = "Estate Property" | ||
| _order = "id desc" | ||
| _check_expected_price = models.Constraint( |
Contributor
There was a problem hiding this comment.
Constraints should be just below field definition. Check the coding guidelines for the order of the methods and fields because it's not the only one misplaced :)
| @api.depends("offer_ids") | ||
| def _compute_best_offer(self): | ||
| for record in self: | ||
| record.best_price = max(record.offer_ids.mapped("price")) if len(record.offer_ids) > 0 else 0.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| record.best_price = max(record.offer_ids.mapped("price")) if len(record.offer_ids) > 0 else 0.0 | |
| record.best_price = max(record.offer_ids.mapped("price"), default=0.0) |
- You never need to check the length if you want to check if a recordset is filled, just do
if record.offer_ids: - You can simplify a bit like this ☝️
| record.garden_orientation = 'north' | ||
|
|
||
| def estate_property_action_sold(self): | ||
| self.__estate_property_action_sold_cancel('sold', "A cancelled property cannot be sold!", "This property is already sold!") |
Contributor
There was a problem hiding this comment.
Suggested change
| self.__estate_property_action_sold_cancel('sold', "A cancelled property cannot be sold!", "This property is already sold!") | |
| self._estate_property_action_sold_cancel('sold', "A cancelled property cannot be sold!", "This property is already sold!") |
| @api.onchange("offer_ids") | ||
| def _onchange_offer_ids(self): | ||
| for record in self: | ||
| if len(record.offer_ids) > 0: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(record.offer_ids) > 0: | |
| if record.offer_ids: |
Comment on lines
+40
to
+41
| if record.status == 'accepted': | ||
| return False |
Contributor
There was a problem hiding this comment.
It's weird to have a method that returns False in the middle of the loop.
This will lead to inconsistencies.
Comment on lines
+57
to
+58
| for record in self: | ||
| record.property_id.selling_price = 0.0 |
Contributor
There was a problem hiding this comment.
You can actually "batch write" it self.property_id.selling_price = 0.0
| <field name="arch" type="xml"> | ||
| <form string="My new house"> | ||
| <header> | ||
| <button name="estate_property_action_sold" type="object" string="Sold" invisible="state == 'sold' or state == 'cancelled'"/> |
Contributor
There was a problem hiding this comment.
Suggested change
| <button name="estate_property_action_sold" type="object" string="Sold" invisible="state == 'sold' or state == 'cancelled'"/> | |
| <button name="estate_property_action_sold" type="object" string="Sold" invisible="state in ('sold', 'cancelled')"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.