Skip to content

[REF] website: move address autocomplete to General + update#17627

Open
lman-odoo wants to merge 1 commit into19.0from
19.0-website-address-autocomplete-lman
Open

[REF] website: move address autocomplete to General + update#17627
lman-odoo wants to merge 1 commit into19.0from
19.0-website-address-autocomplete-lman

Conversation

@lman-odoo
Copy link
Copy Markdown
Contributor

task-6062545
task-5194557

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 29, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team April 29, 2026 08:49
@lman-odoo lman-odoo requested review from a team and removed request for a team April 29, 2026 09:11
@mcsi-odoo mcsi-odoo requested review from mcsi-odoo and removed request for a team April 30, 2026 05:55
Copy link
Copy Markdown
Contributor

@mcsi-odoo mcsi-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lman-odoo ! This looks so much better than the old version 🤩 Take a look at my comments and suggestions and let me know if you'd like to discuss anything.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a redirection for this in the 19.0.txt redirects file in PyCharm (and we'll want to create one so the old content/applications/websites/website/configuration/address_autocomplete rst/url redirects to the new content/applications/general/integrations/address_autocomplete one)
Are you familiar with how to do that?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right!!! I totally forgot the redirection. I will add it. Sorry about that

Comment on lines +5 to +8
Odoo provides a feature to automatically complete contact address information using the Google
Places API. This service allows developers to retrieve detailed place information via HTTP requests.
As you begin typing an address, the system suggests a list of matching locations to simplify
data entry.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Odoo provides a feature to automatically complete contact address information using the Google
Places API. This service allows developers to retrieve detailed place information via HTTP requests.
As you begin typing an address, the system suggests a list of matching locations to simplify
data entry.
Odoo integrates with the Google Places API to allow the autocompletion of addresses. As you begin typing an address, the system provides a list of suggested locations, reducing manual errors and saving time.

I think the first sentence could be a little more direct, so I made a suggestion.

Also, since this documentation is aimed at regular users, I think we could probably drop the sentence about HTTP requests ... what do you think? And if we remove it, we should probably remove the link to the developers documentation too.

(Or ... maybe, for some reason, it would make sense to have a little admonition only for developers? I don't understand this well enough to know why a developer might be reading about this here. Maybe you have a better understanding about that?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! I guess we can remove it. I kept it because I thought it must have been added for some reason, but as you said, our documentation is aimed at regular users. Thank you!


.. seealso::
- `Google Maps Platform <https://mapsplatform.google.com/maps-products>`_
- `Google Developers Documentation: Google Places API
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `Google Developers Documentation: Google Places API
- `Google developer documentation: Google Places API

If we do keep this: (see previous comment):

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the HTTP request information from your previous comment. But I would still add this link as I think it could be useful.

Comment on lines +38 to +40
#. In the upper-left corner, click :guilabel:`Select a project` or the selected project's name if
you have already created one. In the :guilabel:`Select a resource` pop-up, select a project, or
create a :guilabel:`New Project`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take a look at this together? (at the two scenarios: no project created & with one already there) I wonder if we need to edit this slightly as it confused me a bit (as I was doing it in an account where there was already a project).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's discuss it!

Comment thread content/applications/general/integrations/address_autocomplete.rst
Comment thread content/applications/general/integrations/address_autocomplete.rst
Comment thread content/applications/general/integrations/address_autocomplete.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only commenting here because I'm a bit confused as to why we're seeing this, and I want to ask @auva-odoo about it. Because I guess you completely deleted the old image ... and here it's showing that you renamed it. So I'm just wondering why that shows here.

Comment thread content/applications/websites/ecommerce/checkout.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants