[FIX] hr_holidays: fix the error in traceback on timeoff type #4897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed an error which appeared by choosing a Time Off Type in new Time Off task-5380599
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-taskv, it needs to be retargeted before it can be merged. |
lebm-odoo
requested changes
Dec 3, 2025
lebm-odoo
left a comment
lebm-odoo
left a comment
There was a problem hiding this comment.
Helloo, Thanks for your work! As it is a FIX, you should write a test that fails before and succeed after your fix too 😄.
And in general, you should write in your commit message something like:
[XXX] - <module>: <title>
Problem
---------
The problem ... (for a fix the steps to reproduce, and little description)
Objective
----------
The cause of the problem, (why it happens if it is a fix) what we will find in this commit
Solution
----------
The solution ... (so how did you fix it) technical summary of what you did.
task-<id>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed an error which appeared by choosing a Time Off Type in new Time Off
task-5380599