Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to solidjs#92.
Zed only picks up a grammar change once
revinextension.tomlis bumped, and nothing reminds anyone to do it.check-pin.shcompares thetooling/tree-sitter-rxtree at the pinnedrevwith HEAD's. When they differ, it fails and prints the last commit that touched the grammar as the rev to bump to.It compares trees rather than asking whether commits came after
rev. Arevset to a branch commit drops out ofmain's history after a squash merge, but the check should still pass as long as the grammar is the same.In CI it only fails on
main. A pull request that changes the grammar gets a warning instead: it can't pin its own squash commit, since that commit only exists after the merge, so the bump has to come in a follow-up.The workflow also changes:
tooling/tree-sitter-rx/**is inpaths, so grammar changes run it.fetch-depth: 0, because naming the commit to bump to needs history. The full history is about 7 MB, so I didn't try anything narrower.Locally it passes on the current pin. It fails on an older pin and names
b470614, and it fails on a temporary grammar commit and names that commit. I haven't seen it run in Actions yet.Based on
zed-rx, so the diff only shows this change.