Repository navigation
Conversation
With semantic_tokens on, Zed draws the server's tokens over the grammar's colours, and TypeScript's tokens call a source and an equation both a read-only variable. The server marks them with a modifier each; semantic_token_rules.json maps those to the styles highlights.scm uses for their declarations, variable.special and constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to solidjs#92. Needs #9.
With
semantic_tokenson, Zed draws the server's tokens over the grammar's colours. TypeScript calls a source and an equation both a read-only variable, so once the tokens are on, every read of either looks the same.#9 makes the server add a
sourceorequationmodifier. This PR addslanguages/reactivescript/semantic_token_rules.json, which maps them to the styleshighlights.scmalready gives the declarations:variable.specialfor a source andconstantfor an equation. Reads then get the same colour as declarations and writes.With the 0.3.1 server on npm nothing changes yet, and the README says so.
Based on
zed-rx, so the diff only shows this change.