Fixing an issue with the function Xml_print.compose_decl.
#348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing some typos.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in Xml_print.compose_decl where a literal \n string was being output instead of an actual newline character, which would make generated XML files invalid. The PR also includes several minor typo corrections in comments across the codebase.
Key changes:
- Fixed
compose_declto use character literal'\n'instead of escape sequence in quoted string - Corrected grammar from "have" to "has" in documentation comments
- Fixed missing space in function call formatting
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/xml_print.ml | Fixed literal \n bug by using %c format specifier with '\n' character |
| lib/svg_sigs.mli | Grammar correction in unary element comment (have → has) |
| lib/html_sigs.mli | Grammar correction in unary element comment (have → has) |
| lib/svg_f.ml | Added missing space between function name and argument |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the function
Xml_print.compose_decloutputs a literal\nat the end of the first line, instead of a newline character. This makes the generated files invalid.I also fixed some typos on the way.