Repository navigation
ppx_devtools.optcomp: gate patterns in the cases of a function - #2
Merged
Merged
Conversation
With OxCaml's ppxlib, the cases of a function are mapped with [self#list self#case] rather than [self#cases], so the [@if] attributes on their patterns were not evaluated. Gated cases are now dropped from [case], by raising an exception caught in [list]. Matching on [Pfunction_cases] directly is not an option, as it does not exist in ppxlib before 0.36. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With OxCaml's ppxlib, the cases of a function are mapped with
self#list self#caserather thanself#cases, so the@ifattributes on their patterns were not evaluated. Gated cases are now dropped from [case], by raising an exception caught inlist. Matching onPfunction_casesdirectly is not an option, as it does not exist in ppxlib before 0.36.