Repository navigation
ppx_devtools.optcomp: gate type declarations and constructors - #1
Merged
Merged
Conversation
hhugo
approved these changes
Oct 27, 2026
Member
|
@vouillon, I'll let you rebase and merge |
[@@if] can now be placed on type declarations (in structures and signatures), and [@if] on variant constructors and extension constructors. Together with the existing support for gated match patterns, this makes it possible to define a constructor only on some configurations. A type extension whose constructors are all gated out is dropped.
With OxCaml's ppxlib, gated patterns are not filtered in the cases of a function, so use a match instead in the test for now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hhugo
force-pushed
the
optcomp-type-gating
branch
from
October 27, 2026 13:54
9d2c977 to
7770a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@@ifcan now be placed on type declarations (in structures and signatures), and@ifon variant constructors and extension constructors. Together with the existing support for gated match patterns, this makes it possible to define a constructor only on some configurations. A type extension whose constructors are all gated out is dropped.