Conversation
cg505
approved these changes
Feb 9, 2020
| @@ -0,0 +1 @@ | |||
| ../staff/acct/add-to-group No newline at end of file | |||
Member
There was a problem hiding this comment.
should be a separate PR but I don't really care enough
cg505
approved these changes
Feb 9, 2020
ja5087
approved these changes
Feb 9, 2020
cg505
reviewed
Feb 10, 2020
| parser.add_argument('--os-type', type=str, default='linux', | ||
| help='os type') | ||
| parser.add_argument('--os-variant', type=str, default='debian9') | ||
| parser.add_argument('--os-variant', type=str, default='debian10') |
Member
There was a problem hiding this comment.
I thought that debian10 didn't exist in virt-install yet?
Member
There was a problem hiding this comment.
osinfo-query os | grep Debian seems to indicate yes on pandemic but not riptide so maybe it's a buster thing?
Member
There was a problem hiding this comment.
we probably shouldn't change the default yet in that case.
| print('Cancelled.') | ||
| sys.exit(2) | ||
|
|
||
| if args.ceph and args.vg != 'vg': |
Member
There was a problem hiding this comment.
we should store the default value in a global variable or something so we only have to change it in one place
| print('Cancelled.') | ||
| sys.exit(2) | ||
|
|
||
| if not args.ceph and args.ceph_pool != 'vm': |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested both options on scurvy and pandemic