Merged
Conversation
mbostock
commented
Apr 11, 2026
Member
Author
|
I think the snapshots don’t render correctly because node-canvas doesn’t support CSS Color Module Level 5 |
Contributor
|
I'm not seeing why it's preferable or simpler than the basic greyscale ramp + svg filter to add the color. (But as long as it works I'm fine with it.) |
Member
Author
|
It’s simpler because you don’t need the filter — as the diff shows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the SVG filter added in #2416 with a simpler
color-mix(…)which is available since the ramp legend directly sets context.fillStyle (and hence we don’t have to worry, as we did with the raster mark, about converting a color string into RGBA values). It also allows the caller to set the colorSpace when constructing an opacity legend, so that P3 colors can be used as intended.I’m not sure why the snapshots aren’t appearing correctly here; the tests seem to be correct locally.