feat(app-shell): Studio copilot draft marks, the remainder: the Permissions save surface, the data-objectstack README, inline element marks (objectui#12725)

[objectstack-fleet]

Part of #12725
Clause-②: no — the claim's condition was "unless a widget's exported prop changes". The new copilotAdded prop sits on WidgetProps (widgets.tsx), FieldsListEditorProps and FieldListRow, and none of them is on @object-ui/app-shell's published face. The package's exports is . only, and src/index.ts re-exports none of them (and no export *). The rest is a README paragraph and internal call sites.

Items 1–3 of the remainder in release 6280467303. Item 4, the live staging reading of the first real copilot draft, is not reachable from this seat and stays on the card, so this PR is Part of.

What changed

1. The Permissions pillar's draft save names its surface (metadata-admin/PermissionMatrixEditor.tsx). PermissionMatrixEditPage's save adds surface: 'studio' only when it is a package draft (packageId) and Studio hosts it (embedded). Studio's Access pillar mounts it with both. metadata-admin mounts it through the resource registry (ResourceEditPage renders EditPage with type and name only), so it states no surface there.

2. README (packages/data-objectstack/README.md). A new section, "Reading a Draft and Who Changed It", is one paragraph covering:

• getDraft answers the wire envelope;
• extractDraftBody;
• the three draftChanges readers: readDraftChanges (absent means not recorded), governingDraftChange (longest prefix; [] is the whole body; segments compared whole) and draftChangesUnder;
• the surface save option, 'studio' | 'api', sent once. When it is omitted the save is recorded as api. copilot is the server's own.

3. Inline element marks. WIDGETS['field-multi'] (a kanban card's fields) and FieldsListEditor (a view's columns, through FieldListRow) take an optional copilotAdded set. They draw the copilot's Draft chip (DraftChip, testid studio-draft-element-chip, data-draft-of the element) inside each marked element's row. With the prop absent, nothing is drawn and the markup is unchanged. ObjectListViewInspector passes the added set instead of drawing DraftElementList under each widget. When a copilot change to columns added no column (a reorder or a removal), the chip still sits beside the setting. DraftElementList had no other caller and is removed from StudioDraftMark.tsx.

Optional item (the tighter layered read): left as it is. A copilot entry governs an array setting when it sits at that path or at any ancestor (config, config.kanban, [] handled apart). The path also depends on whether the row is record-shaped (config or not), and the hook does not know that shape when it reads. That makes it more than one condition, and the ruling allowed it only as one.

Tests

New:

• metadata-admin/PermissionMatrixEditor.saveSurface-12725.test.tsx — pin (a). The REAL hosts (AccessPillar, and MetadataResourceEditPage through the built-in registration) save through a REAL MetadataClient whose transport records each PUT:
  • Studio leg: getAll('surface') equals ['studio'], with mode=draft and the package;
  • metadata-admin leg: getAll('surface') equals [].
• metadata-admin/previews/copilotAddedRowMark-12725.test.tsx — pin (b), for both widgets:
  • a marked element's row holds the chip, and the published row holds none;
  • CONTROL: with no copilotAdded, the markup has no chip and equals the markup for a set that marks nothing the widget holds.

Re-pointed:

• studio-design/ObjectListViewInspector.copilotMarks-12725.test.tsx — pin (c). The chip list under the widgets is gone, so markedElements reads the in-row chips by data-draft-of. The [] leg reads them in the widgets' own sections (list-view-kanban-fields, list-view-columns) instead of the removed list testids. The first leg also asserts that each added card field's row carries the mark and the published row does not.
• metadata-admin/PermissionMatrixEditor.layersUnsaved-11799.test.tsx — its exact query string now ends in &surface=studio, because it mounts the editor the way Studio hosts it (packageId + embedded).

Runs, under the shared lock with --maxWorkers=1:

• 71 test files naming or importing the touched modules (PermissionMatrixEditor, widgets, FieldsListEditor, ViewColumnPanes, ObjectListViewInspector, StudioDraftMark, the Access pillar). The first run had 1 failure, the layersUnsaved-11799 pin above; it passed after the update.
• 9 more files that mount AccessPillar or PermissionMatrixEditPage: all passed.
• At the final head: the five new and edited files, 29 tests, passed.
• The whole packages/app-shell and packages/data-objectstack directories are declared to CI.

Type-check:

• the closure build @object-ui/app-shell^... exited 0;
• @object-ui/app-shell type-check (tsc --noEmit && tsc -p tsconfig.test.json, so the test files are typed) exited 0 at the final head;
• @object-ui/data-objectstack type-check exited 0.

Ablation

Each mutation went through ablation-replace.mjs in wrap mode. Each restore is proven by blob hash equal to HEAD and an empty git diff HEAD.

1. surface: 'studio' sent unconditionally: the metadata-admin leg goes red (1 failed / 1 passed) and the Studio leg stays green. Restored 3694a08e82af.
2. The row mark dropped in field-multi: the in-row pins go red (3 failed / 8 passed). Restored 65bf9276b19b.
3. The row mark dropped in FieldListRow: the columns pins go red (2 failed / 9 passed). Restored 0f892bab3c4b.

The ablations ran at 16e61a3329. The two commits after it touch only test files: an unused import, and the widget context's required conditionScope.

Gates

At 233c059e1c, each exit code recorded:

• exit 0: phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity, control-bytes, new-line-citations, hand-rolled-comment-mask, changeset-fixed, changeset-presence.
• check:spec-floors exits 1, all of it [no-artifact] (packages not built here).
• ESLint over the 10 changed .ts/.tsx files (--no-inline-config, JSON format: 10 files): 0 errors, and no message on an added line. The config is not type-aware, so a narrowed run cannot change the verdict on an untouched file.
• check-governed-queue-guard --test over the 12 changed paths: NOT GOVERNED.

Acceptance notes

• StudioDraftMark.tsx is outside the claim's literal file surface. The edit there removes DraftElementList, which this change leaves with no caller, and widens the doc of DraftChip's of prop.
• In the field picker, the in-row chip reads the designer locale (useMetadataLocale), as that widget's other text does. The chip list it replaces read the panel's locale prop.

The implementing session is https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB.

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 77 chunks)	3210.2 KB	3744.1 KB
Main entry chunk (gzip)	81.5 KB	350 KB
Entry file	index-CDwpDLYA.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (buildIdentity.js)	0.80KB	0.49KB
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.17KB	7.81KB
app-shell (runtime-config.js)	24.52KB	8.48KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	45.59KB	12.03KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	42.84KB	11.66KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	615.08KB	149.86KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	252.96KB	70.67KB
fields (index.js)	292.36KB	74.70KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	41.40KB	12.01KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	55.04KB	16.10KB
plugin-charts (index.js)	85.14KB	23.42KB
plugin-chatbot (index.js)	238.47KB	56.30KB
plugin-dashboard (index.js)	147.53KB	39.95KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	265.63KB	70.60KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	184.11KB	47.60KB
plugin-gantt (index.js)	178.46KB	45.13KB
plugin-grid (index.js)	272.91KB	75.73KB
plugin-kanban (index.js)	64.49KB	19.83KB
plugin-list (index.js)	149.64KB	39.21KB
plugin-map (index.js)	27.17KB	9.00KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.31KB	11.88KB
plugin-tree (index.js)	15.27KB	5.40KB
plugin-view (index.js)	94.68KB	24.36KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	126.45KB	41.40KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.71KB	2.11KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (product-blocks.js)	0.20KB	0.19KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped