Skip to content

fix(app-shell): the app landing waits on its nav entries' pending API reads - #13105

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13097-landing-waits-reads
Oct 20, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13097-landing-waits-reads

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #13097
Clause-②: no

What

AppRootLanding (packages/app-shell/src/console/AppContent.tsx) now waits on the API reads of the nav entries it would choose between. This is direction (A), as triage 6279966884 set it.

A nav entry whose dataSource read is pending is hidden (objectui#13029). The landing used to choose from the trees with those entries already gone. Now it also asks the same two questions over the trees as they would be if every pending entry were shown once it answers. Those two questions are: which route does the landing pick, and does the app show this member nothing. If either answer differs, a pending read ahead of the first decided entry could still change the landing. The root then holds on the existing SkeletonGrid (test id app-landing-pending): it does not navigate and does not show AppNoAccessEmptyState. When the reads answer, it lands on the first entry the member is shown (objectui#12426). A failed read hides its entry, so the landing moves on. An app with no bound entry gets the same answer twice and lands on its first render.

There are no extra reads. useNavMemberGates now also returns readEntry, the read state its visible evaluator is already built on (NavMemberGatesWithReads). navEntriesShownOncePendingReadsShow reuses navEntriesShownToMember with one change: a pending entry's visible is treated as not yet decided, so the entry is kept. Every other gate applies unchanged. Both live in the hook module. Nothing is added to the package entry, and the NavMemberGates shape that other call sites build is unchanged.

Measured on base (d11174ad10), before the fix

These come from the new test file, run against the base sources through the real AppContent, with a stubbed apiFetch held pending:

  • (i) all-bound app, reads pending: the DOM held app-no-access-empty-state at /apps/crm.
  • (ii) first entry bound and pending, second plain: on first render the pathname was already /apps/crm/crm_case (the plain entry). The failing assertion was "expected '/apps/crm/crm_case' to be '/apps/crm'".

I took no browser reading because no backend was booted for this run. That gap is listed under Acceptance notes.

Pins (AppContent.landingWaitsReads-13097.test.tsx)

  • (a) All bound, pending: no no-access state and no navigation. Answering only the second read still holds, because the first is pending ahead of it. Answering the first lands on /apps/crm/crm_env.
  • (b) First bound and pending, second plain: no navigation while pending. If the read is ready and shown, it lands on the bound entry. If the read fails (HTTP 500), it lands on the plain entry.
  • (c) All bound, every read failed: the no-access state, as before.
  • (d) CONTROL: with no bound entry, it lands on the plain first entry. No read is made, and the hold never draws. A MutationObserver watches every node the document receives.

Ablation

The hold condition was replaced by false through ablation-replace.mjs (anchor 1 to 0, blob 9667c66bf4a0 to 5c960f6b8053). Result: (a) and both (b) cases went red, and (c) and (d) stayed green (3 failed, 2 passed). Restore was proven by blob hash: after the restore the file equals the HEAD blob 9667c66bf4a0, and git diff HEAD is empty.

Gates (final head 0b5e5b4b15 unless stated)

  • pnpm --filter "@object-ui/app-shell^..." build (closure): exit 0.
  • pnpm --filter @object-ui/app-shell type-check (tsc --noEmit && tsc -p tsconfig.test.json; the test config includes src/**/*.test.tsx): exit 0 on 0b5e5b4b15.
  • Targeted vitest on 0b5e5b4b15: the new file plus the 12426, 12079 and 13029 files. 4 files, 42 tests passed.
  • Family run on 49f45565fc: every test under packages/**/__tests__ and apps/**/__tests__ that names useNavMemberGates, navEntriesShownToMember or AppContent. 42 files (172 + 199 tests) passed. The only later commit is a type-only change (the area list is typed instead of any).
  • ESLint on the 3 changed source and test files (--no-inline-config; --format json counted 3 files): 0 errors. AppContent.tsx has 43 warnings against 44 on base, and useNavMemberGates.ts has 2 against 2. The flat config enables no type-aware linting, so this diff cannot move the verdict on any file it does not touch.
  • Battery, exit 0 each: check:phantom-deps, check:self-import, check:unreferenced-sources, check:doc-example-readers, check:handler-key-reads, check:side-effects-array, check:element-data-source-declaration, check:spec-symbols, check:action-forward-parity, check:designer-field-key-parity, check:icon-record-names, check:i18n-keys, check:i18n-drift, check:i18n-designer-parity, check:control-bytes, check:new-line-citations, scripts/check-hand-rolled-comment-mask.mjs, scripts/check-changeset-fixed.mjs and scripts/check-changeset-presence.mjs.
  • check-governed-queue-guard --test on the 4 paths: NOT GOVERNED.
  • Declared to CI: the full packages/app-shell directory (whole-package runs were not allowed by the dispatch lock rules) and pnpm lint.

Acceptance notes

  • No browser reading. The card's acceptance asks for one measured browser reading of an app whose first nav entry is bound. The named consumer is cloud#3002's 环境 row. That reading was not taken here, so it is NOT MEASURED. The reason: no backend was booted in this run.
  • A read that never settles holds forever. The landing holds as long as a deciding read is pending. A request that never resolves keeps the skeleton up, in the same way the permissions provider's fallback stays up while /me/permissions is unanswered. Nothing in this PR adds a timeout.
  • Test-harness note, no product change. The new file's useAuth mock hands back one stable value. AppContent re-reads the auth config whenever getAuthConfig's identity changes. A mock that returns a fresh function on every render (as the 12426 file's mock does) sends AppContent into an endless re-render once anything re-renders it. In this file, that showed up as a 15 s timeout as soon as a held read answered. The shipped provider is not affected.

Generated by Claude Code

… reads

A nav entry whose `dataSource` read is pending is hidden (objectui#13029), so
`AppRootLanding` used to choose past it: an all-bound app flashed the no-access
state, and an app whose first entry is bound landed on the next plain entry.

The landing is now also asked over the trees as if every pending entry were
shown once it answers. When the two answers disagree, the root holds on a
skeleton; when the reads answer, it lands on the first entry the member is
shown. The read state comes from `useNavMemberGates` (no new request).

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 77 chunks) 3209.4 KB 3744.1 KB
Main entry chunk (gzip) 81.6 KB 350 KB
Entry file index-DBu6Aczy.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (buildIdentity.js) 0.80KB 0.49KB
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.17KB 7.81KB
app-shell (runtime-config.js) 24.52KB 8.48KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 45.59KB 12.03KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 615.08KB 149.86KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 252.96KB 70.67KB
fields (index.js) 292.36KB 74.70KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.40KB 12.01KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 55.04KB 16.10KB
plugin-charts (index.js) 85.14KB 23.42KB
plugin-chatbot (index.js) 238.47KB 56.30KB
plugin-dashboard (index.js) 147.53KB 39.95KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 265.63KB 70.60KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 184.11KB 47.60KB
plugin-gantt (index.js) 178.46KB 45.13KB
plugin-grid (index.js) 272.91KB 75.73KB
plugin-kanban (index.js) 64.49KB 19.83KB
plugin-list (index.js) 149.64KB 39.21KB
plugin-map (index.js) 27.17KB 9.00KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.31KB 11.88KB
plugin-tree (index.js) 15.27KB 5.40KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 126.45KB 41.40KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.71KB 2.11KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (product-blocks.js) 0.20KB 0.19KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 20, 2026 01:13
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 20, 2026 01:13
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit d87e4f2 Oct 20, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-13097-landing-waits-reads branch October 20, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app landing: a nav entry whose dataSource read is pending is skipped as the landing (and an all-bound app flashes no-access)

2 participants