Skip to content

fix(app-shell): record form and modal form bind systemPermissions, so hasCapability answers on object fields (objectui#13083) - #13094

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13083-form-evaluator-capabilities
Oct 19, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13083-form-evaluator-capabilities

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #13083
Clause-②: no

What changed

An object field whose visibleWhen names current_user.hasCapability('NAME') is now answered on the record form page and in the console's global record-form modal.

The two surfaces build their field-list evaluator by hand, because each sits above the ExpressionProvider it mounts. Each passed permissions but not systemPermissions, so the engine refused every hasCapability call on a field, and the fail-open field gate showed the field to holders and non-holders alike, with a diagnostic. Page nodes, navigation and actions already answered through the provider (objectui#13006).

Each site now reads useExpressionSystemPermissions() beside useExpressionPermissions() and passes it to createExpressionEvaluator as systemPermissions, with the same name and shape the provider uses:

  • packages/app-shell/src/views/RecordFormPage.tsx (the record form page's expressionEvaluator);
  • packages/app-shell/src/console/AppContent.tsx (the modal form's expressionEvaluator).

Nothing is re-derived from MePermissionsProvider a second way. A not-loaded answer stays undefined, so the predicate still faults loudly; it is never turned into false or true. No export, key or prop moves, and @object-ui/core's evaluator is unchanged.

Every hand-built evaluator under packages/app-shell/src

createExpressionEvaluator( call sites outside tests, read at the branch base 6058bf8b71:

  • ExpressionProvider itself (the provider's own scope): already passes systemPermissions.
  • useExpressionContext()'s no-provider default: binds only user and features, deliberately; outside the provider there is no loaded answer, so leaving both permission inputs unbound is the documented "not loaded" state.
  • RecordFormPage and AppContent: the two sites this PR changes.

No third site carries the omission.

Tests

Two new suites drive the real components under a real MePermissionsProvider with a payload, reading the field list the page hands to ObjectForm and the modal hands to ModalForm:

  • packages/app-shell/src/views/RecordFormPage.hasCapability-13083.test.tsx
  • packages/app-shell/src/console/__tests__/AppContent.hasCapability-13083.test.tsx

Each has three arms on a field gated on current_user.hasCapability('manage_org_users'):

  • HOLDER: the field is shown and nothing is reported.
  • NON-HOLDER: the field is hidden and nothing is reported.
  • CONTROL, NOT LOADED (no provider): the predicate still faults loudly. The fault is reported naming the predicate, and the fail-open field gate shows the field.

AppContent mounts in a unit test, as AppContent.declaredVisibilityKeys.test.tsx already does, so the modal arms go through the real component rather than a copy of its evaluator.

Reverse verification

The direction was predicted before running. The fix was committed first (0ae227d904). Each site's hand-off line was then deleted with scripts/ablation-replace.mjs (objectstack checkout), whose anchor must hit once. Both suites ran each time.

  • Without the hand-off in RecordFormPage: anchor 1 to 0, blob 7358a6fba6d4 to d8e9897a7276. The record-form HOLDER and NON-HOLDER arms went red. The other 4 tests stayed green: the modal suite and the not-loaded control. Restored by blob hash: 7358a6fba6d4 equals HEAD, and git diff HEAD is empty.
  • Without the hand-off in AppContent: anchor 1 to 0, blob 787a250edc4d to 3587782483d2. The modal HOLDER and NON-HOLDER arms went red. The other 4 tests stayed green. Restored by blob hash: 787a250edc4d equals HEAD, and git diff HEAD is empty.

The HOLDER arm goes red through its silence assertion: the field is shown, but the fault is reported. The NON-HOLDER arm goes red because the field is shown.

Local verification (final head 73bc2d5e84)

  • pnpm --filter '@object-ui/app-shell^...' build (the dependency closure), then pnpm --filter @object-ui/app-shell type-check, which runs tsc --noEmit and tsc -p tsconfig.test.json: exit 0. --listFilesOnly confirms that both new test files are inside tsconfig.test.json.
  • The new suites: 2 files, 6 tests passed.
  • The test family that imports or reads the two touched files, plus hasCapability-13006 and currentUserCan-4421: 50 files in three batches, 413 tests passed, --maxWorkers=1, under the shared lock.
  • eslint --no-inline-config on the 4 changed source and test files: 0 errors. The new test files have 0 warnings. The 2 production files have only warnings that were already there, none of them on a changed line.
  • check:phantom-deps, check:self-import, check:unreferenced-sources, check:doc-example-readers, check:handler-key-reads, check:side-effects-array, check:element-data-source-declaration, check:spec-symbols, check:action-forward-parity, check:designer-field-key-parity, check:icon-record-names, check:i18n-keys, check:i18n-drift, check:i18n-designer-parity and check:control-bytes: each exited 0.
  • scripts/check-hand-rolled-comment-mask.mjs, scripts/check-changeset-fixed.mjs, scripts/check-changeset-presence.mjs and check:new-line-citations (0 new citations): each exited 0.

Left to CI: the full packages/app-shell test directory. The dispatch kept the lock clear of whole-package runs.

Changeset: .changeset/13083-form-evaluator-capabilities.md (@object-ui/app-shell patch).


Generated by Claude Code

…ty answers on object fields

RecordFormPage and AppContent's record-form modal build their field-list
evaluator by hand and passed `permissions` without `systemPermissions`, so a
field `visibleWhen` naming `current_user.hasCapability(NAME)` faulted (and
failed open) there while page predicates answered. Each site now reads
`useExpressionSystemPermissions()` beside `useExpressionPermissions()` and
hands it on, the way the ExpressionProvider scope does.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 77 chunks) 3208.0 KB 3744.1 KB
Main entry chunk (gzip) 81.5 KB 350 KB
Entry file index-CkUwEo0X.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (buildIdentity.js) 0.80KB 0.49KB
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.17KB 7.81KB
app-shell (runtime-config.js) 24.52KB 8.48KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 45.59KB 12.03KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 615.08KB 149.86KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 252.05KB 70.40KB
fields (index.js) 292.36KB 74.70KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.33KB 11.96KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 55.04KB 16.10KB
plugin-charts (index.js) 85.14KB 23.42KB
plugin-chatbot (index.js) 238.47KB 56.30KB
plugin-dashboard (index.js) 147.53KB 39.95KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 265.63KB 70.60KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 184.11KB 47.60KB
plugin-gantt (index.js) 178.46KB 45.13KB
plugin-grid (index.js) 272.91KB 75.73KB
plugin-kanban (index.js) 64.49KB 19.83KB
plugin-list (index.js) 148.80KB 38.90KB
plugin-map (index.js) 27.17KB 9.00KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.31KB 11.88KB
plugin-tree (index.js) 15.27KB 5.40KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 126.45KB 41.40KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.71KB 2.11KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (product-blocks.js) 0.20KB 0.19KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants