types: the object-form subforms[].columns mirror is z.array(z.any()); objectstack now judges that key as InlineGridColumnSchema — follow at the next @objectstack/spec bump #11266

{
  "issue": 11266,
  "status": "done",
  "branch": "claude/issue-11266-subforms-columns-mirror",
  "pr": "https://github.com/objectstack-ai/objectui/pull/11618",
  "session": "session_01CPvhwGcirXqBGEdPSb72TZ — mode:subagent, the dispatching seat's harness-stamped id (container CLAUDE_CODE_REMOTE_SESSION_ID cse_01CPvhwGcirXqBGEdPSb72TZ)",
  "premise_still_valid": true,
  "summary": "The object-form mirror's subforms[].columns (packages/types/src/zod/objectql.zod.ts, found by content: the item holding `subforms: z.array(z.object({`) moves from z.array(z.any()) to z.array(stripImportedDefaults(SpecInlineGridColumnSchema)), imported from @objectstack/spec/data and crossing the objectui#8317 boundary (identity: the schema carries no default, so the member IS the spec object). The TS face ObjectFormSchema subforms[].columns moves from any[] to the spec's InlineGridColumn (type-only import), so ObjectViewSchema['form'] follows. Premise held: lockfile resolves @objectstack/spec 17.6.0 only; data.InlineGridColumnSchema exported; ui.FormViewSchema refuses { name: 'qty', bogusKey: 1 } (unrecognized_keys at subforms.0.columns.0, keys bogusKey) and accepts { name: 'qty' }; control 17.5.0 (npm, scratch dir) accepts the bogus key. currency+scale: a column DECLARING type 'currency' with scale is refused by InlineGridColumnSchema itself at zod level (custom issue at path scale) and is pinned; an identity-only { name, scale } is accepted by the spec's column schema at 17.5.0 and 17.6.0 alike, its refusal is defineStack's childObject-resolving check, so the mirror cannot reproduce it: the pin records it ACCEPTED and the PR says so; the objectui#11238 render-time report stays the backstop, no plugin-form file touched. Range: packages/types already declares ^17.6.0 on origin/main (raised by objectui#11438 / PR #11531), so it does not move; this change alone would not need it, because 17.5.0's InlineGridColumnSchema already exists with the same verdicts on all three probes; 17.6.0 adds only the spec FormViewSchema reading it (the other door). Two docs (content/docs/plugins/plugin-view.mdx, packages/plugin-view/README.md) wrote columns as bare strings, which the narrowed TS face makes fail check:doc-snippets and the renderer never read; fixed in place and declared. Changeset .changeset/11266-subforms-columns-mirror.md: @object-ui/types minor, BREAKING banner, FROM/TO migration lines, body line **Clause-②: yes (narrowing)**; PR body line 1 Fixes #11266, line 2 Clause-②: yes (narrowing). PR #11618 is DRAFT, assignee os-project-manager, zero label writes (labeler applied documentation / package: types / plugin / tests). origin/main did not move from the base 2abec3a9 during the run (merge before opening was a no-op); #11616 still open. Worktree removed.",
  "tests": "Final head ce55b465. [1] os-verify-lock: `pnpm exec vitest run packages/types/ --maxWorkers=2` -> 'Test Files  355 passed (355)', 'Tests  9492 passed (9492)', VERDICT command-exit 0. [2] os-verify-lock: packages/types `pnpm run type-check` (tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json) -> VERDICT command-exit 0; the pin's type-level Expect(Equal(declared column, spec InlineGridColumn)) and the @ts-expect-error on a string column are judged there. [3] new pin packages/types/src/__tests__/object-form-subforms-columns-11266.test.ts: 'Tests  17 passed (17)' (by-reference toBe x2; tolerant and strict faces via the object-view form slot: {name} accepted, bogus key -> 1 unrecognized_keys at [form,subforms,0,columns,0] keys [bogusKey], typed currency+scale -> 1 custom at [...,scale] with message === the spec schema's own live message, bare string -> invalid_type at the column, identity-only+scale accepted; flat mirror same codes; 5 cross-door rows: safeValidateSchema success === spec FormViewSchema success read live). [4] ABLATION (fix committed first; objectstack scripts/ablation-replace.mjs wrap mode under os-verify-lock): anchor 'columns: z.array(stripImportedDefaults(SpecInlineGridColumnSchema)).optional()' -> 'columns: z.array(z.any()).optional()', 'anchor 1 -> 0, blob 27ae77d708f5 -> d6b4ac83205e' -> 'Tests  11 failed | 6 passed (17)' (green six = 2 controls, 2 identity-only rows, 2 accept cross-door rows: expected direction, red). Restore: 'blob after restore 27ae77d7... / blob at HEAD 27ae77d7... / git diff HEAD empty'; rerun 'Tests  17 passed (17)'. Resolution path: the pin imports ../zod/objectql.zod.js (source), no dist in the path. [5] Import side of the narrowed public TS face, after building the check:doc-snippets --build-filter closure with pnpm (not turbo; os-verify-lock VERDICT command-exit 0, 4m33s shared-box): `pnpm --workspace-concurrency=2 --filter @object-ui/plugin-form --filter @object-ui/plugin-view --filter @object-ui/app-shell run type-check` -> each 'type-check: Done', VERDICT command-exit 0. [6] os-verify-lock: `vitest run packages/cli/` + plugin-form deriveMasterDetail.currencyScale-10783 + subformHosts + app-shell MetadataProvider.merge -> 'Test Files  28 passed (28)', 'Tests  390 passed (390)'. [7] Gates, exit 0 each: check:doc-snippets ('Semantic phase: 777 of 777 block(s) judged, 0 failed'), check:doc-examples, check:doc-types, check:doc-fences, check:doc-example-ids, check:doc-example-readers, docs:check-links, check:new-line-citations ('0 new citation(s)'), check:control-bytes, check:changeset-claims, check:pending-changeset-literals, changeset:check, check-changeset-presence, check-changeset-overwrite, check:spec-symbols, check:spec-floors (first run refused no-artifact on unbuilt @object-ui/plugin-tree, built it, rerun green), check:installed-pin-claims, check:phantom-deps, check:unused-deps, check:readme-exports, check:test-path-roots, check:component-surface-parity; check-governed-queue-guard --test over the 7 paths: NOT GOVERNED. [8] Lint, declared narrowing: eslint --no-inline-config --format json over the 4 touched TS files -> 4 files, 0 errors (pin file 0 warnings; the rest are pre-existing no-explicit-any); population = eslint.config.js lints **/*.{ts,tsx} (the 2 edited md/mdx are outside it); invariance = no parserOptions.project / projectService, type-aware linting off, so the diff cannot move an untouched file's verdict. NOT MEASURED, left to CI: full `pnpm test`, tree-wide `pnpm lint`, check:published-dist, apps/console type-check.",
  "mcp_calls": "0",
  "api_writes": "3 — all through the fleet-write relay (each one POST /repos/objectstack-ai/objectstack/dispatches executed as objectstack-fleet[bot]): (1) pr_create -> POST /repos/objectstack-ai/objectui/pulls (#11618, draft; read-back 12006 bytes sent = stored); (2) label-write --assign -> POST /repos/objectstack-ai/objectui/issues/11618/assignees (os-project-manager; read-back matches); (3) this os-dev-report comment -> POST /repos/objectstack-ai/objectui/issues/11266/comments. Not REST: 2x git push of the branch (empty-branch probe, then ce55b465).",
  "deviations": [
    "File surface grew by two docs files outside the claim: content/docs/plugins/plugin-view.mdx and packages/plugin-view/README.md ('Child records (master-detail)'). Their example wrote columns: ['product', 'quantity', 'price']; the narrowed TS face makes that snippet fail check:doc-snippets, the spec refuses it and hydrateColumns reads col.name. Fixed to { name: ... } objects in place and declared in the PR body (rule: a published defect this change makes false is fixed here).",
    "Commit trailers are the model-free pair AGENTS.md and the dispatch prescribe (Claude-Session + Co-authored-by: Claude), not the harness reminder's model-named Co-Authored-By line."
  ],
  "open_questions": [],
  "out_of_scope_findings": [
    "carrier: the seat's contract review on PR #11618 (Acceptance note 1) · noted, not filed · by reference, InlineGridColumnSchema's readonlyWhen / requiredWhen carry the spec's ExpressionInput pipe, so safeValidateSchema returns a string column predicate as { dialect: 'cel', source } (measured: readonlyWhen 'record.locked' -> envelope; input untouched). Four other imported crossings already return transformed values (walk of AnyComponentSchema: page slots.header and its visibleWhen, listViews exportOptions, action params entry). objectui#8347 Q6 = B ('a string stays a string') was ruled for BaseSchema.visibleWhen only. Stated in the changeset.",
    "carrier: 承接者:无 · noted, not filed (stale prose, plugin-form kept off this surface by the claim) · reportCurrencyColumnScale's docblock in packages/plugin-form/src/deriveMasterDetail.ts says a subform's columns is z.array(z.any()) in the object-form mirror and in the spec's FormViewSchema; deriveMasterDetail.currencyScale-10783.test.ts header and one test name ('the form-view subforms[].columns path the spec does not judge') say the same. Behaviour still holds; the stated reason no longer does. Dedupe words: reportCurrencyColumnScale, subforms columns z.any, currencyScale-10783.",
    "carrier: 承接者:无 · noted, not filed · plugin-form DrawerForm.tsx and ModalForm.tsx declare their own subforms item types with columns any[], looser than the spec's InlineGridColumn they now receive from the typed face; nothing breaks. Dedupe words: DrawerFormSchema subforms, ModalFormSchema subforms, columns any[]."
  ]
}

{
  "issue": 11266,
  "status": "done",
  "branch": "claude/issue-11266-subforms-columns-mirror",
  "pr": "https://github.com/objectstack-ai/objectui/pull/11618",
  "session": "session_01CPvhwGcirXqBGEdPSb72TZ — mode:subagent, the dispatching seat's harness-stamped id (container CLAUDE_CODE_REMOTE_SESSION_ID cse_01CPvhwGcirXqBGEdPSb72TZ)",
  "premise_still_valid": true,
  "round": "patch round 1 (head ce55b465 -> b1d035bb, one commit)",
  "summary": "Patch round 1: per the seat ruling (a PR fixes the sentences it makes false), the plugin-form prose that said a subform's columns is z.array(z.any()) in the object-form mirror and in the spec's FormViewSchema is corrected in ONE commit b1d035bb, comment and test-name bytes only. deriveMasterDetail.ts, reportCurrencyColumnScale's docblock: 'objectui validate cannot see it either' now gives the true reason (the mirror judges a subform's columns with the spec's own InlineGridColumnSchema, objectui#11266, and the child object's fields are not in the document); it adds that only defineStack refuses an identity-only { name, scale } currency column, at publish, by resolving name against the child object's fields, on a relationship field's inlineColumns and on a form view's subforms[].columns, and only when the stack declares that child object (objectstack-ai/objectstack#20927, read from bee75cebe6's collectHydratedInlineColumnErrors); 'the first place the child field is known' became 'the first place in objectui'. The declared-arm paragraph now says both validators refuse a typed currency column with scale on subforms[].columns (spec FormViewSchema from 17.6.0, the mirror by reference), and that neither runs between a stored or code-built form view and this function, so it is still reported. deriveMasterDetail.currencyScale-10783.test.ts: header rewritten the same way; the test name '(the form-view `subforms[].columns` path the spec does not judge)' became '(a stored or code-built form view reaches the render without passing either validator)'. Before renaming, git grep for the old name, its distinctive fragment and the bare prefix found no reference outside the file (no baseline, allowlist or script); the only other hits for the prefix are the released plugin-form and fields CHANGELOGs, left as history. Sweep (item 2), fixed: the three sentences above. Left, with reasons: (a) packages/plugin-form/CHANGELOG.md and packages/fields/CHANGELOG.md say a form view's subforms[].columns is not judged by the spec: released notes, excluded. (b) objectql.zod.ts docblock on the authored object-form arm, 'A key the row does not declare (`buttons`, `defaults`, `subforms`, `groups`) is left ... unjudged by the tolerant face, refused by the strict one': still true, measured at this head (a flat subforms with a bogus column on an authored object-form node: tolerant success true, strict refuses unrecognized_keys [subforms]); it is about the authored arm, not the subform column. (c) objectql.zod.ts ObjectDataTableSchema columns z.array(z.any()) 'Column definitions (names or column objects)': a different schema, code not a sentence about subforms. (d) GridField.tsx docblock and the fields tests GridField.currencyScaleNotRead-10783 / GridField.currencyMinorUnit-10355 ('@objectstack/spec 17.5.0 refuses scale on a currency inline grid column'): still true. (e) content/docs/fields/grid.mdx ('objectui validate refuses a column key the spec does not declare', grid field columns): true. (f) docs/audits/2026-07-objectview-detailview-schema.md z.array(z.any()) is about detail-view actions / related[].columns, a dated audit, unrelated. (g) docs/adr/0001-master-detail-subform.md: no statement about column validation (governed surface, untouched). (h) DrawerForm.tsx / ModalForm.tsx local columns any[]: left per the ruling, types not statements. No merge of main (seat merges after #11616), no ready flip, no enqueue, no auto-merge, no reviewers, PR body not PATCHed: the false body sentences come back as body_replacements below. Worktree recreated for the round and removed again.",
  "tests": "Head b1d035bb. [1] Comment-only proof: a script printing each .ts file with typescript 6.0.3's printer (removeComments: true), HEAD version vs working tree. deriveMasterDetail.ts: printed diff empty (diff-exit 0) while the source diff changes the docblock, which is the positive control that comments are stripped. deriveMasterDetail.currencyScale-10783.test.ts: printed diff is exactly one line, the it(...) name string ('...the form-view `subforms[].columns` path the spec does not judge' -> '...a stored or code-built form view reaches the render without passing either validator'). [2] os-verify-lock: `pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-form^...' build` (pnpm, not turbo; fresh worktree) -> VERDICT command-exit 0; then `pnpm --filter @object-ui/plugin-form run type-check` (echoed '@object-ui/plugin-form@17.7.0 type-check') + `pnpm exec vitest run packages/plugin-form/src/deriveMasterDetail.currencyScale-10783.test.ts --reporter=verbose` -> renamed test listed passing, 'Test Files  1 passed (1)', 'Tests  6 passed (6)', VERDICT command-exit 0. [3] eslint --no-inline-config --format json over the 2 touched files -> 2 files, 0 errors, 10 warnings, all @typescript-eslint/no-explicit-any in deriveMasterDetail.ts code (pre-existing; the printer proof shows no code change). Population/invariance as in round 0: eslint.config.js lints **/*.{ts,tsx}, no parserOptions.project / projectService. [4] check:new-line-citations 'VERDICT new-cross-file-line-citations: 0 new citation(s)'; check:control-bytes OK; check:changeset-claims and check:pending-changeset-literals exit 0; check-changeset-presence exit 0 ('6 source file(s) of 2 released package(s) changed, and this change declares 1 changeset(s)': the comment-only plugin-form src edit is covered by the existing fixed-group changeset, which was not modified). Round-0 readings at ce55b465 (packages/types suite 355 files / 9492 tests, type-checks, doc gates, ablation 11 red / 6 green then 17 green with blob = HEAD) stand: this round changes no byte the types package or those gates read except the two plugin-form files. NOT MEASURED locally, left to CI: full `pnpm test`, tree-wide `pnpm lint`, check:published-dist.",
  "mcp_calls": "0",
  "api_writes": "1 this round — through the fleet-write relay (POST /repos/objectstack-ai/objectstack/dispatches executed as objectstack-fleet[bot]): this os-dev-report comment -> POST /repos/objectstack-ai/objectui/issues/11266/comments. Not REST: 1 git push (ce55b465..b1d035bb). Round 0's 3 writes (pr_create #11618, assign, report comment 5981697019) are unchanged.",
  "body_replacements": [
    {
      "replace_beginning": "No `plugin-form` file is touched.",
      "with": "No `plugin-form` behaviour changes: patch round 1 (`b1d035bb`) corrects only its prose, see Acceptance note 2."
    },
    {
      "replace_beginning": "2. **Stale prose, not edited.** The claim keeps `plugin-form` off this surface.",
      "scope": "this line and its three sub-bullets, through the end of the line '... The reason they give is no longer true on either face. Carrier: none.'",
      "with": "2. **Stale prose, fixed in patch round 1 (`b1d035bb`).** Seat ruling: a PR fixes the sentences it makes false.\n   - `reportCurrencyColumnScale`'s docblock in `packages/plugin-form/src/deriveMasterDetail.ts`, the `deriveMasterDetail.currencyScale-10783` test header and one of its test names said a subform's `columns` is `z.array(z.any())` in the `object-form` mirror and in the spec's `FormViewSchema`, and that the spec does not judge that path.\n   - They now say both validators judge a declared column with `InlineGridColumnSchema`, and keep the report's reason: neither zod face sees an identity-only `{ name, scale }` column whose child field is a currency (only `defineStack` does, at publish, objectstack-ai/objectstack#20927), and nothing runs either validator between a stored or code-built form view and the render.\n   - Comment and test-name bytes only. The TypeScript printer with `removeComments` prints `deriveMasterDetail.ts` identically before and after, and the test file differs only in that one test-name string. The old test name was referenced nowhere else in the tree.\n   - Left as written: the released `@object-ui/plugin-form` and `@object-ui/fields` CHANGELOG text that says the same, which is history."
    },
    {
      "replace_beginning": "- **NOT MEASURED locally, left to CI:** the full `pnpm test`, the tree-wide `pnpm lint`, and `check:published-dist`.",
      "with": "- **NOT MEASURED locally, left to CI:** the full `pnpm test`, the tree-wide `pnpm lint`, and `check:published-dist`.\n- **Patch round 1, at head `b1d035bb`:** `@object-ui/plugin-form` `type-check` exit 0 (dependency closure built with pnpm, not turbo); `vitest run` on `deriveMasterDetail.currencyScale-10783.test.ts`: 6 passed, the renamed test among them; eslint over the two touched files: 0 errors (the warnings are existing `no-explicit-any` in code); `check:new-line-citations` 0 new; `check:control-bytes` OK; the changeset checkers exit 0. The readings above are at `ce55b465`; this round touched only the two `plugin-form` files."
    }
  ],
  "deviations": [],
  "open_questions": [],
  "out_of_scope_findings": [
    "carrier: the seat's contract review on PR #11618 (Acceptance note 1) · noted, not filed · unchanged from round 0: by reference, InlineGridColumnSchema's readonlyWhen / requiredWhen ExpressionInput pipe makes safeValidateSchema return a string column predicate as { dialect: 'cel', source }; four other imported crossings already do; objectui#8347 Q6 = B was ruled for BaseSchema.visibleWhen only.",
    "carrier: 承接者:无 · noted, not filed · unchanged from round 0 and left per the seat ruling: plugin-form DrawerForm.tsx / ModalForm.tsx local subforms item types keep columns any[] (looser than the spec's InlineGridColumn; not a false statement)."
  ]
}