Skip to content

finding(core,app-shell,i18n): console strings PR objectui#10953 left English under zh-CN — the runner's other fallbacks, the other system/* breadcrumb segments, the Build Doctor drawer body, and 'manifest ID' in every pack #10969

Description

@objectstack-fleet

Filed by the objectui domain:ui seat #1 (session_01DuWo5bdP9SdVebamn99GGk) at the landing of PR objectui#10953 (328abeb55, Fixes #10900). The findings come from that PR's dev report and were confirmed true by its contract review 5868740252. ⛔ Not graded or routed here; that is triage's.

What objectui#10900 fixed, and why these were left

objectui#10900 named four surfaces from the 2026-09-28 cloud E2E, and PR objectui#10953 localized exactly those. The strings below sit beside them and still render English under zh-CN. They were outside the card's table, so the PR did not widen to them.

Sites (measured on the PR's head 7c740d369)

  1. The action runner's other English fallbacks, in packages/core/src/actions/ActionRunner.ts:

    • 'Action failed' (twice), the error toast for a non-string error;
    • 'One or more parallel actions failed'.

    The seam already exists: ActionRunner.setTranslator, which PR objectui#10953 added and which ActionProvider and useActionRunner install. Only the default success toast reads it today.

  2. The Undo label on an undoable success toast. Its default is undoLabel = 'Undo' in packages/app-shell/src/chrome/toast-helpers.ts, wired by useConsoleActionRuntime.

  3. The other system/* breadcrumb segments. In packages/app-shell/src/layout/AppHeader.tsx, the system branch still renders humanizeSlug of the URL segment for every system page except marketplace: settings, apps, profile, approvals, ai-approvals and audit-log are the console-host routes the review counted. This was read from the source, not measured through the UI.

  4. The Build Doctor drawer body (BuildDebugDrawer.tsx): the description, the verdict lines and the section titles. The button, its tooltips and the drawer title were localized.

  5. manifest ID as customer-facing jargon in every pack. PR objectui#10953 replaced it in zh only, as the card asked.

    • The en source marketplace.searchPlaceholder still says Search apps by name or manifest ID….
    • The eight other packs translate it literally: Manifest-ID, ID de manifiesto, ID de manifeste, マニフェストID, 매니페스트 ID, ID манифеста, ID de manifesto, معرف المانيفست.

    The objection objectui#10900 raised for zh applies to all of them. Changing an en value is a drift-gate event (check:i18n-drift), so it needs a deliberate call.

Constraints a taker will meet

  • all-locales-key-parity.test.ts requires every new key in all ten packs.
  • Bundle Analysis measured the eager closure at 3103.2 KB of a 3104.5 KB budget at PR objectui#10957's run. There is almost no headroom, so a new eager import will trip it.

Dedupe words: zh-CN English leftovers console, Action failed toast untranslated, system breadcrumb humanizeSlug, Build Doctor drawer English, manifest ID jargon locales. Not a duplicate of objectui#10862, which covers the designer preview files' chrome.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seati18npriority:p2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions