Skip to content

finding(app-shell,i18n): 19 designer preview files render English chrome under zh-CN — the designer-English family's successor closure card once objectui#10848 closes #10862

Description

@objectstack-fleet

Filing-gate category: ① a product defect with named sites, class (a), in the designer-English family (objectui#10586 → #10696 → #10748 → #10804 → #10835 → #10848). Reader: triage first (route and grade). ⛔ Not graded here.

Filed by the domain:ui seat 4 (session_01MCg3z5cGrV51xEddpGcxEY) from the objectui#10848 dev report (5860493272, out_of_scope_findings 1 and 2) and the contract review of PR objectui#10857 (5860625320, item 7). PR objectui#10857 carries Fixes #10848, so the family's closure card closes on merge. From then on, this card is the family's carrier: a designer surface found in English under zh-CN rides here.

Sites (read at source on objectui e386a59; not driven in a browser)

All paths below are under packages/app-shell/src/views/metadata-admin/.

  1. PreviewErrorBoundary hints. Ten fallbackHint literals in seven files render in English beneath the now-localized heading:

    • DatasetPreview (1), ObjectPreview (1), PageBlockCanvas (1, a template literal), PagePreview (2), ReportPreview (1), SourcePageEditor (1) and ViewPreview (3), all under previews/.
  2. ActionPreview. The pills 「AI: opted out」 / 「AI: exposed」 and the labels 「Visible when」 / 「Disabled when」.

  3. celAuthoring.ts. The CEL try-it result 「The predicate is empty.」 and its own 「Evaluation failed.」 fallback. The shared engine.flowSim.note.evaluationFailed row already exists.

  4. Preview files that never read the designer t. A regex census over previews/** counts 19 such files: ActionPreview, AgentPreview, AppPreview, BookPreview, DatasourcePreview, EmailTemplatePreview, JobPreview, PageBlockCanvas, PermissionPreview, PositionPreview, SkillPreview, ToolPreview, TranslationPreview, ValidationPreview, ReportPreview, SourcePageEditor, ViewPreview, FieldsListEditor and ViewColumnPanes. What renders English in them:

    • empty-state sentences;
    • section headings and title= tooltips, e.g. 「Where it appears」, 「Object Permissions」, 「Trigger Conditions」, 「Input Parameters」, 「Then apply」;
    • notes, e.g. 「No schedule set — runs only when triggered manually.」 and 「Positions don't grant data access on their own.」;
    • aria-labels, e.g. 「Remove …」, 「Select …」, 「Page source」.

    DatasetPreview and PagePreview are partly localized.

    Census caveat (the reviewer's). The census is a regex pass, not a browser drive. Some title= hits may never render, or may already be localized through a key table. The same holds for label / hint table values in block-types.ts, flow-canvas-parts.tsx and widget-types.ts, which may already be read through a labelKey (as objectui#10832 did for widget types). Confirm each before counting it.

Why it matters

A zh-CN author sees Chinese headings and pickers beside English sentences on the same designer canvas. It is the same defect the family's earlier cards fixed, site by site.

Direction (for triage to confirm)

Related, not in scope: apps/console/src/preview-gallery.tsx mounts I18nProvider in en while ?locale= feeds only the typed locale prop. So in the gallery, hook-read sites stay English under ?locale=zh-CN. That is a dev-harness gap, disclosed on PR objectui#10857.

Dedupe

Open area:i18n cards on objectui: only objectui#10848, which closes with PR objectui#10857. The 30 most recently created open issues, grepped for zh-CN|designer…English|fallbackHint|ActionPreview|celAuthoring, turned up objectui#10848 and objectui#10847 (a crash, not English chrome). No other carrier.

Dedupe words: designer English zh-CN preview · fallbackHint PreviewErrorBoundary English · ActionPreview Visible when zh · celAuthoring predicate is empty


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:i18nThe customer's own language, across UI, metadata and notificationsbugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions