Skip to content

[maintainer] refactor(app-shell): move the Interfaces nav rail out of StudioDesignSurface.tsx (slice 3) #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Nov 4, 2026
+518 −465
Merged

[maintainer] refactor(app-shell): move the Interfaces nav rail out of StudioDesignSurface.tsx (slice 3) #30014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/29988-studio-interfaces-nav-rail-module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@object-ui/app-shell': patch
---

internal: move-only — the Studio Interfaces pillar's navigation rail moves out of `StudioDesignSurface.tsx` into its own module (#29988, slice 3)

Clause-②: no
Metadata-protocol: none

No behaviour change. The rail Studio's Interfaces pillar draws for an app's navigation (the nav tree and its groups, the rows a customization package contributes, the off-nav sections for pages, dashboards, reports and views, the two rail contexts, the kind names and kind icons) now lives in `views/studio-design/InterfacesNavRail.tsx`. The moved code is byte-identical apart from its imports and eleven `export`s; `StudioDesignSurface.tsx` imports it from there. The package's public exports are unchanged.
1 change: 1 addition & 0 deletions ui/packages/app-shell/src/__tests__/homeRecoveryRedirectsFollowDeclaration-7373.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const RECOVERY_SITES: ReadonlyArray<{
alsoReads: [
'packages/app-shell/src/views/studio-design/StudioNavItemInspector.tsx',
'packages/app-shell/src/views/studio-design/PackageSwitcher.tsx',
'packages/app-shell/src/views/studio-design/InterfacesNavRail.tsx',
],
site: 'Studio: deleted-package eviction + header Home',
expression: /const homePath = useHomePath\(\)/,
Expand Down
2 changes: 1 addition & 1 deletion ui/packages/app-shell/src/views/metadata-admin/PackagesPage.confirmFlows-11784.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ describe('PackageDetailSheet — no native dialog on these three paths (objectui
describe('Console Packages page — a delete there stays on the page (objectui#11784)', () => {
/**
* Studio's return to its landing after a delete is the Studio HOST's
* (`PackageSwitcher`'s eviction in `StudioDesignSurface.tsx`), not the
* (`PackageSwitcher`'s eviction in `PackageSwitcher.tsx`), not the
* sheet's. The same sheet serves this console page, whose `onChanged` only
* reloads the list; `/studio` is not a destination here.
*/
Expand Down
Loading
Loading