Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/25467-e2-1b-metadata-item-layered-reads.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@objectstack/metadata-protocol': patch
---

refactor(metadata-protocol): the metadata item reads and the layered read move out of `protocol.ts` through the protocol host

Clause-②: no
Metadata-protocol: none

No behaviour change. The bodies of `getMetaItem`, `getMetaItemForExecution`, `readMetaItem`, `packagelessLayeredReadRefusal` and `getMetaItemLayered` now live in `protocol-meta-item-reads.ts` and `protocol-meta-layered-reads.ts`, reached through the per-instance host (`protocol-host.ts`). Each method keeps its docblock and signature on `ObjectStackProtocolImplementation`, and each moved body differs from the method body only by `this.` reading `host.`. The published `index.d.ts` (ESM and CJS) is byte-identical to the one `main` builds before this change. Nothing to migrate.
22 changes: 22 additions & 0 deletions packages/metadata-protocol/src/protocol-host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,31 +59,53 @@ export interface ProtocolHost {
readonly convertStoredItem: ObjectStackProtocolImplementation['convertStoredItem'];
readonly declinesStoredRow: ObjectStackProtocolImplementation['declinesStoredRow'];
readonly disabledActionsOf: ObjectStackProtocolImplementation['disabledActionsOf'];
readonly draftPublishVerdict: ObjectStackProtocolImplementation['draftPublishVerdict'];
readonly engine: ObjectStackProtocolImplementation['engine'];
readonly environmentId: ObjectStackProtocolImplementation['environmentId'];
readonly expandStoredViewContainers: ObjectStackProtocolImplementation['expandStoredViewContainers'];
readonly findEnvironmentRows: ObjectStackProtocolImplementation['findEnvironmentRows'];
readonly findPairAddedMemberRow: ObjectStackProtocolImplementation['findPairAddedMemberRow'];
readonly findServedOverlayRow: ObjectStackProtocolImplementation['findServedOverlayRow'];
readonly flowRegistrationsOf: ObjectStackProtocolImplementation['flowRegistrationsOf'];
readonly foldObjectExtendersFromRegistry: ObjectStackProtocolImplementation['foldObjectExtendersFromRegistry'];
readonly getServicesRegistry: ObjectStackProtocolImplementation['getServicesRegistry'];
readonly governServedObject: ObjectStackProtocolImplementation['governServedObject'];
readonly hydrateOverlayIntoRegistry: ObjectStackProtocolImplementation['hydrateOverlayIntoRegistry'];
readonly isArtifactBacked: ObjectStackProtocolImplementation['isArtifactBacked'];
readonly isStoredEntryOfDeclinedName: ObjectStackProtocolImplementation['isStoredEntryOfDeclinedName'];
readonly isStoredFlowEntryOfShippedName: ObjectStackProtocolImplementation['isStoredFlowEntryOfShippedName'];
readonly isUnservedSealedOverlay: ObjectStackProtocolImplementation['isUnservedSealedOverlay'];
readonly isWritablePackage: ObjectStackProtocolImplementation['isWritablePackage'];
readonly lookupArtifactItem: ObjectStackProtocolImplementation['lookupArtifactItem'];
readonly namesWithOwnStoredRow: ObjectStackProtocolImplementation['namesWithOwnStoredRow'];
readonly overlayLockLayerAt: ObjectStackProtocolImplementation['overlayLockLayerAt'];
readonly overrideWriteVerdict: ObjectStackProtocolImplementation['overrideWriteVerdict'];
readonly packagedArtifactOwner: ObjectStackProtocolImplementation['packagedArtifactOwner'];
readonly packagedBaseRefusal: ObjectStackProtocolImplementation['packagedBaseRefusal'];
readonly packagelessAddress: ObjectStackProtocolImplementation['packagelessAddress'];
readonly packagelessReadAddress: ObjectStackProtocolImplementation['packagelessReadAddress'];
readonly readActiveOverlayRows: ObjectStackProtocolImplementation['readActiveOverlayRows'];
readonly readFlattenedMetaItems: ObjectStackProtocolImplementation['readFlattenedMetaItems'];
readonly readItemActiveRows: ObjectStackProtocolImplementation['readItemActiveRows'];
readonly readItemFromMetadataService: ObjectStackProtocolImplementation['readItemFromMetadataService'];
readonly readMetaItemFace: ObjectStackProtocolImplementation['readMetaItemFace'];
readonly readVersionToken: ObjectStackProtocolImplementation['readVersionToken'];
readonly registryMemberServedAt: ObjectStackProtocolImplementation['registryMemberServedAt'];
readonly resolveAppPackageIdKey: ObjectStackProtocolImplementation['resolveAppPackageIdKey'];
readonly resolveCascadeDeleteObjects: ObjectStackProtocolImplementation['resolveCascadeDeleteObjects'];
readonly resolveDisabledActionsReader: ObjectStackProtocolImplementation['resolveDisabledActionsReader'];
readonly resolveFlowRegistrationReader: ObjectStackProtocolImplementation['resolveFlowRegistrationReader'];
readonly resolveRowlessExpandedView: ObjectStackProtocolImplementation['resolveRowlessExpandedView'];
readonly resolveWritePackageScope: ObjectStackProtocolImplementation['resolveWritePackageScope'];
readonly rethrowUnlessMetadataStoreUnprovisioned: ObjectStackProtocolImplementation['rethrowUnlessMetadataStoreUnprovisioned'];
readonly servedLockState: ObjectStackProtocolImplementation['servedLockState'];
readonly shippedArtifactsOf: ObjectStackProtocolImplementation['shippedArtifactsOf'];
readonly shippingPackagesOf: ObjectStackProtocolImplementation['shippingPackagesOf'];
readonly shipsBundleName: ObjectStackProtocolImplementation['shipsBundleName'];
readonly storedFlowBindingAgrees: ObjectStackProtocolImplementation['storedFlowBindingAgrees'];
readonly storedOverlayEntries: ObjectStackProtocolImplementation['storedOverlayEntries'];
readonly strictDraftReadAddress: ObjectStackProtocolImplementation['strictDraftReadAddress'];
readonly throwMetadataServiceUnavailable: ObjectStackProtocolImplementation['throwMetadataServiceUnavailable'];
readonly uninstalledNamedBaseRefusal: ObjectStackProtocolImplementation['uninstalledNamedBaseRefusal'];
}

Expand Down
Loading
Loading