Repository navigation
refactor(collaboration,mobile): delete readerless createPresenceUpdater and requestBackgroundSync - #28402
Merged
objectstack-fleet[bot] merged 1 commit intoOct 31, 2026
Conversation
…er and requestBackgroundSync Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4
Contributor
Author
|
domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4 ACCEPT · 2026-10-31T12:05Z 席位核对
Generated by Claude Code |
objectstack-fleet
Bot
deleted the
claude/issue-25921-readerless-helpers
branch
October 31, 2026 12:21
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4
Requested by Sales · project thread
Part of #25921
Clause-②: no
Metadata-protocol: none
维护者速读
@object-ui/collaboration里的createPresenceUpdater和@object-ui/mobile里的requestBackgroundSync两个函数体,共 50 行。.入口,外部无法导入;回滚即 revert 这一个提交。ui/packages/collaboration/src/usePresence.ts末尾、ui/packages/mobile/src/serviceWorkerSource.ts末尾(都是文件尾部整段删除)。git grep -nw -e createPresenceUpdater -e requestBackgroundSync -- . ':!**/CHANGELOG.md'只应命中.changeset/里 retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 的三个 changeset(本 PR 新增的一个,加上 PR refactor(ui)!: retire zero-consumer exports from@object-ui/collaborationand@object-ui/mobile#28385 的两个),源码零命中。What changes
Deletes the module-local function
createPresenceUpdater(usePresence.ts) andrequestBackgroundSync(serviceWorkerSource.ts). No imports or types became unused; no test exercised either function (none found bygit grep -w). Net 50 deletions plus one patch changeset.Changeset vs
skip-changeset: both packages compile withtscand shipdist(files[]), sodist/usePresence.jsanddist/serviceWorkerSource.jschange bytes; a patch changeset is added and noskip-changesetlabel. It is not a public-surface change: the single.export of each package already dropped both names.Tests
pnpm --filter @object-ui/collaboration run type-checkexit 0;pnpm --dir ui exec vitest run packages/collaboration/7 files / 83 tests pass.pnpm --filter @object-ui/mobile run type-checkexit 0;pnpm --dir ui exec vitest run packages/mobile/6 files / 50 tests pass.@object-ui/collaboration^...,@object-ui/mobile^...).Acceptance notes
git grep -nwover the whole tree (examples, packages/console, skills, content/docs, READMEs) finds each name only at its definition plus CHANGELOG history.pnpm --dir ui exec vitest run scripts/exits 1 on one test (unit-registry-absence-collision) because@objectstack/clienthas no built entry in this worktree (not built; outside the two packages' closure); it readspackages/app-shell/..., not the files touched here. Reported as NOT MEASURED for that family; CI builds it.Verification
Derived gates at bec3be1 (all exit 0 except the one above)
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackrun in full, includingnode scripts/check-sdui-manifest.mjs(0) andpnpm check:published-files(0),check:nul-bytes(0),check:test-source-alias(0),check:undeclared-dep-imports(0).Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4