Repository navigation
fix(studio): an uncommitted nav rename raises the held-edit guard - #27557
Merged
objectstack-fleet[bot] merged 5 commits intoOct 29, 2026
Merged
objectstack-fleet[bot] merged 5 commits into
objectstack-fleet[bot] merged 5 commits into
Conversation
Claude-Session: https://claude.ai/code/session_01L6bhgXU26UBEjd1KKHgNEx Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L6bhgXU26UBEjd1KKHgNEx Co-authored-by: Claude <noreply@anthropic.com>
…terfaces-rename-held-guard
Claude-Session: https://claude.ai/code/session_01L6bhgXU26UBEjd1KKHgNEx Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:ui#1 · os-sales · session_01L6bhgXU26UBEjd1KKHgNEx 席位核对 · ACCEPT · 2026-10-29T12:57ZHead-sha:
|
This was referenced Oct 29, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6bhgXU26UBEjd1KKHgNEx
This was referenced Oct 29, 2026
Contributor
Author
|
domain:ui#1 · os-sales · session_01L6bhgXU26UBEjd1KKHgNEx 席位核对 · ACCEPT 续接 · 2026-10-29T19:45Zhead 从 新 head CI:55 个 check,44 success、11 skipped。 |
objectstack-fleet
Bot
deleted the
claude/issue-27464-interfaces-rename-held-guard
branch
October 29, 2026 20:25
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
维护者速读
StudioDesignSurface.tsx中navRenameClause一段,AppNavCanvas.tsx中pendingRename一段,新测试文件。pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/StudioDesignSurface.navRenameHeld-27464.test.tsx,预期 4 passed。Fixes #27464
Clause-②: no
Metadata-protocol: none
What changes
AppNavCanvasgains an optionalonRenamePendingChange(label | null): a card reports its entry while the rename input differs from the authored label, and takes the report back on commit, on Escape, when the text is typed back, and on unmount. Only a card that reported clears it, so other cards' mounts never erase it.useHeldEditReportcall it already makes (the leaf's held clause wins, then the rename clauseengine.studio.held.navRename, en + zh). The surface's existingunsavedPillarWorktherefore covers it: the onebeforeunloadguard, the shell link guard and Publish's held refusal. ⛔ No second listener, per triage.AppPreviewpasses no report and is unchanged.Tests
StudioDesignSurface.navRenameHeld-27464.test.tsx, through the realStudioDesignSurfaceroute: typing a rename makesbeforeunloadcancel; Escape and typing the authored label back release it; a blur commit hands the rename to the nav autosave (the save carries the new label) and the guard releases once it lands. A fourth case renders a bareAppNavCanvaswith no report (theAppPreviewshape) and renames as before.Ablation: deleting the
onRenamePendingChange={setNavRenamePending}wiring throughscripts/ablation-replace.mjs(anchor 1 to 0, blob b47faa46 to 2dc39a60) turned the three guard cases red (3 failed, 1 passed); restore verified blob equal to HEAD andgit diff HEADempty.Acceptance notes
Verification
Local runs at 301cf9f
metadata-admin/previews/, studio-designnav*/held*/pillarNavGuard/InterfacesPillar*, andpackages/i18n/: Test Files 271 passed, Tests 3248 passed, 13 skipped.@object-ui/i18nand@object-ui/app-shelltype-check: exit 0.dispatch-gates --commands: 34 derived, 34 run, all exit 0;--ran: 0 NOT-MEASURED (derived zero).check:new-line-citations: 0 new.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01L6bhgXU26UBEjd1KKHgNEx