Skip to content

docs(qa): retire the objectui-pin wording left in the checklist ledger - #26962

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-26626-checklist-objectui-wording
Oct 28, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-26626-checklist-objectui-wording

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #26626

Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么:测试清单账本里 14 个条目、18 处还在写 objectui 旧钉(.objectui-sha、"objectui-repo-only"、"objectui pin")的文字,改成仓内 ui/... 路径或删去过时旁注;每条 revision +1、追加一行 history。
  • 为什么改:维护者原话「还在写 objectui 旧路径的文字。立卡」;跑测的人照旧文字会跳过其实能跑的 pin(例如 share-link 条目说"本仓跑不了",实际在 ui/apps/console/src/pages/ 下)。
  • 风险与回滚:纯文档账本,不发布、不改任何条款与状态;回滚即 revert 本 PR。与 qa(checklist): studio-authoring accuracy fixes + 23 items from the Studio QA run #26848 在 studio-authoring.doc-on-app-menu 上会撞 revision/history(两边都升到 r7),后落地者需重排。
  • 先看:docs/qa/platform-checklist/areas/access-security.json(share-link 的 knownGaps[0] 改写最大)、platform-core.json、records-forms.json。
  • 两分钟验证:node scripts/check-platform-checklist.mjs 应打印 OK — 16 areas;用卡上的模式对 areas/*.json 非 history 字段搜索,应为 0 处。
  • 需要你做的:无,席位落地。

What changes

The card's pattern (objectui:build|objectui:refresh|\.objectui-sha|objectui-repo-only|objectui-only|objectui checkout|sibling objectui|objectui pin, case-insensitive), measured over docs/qa/platform-checklist/areas/*.json with history rows excluded:

  • before, at e4ba846f: 20 matches in 18 strings across 14 items
  • after, at beab18b242: 0 matches
  • positive control (acceptance|verify, same files, same exclusion): 1029 matches both times

Items touched (revision from main at edit time, then +1, and ONE new history row citing #26626 on each):

  • access-security.share-link-landing-page r5 to r6: fixtures.knownGaps[0], knownGaps[2], automated.ref. knownGaps[0] no longer says the pins are unrunnable from this checkout.
  • ai.console-ai-surface-gating r7 to r8: acceptance[5].verify
  • approvals.request-page-reply-and-reader-visibility r3 to r4: fixtures.knownGaps[0]
  • attachments-storage.download-authz-both-sides r7 to r8: automated.ref
  • i18n.surface-matrix r10 to r11: fixtures.knownGaps[3]
  • platform-core.keyboard-shortcut-surface r5 to r6: fixtures.knownGaps[1], acceptance[2].verify, acceptance[3].verify
  • records-forms.conditional-rules-grid r9 to r10, import-wizard-encoding-and-hints r8 to r9, gantt-interactions r6 to r7, form-dirty-guard r5 to r6, record-discussion-mentions r11 to r12, field-group-visible-when r8 to r9, v18-semantic-defaults r4 to r5
  • studio-authoring.doc-on-app-menu r6 to r7: fixtures.knownGaps[1]

Kept on purpose: historical objectui issue and PR numbers (objectui#11649, objectui#11674, objectui#3378, objectui PR 11241 / 11258) and measured objectui revisions (1fb1ced36243, daeb77fc84dd, f8267df93aba, 4016370af3c9). The wording around them reads "objectui revision" rather than "objectui pin". No history row was rewritten: a script check confirms that, per item, main's history is an exact prefix of the new one with one row appended. No clause, status or step semantics change.

Out of scope and left on the card: the two governed .claude/skills/** files (checklist-test, dogfood-verification). They are the domain:skills half.

Tests

Every ui/... path the new text names was checked with git ls-files at e4ba846f: ui/apps/console/src/pages/{shared-record-shape.test.ts,SharedRecordPage-11649.test.tsx,SharedRecordPage.tsx,shared-record-shape.ts}, ui/packages/plugin-chatbot/src/__tests__/{usePendingActions.pollFaultPolicy-11736,AiPendingActionsInbox.errorReplacesEmpty-11736}.test.tsx, ui/packages/app-shell/src/chrome/KeyboardShortcutsDialog.wiredOnly-11674.test.tsx, ui/packages/app-shell/src/console/ai/__tests__/matchAiChatShortcut.test.ts, ui/e2e/live/grid-conditional-rules.spec.ts, ui/packages/plugin-detail/src/renderers/__tests__/{recordActivityFeed.test.ts,record-details.groupVisibleWhen-11630.test.tsx}, ui/packages/plugin-gantt/src/GanttView.tree.test.tsx. pnpm console:build exists in the root package.json.

Runnability, where the new text claims a pin runs from this tree:

  • ui/apps/console/src/pages/shared-record-shape.test.ts: run from ui/ (pnpm exec vitest run --maxWorkers=2 FILE, once @objectstack/spec, formula and sdui-parser were built) gave 10/10 passed.
  • SharedRecordPage-11649.test.tsx: NOT MEASURED. Its import chain needs the @objectstack/client dependency closure built, and that build was cut off by a container restart. Existence is verified; runnability is not.
  • The other items already said their pins run under ui/, or now only name the path. No new runnability claim is made for them.

Acceptance notes

Verification

At beab18b242 (the final head, after the merge), each command exited 0, with the exit captured before any pipe:

  • node scripts/check-platform-checklist.mjs: check-platform-checklist: OK — 16 areas, 329 items (324 active, 1 planned)
  • derived (dispatch-gates --commands --repo objectstack-ai/objectstack, 16 commands): check-adr-links (and --self-test), check-closing-keyword-parity (and --self-test), check-comment-mask-corpus, plan-test-core-shards --self-test, lint check:doc-formula-expressions, check:ci-filter-parity, check:cross-package-test-inputs, check:doc-authoring, check:driver-memory-census, check:gitlink-declared, check:nul-bytes, check:platform-checklist, check:refd-timer-probe, check:watch-hint-literal. All 0.
  • dispatch-gates --ran: 16 derived, 16 run, 0 NOT-MEASURED, 0 UNRUN.
  • CI-only families (type-check lanes, Test Core shard planning) are left to this PR's check-runs.

Generated by Claude Code

Fourteen items across eight area files still described their unit and
e2e pins as objectui-repo-only, as objectui pins, or by the retired
.objectui-sha file. The console builds from ui/ in this repository, and
every pin they name lives there. Each string now names its ui/ path, or
drops the retired-pin aside. Historical objectui issue and PR numbers
and measured objectui revisions are kept. Each item gets revision +1 and
one history row. No history row is rewritten, and no clause or status
changes.

Claude-Session: https://claude.ai/code/session_01QSeKYmTYfaPbLQD4BJfomW
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 27, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · domain:devx#2 · head beab18b242 · 2026-10-27T23:25Z

席位意见:内容核对通过;纯账本文字修正,不发布、不改条款语义。CI 收敛(全部 check 绿或预期 skip)后由席位翻 ready 并挂 auto-merge;非受管面,无需维护者批准。

Shape: draft → main. The first line is Part of #26626, with no closing keyword anywhere in the body (grep fixes|closes|resolves → 0). Assignee os-justin, label skip-changeset. 8 files, all docs/qa/platform-checklist/areas/*.json, +104/−35, inside claim 6455663132's surface. ⛔ The .claude/skills/** half is untouched, as claimed.

Premise, re-measured by the seat with a JSON walk over every non-history string in the area files at the merge base b1b153a325 and at the head:

  • card pattern: 20 → 0
  • control (acceptance|verify): 1017 → 1017. The dev's instrument read 1029; that is a different walk, and both are stable across the two refs.

History invariant (seat's own check): 14 items changed. Each has revision +1, main's history as an exact prefix, and exactly one appended row with ref: "#26626". 0 violations.

Spot-check: access-security.share-link-landing-page. knownGaps[0] now says the pin runs from this tree, and the three ui/apps/console/src/pages/ paths it names (shared-record-shape.test.ts, SharedRecordPage-11649.test.tsx, SharedRecordPage.tsx) all exist at head (git cat-file -e). The historical objectui revisions and issue numbers are kept.

Gates: at head beab18b242, read at the time of this record, 41 check-runs: 14 success, 17 skipped, 10 in progress, 0 failure. Lint & Repo Gates and the Type Check jobs are still running, so landing waits for them. The dev's local union, pinned to the same head, is 16 derived, 16 run, all exit 0, and check-platform-checklist is OK.

Accepted deviations:

  • The report comment went through the relay comment op, not post-stamped, because with-fleet cannot mint the fleet identity in this container. The body carries no stamp, so nothing was lost.
  • The runnability probe for SharedRecordPage-11649.test.tsx is NOT MEASURED: its build was killed by the container restart. The PR body says so.

Out of scope:

Landing: non-governed. Ready + auto-merge once every check is green or an expected skip. Partial landing (Part of): on merge, the seat releases the card back to pm:queue for the governed .claude/skills/** half (domain:skills).


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants