Skip to content

test(app-shell): three zh tests await the lazy studio catalogue before reading moved strings #26914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
objectstack-fleet wants to merge 2 commits into from
Closed

test(app-shell): three zh tests await the lazy studio catalogue before reading moved strings #26914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc77e9c
test(app-shell): PackageFormDialog validationTiming awaits the lazy s…
claude Oct 27, 2026
a51a062
test(app-shell): two ResourceEditPage zh cases await the lazy studio …
claude Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/packages/app-shell/src/views/metadata-admin/PackageFormDialog.validationTiming.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ import * as React from 'react';
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { PackageFormDialog } from './PackageFormDialog';
// The form's field labels (`engine.packages.create.*`) live in `@object-ui/i18n`'s
// `studio` namespace, whose `zh` catalogue is fetched on demand. Resident before
// any case, so `getByLabelText(/软件包 ID/)` reads the zh label, never the en
// fallback while the chunk is in flight (objectstack#26863).
import { loadStudioCatalogue } from '@object-ui/i18n/namespaces/studio';
await loadStudioCatalogue('zh');

let localeFixture: 'en-US' | 'zh-CN' = 'zh-CN';
vi.mock('./i18n', async (importOriginal) => ({
Expand Down
6 changes: 6 additions & 0 deletions ...ages/app-shell/src/views/metadata-admin/ResourceEditPage.discardDraftLabel-12690.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ import { MetadataResourceEditPage } from './ResourceEditPage';
import { registerDefaultMetadataSchemas } from './default-schemas';
import { registerBuiltinPreviews } from './previews';
import { tFormat } from './i18n';
// The `engine.edit.*` rows this suite reads in zh (the `丢弃草稿` button, the
// confirm and the toast) live in `@object-ui/i18n`'s `studio` namespace, whose
// `zh` catalogue is fetched on demand. Resident before any case, so the zh rows
// are read after the catalogue lands, never racing it (objectstack#26863).
import { loadStudioCatalogue } from '@object-ui/i18n/namespaces/studio';
await loadStudioCatalogue('zh');

const DOC_JSON_SCHEMA = z.toJSONSchema(DocSchema as unknown as z.ZodType) as Record<string, unknown>;
client.current = new MetadataClient({ baseUrl: '', fetch: vi.fn(serve) as unknown as typeof fetch });
Expand Down
6 changes: 6 additions & 0 deletions ...ges/app-shell/src/views/metadata-admin/ResourceEditPage.environmentOverlay-12141.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ vi.mock('./i18n', async (importOriginal) => ({
}));

import { MetadataResourceEditPage } from './ResourceEditPage';
// The read-only banner (`engine.edit.readOnlyTypeBanner`) lives in
// `@object-ui/i18n`'s `studio` namespace, whose `zh` catalogue is fetched on
// demand. Resident before any case, so the zh banner is read after the
// catalogue lands, never racing it (objectstack#26863).
import { loadStudioCatalogue } from '@object-ui/i18n/namespaces/studio';
await loadStudioCatalogue('zh');

/** An item a code package ships, as the layered read serves it. */
function packagedItem() {
Expand Down
Loading