Repository navigation
docs(organizations): drop the retired orphan claim from the SYSTEM_CTX writer lists - #25283
Conversation
…X writer lists Middleware A's comment and the matching test comment listed the orphan claim among the legitimate system-context writers that name another organization. That writer is retired; the lists now name only the writers that still exist. Comments only, no behaviour change. Claude-Session: https://claude.ai/code/session_01FaVyM6YvQLg9CsjPVCYc5K Co-authored-by: Claude <noreply@anthropic.com>
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 9 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contract reviewServed-tier: The seat's review of record. Inputs: card #25203 (items 9 and 10, epic seat note 6345275520), claim 6349496270, dev report 6350511634, the net diff against ① Derived judgments
② Semver levelNone: comment-only in a non-published spot; ③ Boundary flags
Implemented-by: VERDICT: PASS |
席位核对ACCEPT ·
|
Requested by Bill · project thread
Fixes #25203
Part of #15212
Clause-②: no
Metadata-protocol: none
What this changes
Items 9 and 10 of the card: two comments in
@objectstack/organizationsthat still named the retired orphan claim (claimOrphanOrgRows) among the legitimate SYSTEM_CTX writers that name another organization. That writer no longer exists, so both lists now name only the writers that do.packages/plugins/organizations/src/organizations-plugin.ts(Middleware A, theisSystemshort-circuit note): "the per-org seed replay, the orphan claim, imports, migrations" becomes "the per-org seed replay, imports, migrations".packages/plugins/organizations/src/organizations-plugin.test.ts(the comment above the system-context cross-org test): "per-org seed replay / orphan-claim, migrations" becomes "per-org seed replay, migrations".Comments only: no code, no assertion and no test name moves.
Why this closes the card
This is the card's last slice. Items 1, 2, 3, 6, 7 and 8 landed through #25266, and item 4 landed with #25210. Item 5 is a governed
.claude/**line and has its own carrier, #25276, which remains open and is not addressed here.What stays
git grep -n -i orphan -- packages/plugins/organizations/srcafter the edit, every remaining hit and why it stays:organizations-plugin.ts:151and:434-435: they describe the retirement itself ("NO ORPHAN CLAIM", "There used to be a Fallback A"), which is true. Left alone on purpose.first-organization-orphan-rows.pin.test.ts:7: the suite docblock saysclaimOrphanOrgRows"used to run here" and that the claim is retired. True.first-organization-orphan-rows.pin.test.ts:152-207: fixture row ids and names (acc_orphan,task_orphan_1, "Orphan account") for organization-less rows. They name the data shape, not the retired writer.org-scoping-engine.ts:16: namesOrphanCleanupEngineinplugin-sharing, an unrelated live engine.Verification
pnpm --filter @objectstack/organizations test: Test Files 16 passed (16), Tests 239 passed (239), lock VERDICT command-exit 0, at641031d3d.pnpm --filter @objectstack/organizations typecheck: lock VERDICT command-exit 0, at641031d3d.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack, 56 commands) was run at641031d3d; exit codes are in the dispatch report on the card.Changeset
None. The diff moves only source comments, which publish nothing, so this PR carries
skip-changeset.Generated by Claude Code