Repository navigation
fix(spec): step 18's rationale gains the form-view-subform-columns-closed fragment - #21090
Conversation
…osed fragment One STEP18_RATIONALE fragment for the inline grid column family: the form view's subforms[].columns closure, its D2 conversion form-view-subform-columns-canonicalized, and the identity-only currency scale refusal. Inserted where its id sorts, order one above the highest (53 at the base). Plus a patch changeset for @objectstack/spec. Claude-Session: https://claude.ai/code/session_01Sfe5YjBLwB9J3y8fvm2xq1 Co-authored-by: Claude <noreply@anthropic.com>
📓 Docs Drift Check1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run. What this run could not see
Coarse fallback — 137 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b221c59fe88b5bbbf9c4424d1946a624a7cf036d && git checkout b221c59fe88b5bbbf9c4424d1946a624a7cf036d
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 94608a7d72ecef7bf61d10dbab3bd80aea311055 8ebaf237c4f1c26060891f62dfa990547b82aa7a && git checkout -B drift-repro 94608a7d72ecef7bf61d10dbab3bd80aea311055 && git merge --no-ff 8ebaf237c4f1c26060891f62dfa990547b82aa7a
node scripts/docs-audit/affected-docs.mjs --json 94608a7d72ecef7bf61d10dbab3bd80aea311055 |
Contract reviewServed-tier: ① Derived judgmentsInputs read: card #20901 (body; every comment — triage Accept-set and public-surface changes the diff implies
The fragment, sentence by sentence. Author-shown:
Nothing over-broad was found; the one unsourced clause is the objectui hydration reading in S6, sourced to the entry and the pin citation. Does the fragment say anything the rulings it cites did not rule? No. It attributes exactly two things to maintainer rulings — the currency The changeset The PR body, sentence by sentence. "Part of #20901" and "Clause-②: no" — right (② below; the Part-of guard is green and the card is open). " ② Semver levelClause-②: no
③ Boundary flagsDev report
Check-runs on Implemented-by: VERDICT: PASS Adopted and posted by
Generated by Claude Code |
Part of #20901
Clause-②: no
One
STEP18_RATIONALEfragment inpackages/spec/src/migrations/registry.ts: idform-view-subform-columns-closed,order54 (the highest at base5dbeb7d7b7was 53), inserted where its id sorts. It covers the form-view carrier closure, the D2 conversionform-view-subform-columns-canonicalized, and the identity-only siblinginline-grid-column-identity-only-currency-scale-refused. Each sentence restates the two entry sources and the conversion source. The list sits outside the generated markers and is hand-written;gen:migration-registryis a no-op on this diff. Apatchchangeset for@objectstack/specis included because the rationale string ships indist/migrations. This is review item 4 of the at-tier record5921114874on #20953. The card stays open, and the seat closes it by hand.Verification at head
8ebaf237c4(merges origin/maindff98c1f51)step18-rationale-merge,compliance-families-retirement,conversions-major18-merge): 31 passed.migrations.test.tsandinline-grid-column-carriers.test.ts: 179 passed. Spec local suite: 588 files, 17318 passed. Spec typecheck: exit 0.check:generated: all 15 artifacts are up to date after a spec build. The upgrade guide prints majors up toPROTOCOL_MAJOR(17), so it does not print step 18 and has no diff here.dispatch-gates --ran: 82 derived, 82 run, 0 NOT-MEASURED.Acceptance notes
06f079864a. Fragments are per retirement family, so the number of families without one is not counted.carrier:none named. Noted here under the filing gate, with noreach:measured today. The generated guide prints major 17 only (build-upgrade-guide.tsloops toPROTOCOL_MAJOR, 17 at this head). Step 18's rationale does reachos migrate meta --step, whose default chain ends at major 18 (packages/cli/src/commands/migrate/meta.ts). There, a family without a fragment is left out of the paragraph, not misstated. This was read from the source and not measured at that door.Generated by Claude Code