Skip to content

ci(duplicate-fix-guard): delimit the branch-name match so a longer card number cannot prefix-match #18999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Sep 19, 2026
+9 −3
Merged

ci(duplicate-fix-guard): delimit the branch-name match so a longer card number cannot prefix-match #18999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/duplicate-fix-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,17 @@ jobs:

// Branch-name convention (advisory, never red): a fix branch named
// `claude/issue-<n>-<slug>` is discoverable by the next session
// with one `git ls-remote | grep issue-<n>`. #4555 vs #4559
// happened partly because the branches shared no token to grep.
// with one `git ls-remote --heads origin | grep -E 'issue-<n>(-|$)'`.
// #4555 vs #4559 happened partly because the branches shared no
// token to grep. Both spellings delimit the number on the RIGHT:
// undelimited, `issue-186` matches `claude/issue-18611-x`, so the
// advisory stays silent for a branch naming a DIFFERENT card —
// the false negative. The `$` arm keeps the slug-less spelling
// `claude/issue-186` matching; `issue-` anchors the left, so
// `issue-1186` and `issue-0186` do not match card 186 either.
// Warning only — existing branches must not go red retroactively.
const branch = pr.head.ref;
if (![...mine].some((n) => branch.includes(`issue-${n}`))) {
if (![...mine].some((n) => new RegExp(`issue-${n}(-|$)`).test(branch))) {
core.warning(
`Branch \`${branch}\` does not name any declared issue. ` +
`Convention: claude/issue-<n>-<slug> (e.g. claude/issue-${[...mine][0]}-short-slug) ` +
Expand Down
Loading