Skip to content

docs(automation): say when the fallbackApprovers pairing is actually enforced #18868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-try-charles merged 1 commit into from
Sep 18, 2026
Merged

docs(automation): say when the fallbackApprovers pairing is actually enforced #18868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions content/docs/automation/approvals.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,12 @@ one that turns an empty slate into a request someone can actually decide:
`fallbackApprovers` takes the same entries as `approvers` — same types, same
`group` / `resolveAs` / `organization` keys — and is resolved by the same
expansion, OOO delegation included. The pairing is enforced in both directions:
`fallback` without a `fallbackApprovers` list is refused at authoring time, and
a `fallbackApprovers` list under any other policy is refused too, because
nothing would ever read it.
`fallback` without a `fallbackApprovers` list is refused, and a
`fallbackApprovers` list under any other policy is refused too, because nothing
would ever read it. Both arms fire at **flow execution**, where the approval
node parses its config on entry — **not** at authoring time, and `os lint` has
no pairing arm for this one. The refusal is loud, names both keys, and lands
before the node opens any approval request.

Prefer a fallback target that cannot itself resolve empty (a literal `user`, or
the `owner` membership tier). If it does resolve empty the node degrades to
Expand Down
Loading