fix(pm): the issue-body footer cell is measured — give each footer shape its own clean class - #18786
Merged
os-justin merged 1 commit intoSep 17, 2026
Conversation
…ape its own clean class The header declared the issue-body footer cell UNMEASURED and held the body-mode append in `mutated` on that ground, while the governed fact table has carried the measurement since PR #17746 and the skills seat re-measures it on every seat-post refresh. Since PR #18758 `$?` already answered 0 for both footer shapes, so the tool said two things about one set of bytes: "everything sent is on the platform" in `$?` and "MUTATED" on stderr, with `--json` reporting `body_mutated: true` beside `body_landed: true`. `footerReAnchoring`'s two measured shapes are now two declared classes — `footer-appended` and the new `footer-re-anchored` — for either act, so `classifyReadBack` takes no `mode`: the comparison is exact bytes, which cannot tell one act's write from another's, and the gate existed only for the cell that is now measured. `sentBodyLanded` reads the class alone. Every exit-4 control is unchanged: a byte lost before the rule, a byte changed at equal length, a chewed footer, a rewritten link, a newline from nowhere, a truncation ending in the block. What is unmeasured is named instead: the WRITE CHANNEL. Two `--body` refreshes of the same shape on the same endpoint the same day read +58 on this seat's channel and IDENTICAL on the triage seat's, and no act here can vary that. Claude-Session: https://claude.ai/code/session_01Gqi43smmqjJ5sUrhfoPeKu Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Sep 17, 2026
os-justin
marked this pull request as ready for review
September 17, 2026 20:58
This was referenced Sep 17, 2026
os-justin
deleted the
claude/issue-18693-issue-body-footer-cell-measured
branch
September 17, 2026 21:22
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18693
Clause-②: noWhat was left after PR #18758
PR #18758 (#18709) made
$?answer 0 for both footer shapes and took the prescription out of the status line. What it explicitly did not touch is the CLASS: the body-mode footer append and the trailing-rule re-anchor stayedmutated,--jsonkept reportingbody_mutated: true, and the header kept declaring the issue-body footer cell UNMEASURED with two pinned controls holding it there. So the tool said two things about one set of bytes on nearly every write a seat made — "everything sent is on the platform" in$?, "MUTATED" on stderr — and a warning that fires on nearly every write is one nobody reads, which is what the read-back exists to be read.This PR moves the cell, on a measurement.
① The controlled contrast — the triage seat's first ask (5716957331)
Two
--bodysends to one artefact this act owns (the body of this PR, written throughPATCH /repos/OWNER/NAME/issues/NUMBER, which is the endpoint--bodyuses for a card and for a PR alike), differing ONLY in whether the sent tail ends in the 58-byte footer block, each read back byte-exact by the tool itself:main2085be2b2d$?mutatedfooter-appendedappendedmutatedfooter-re-anchoredre-anchoredBoth arms are the same body; arm B is arm A plus 59 bytes at the tail (the 58-byte block and one newline) and nothing else —
armB.startsWith(armA)holds. Each was sent bynode scripts/pm/post-stamped.mjs --body=18786 --repo=objectstack-ai/objectstack --file=… --json, exit captured with redirect-then-$?, and the stored bytes were then fetched again independently and compared here:stored === sent + PLATFORM_COMMENT_FOOTER— exactly true. The platform synthesised the block on a footer-less body, once, 58 bytes, on this channel.stored === head + "\n" + PLATFORM_COMMENT_FOOTER— exactly true, and the stored body carries exactly ONE attribution block, not two. The newline this act sent after the block moved to before its rule: equal length, one byte moved, zero lost.What the status line says on the same bytes,
mainagainst this branch:One more reading, taken for free on the way in and reported rather than acted on: the create of this PR (
POST /pulls, body ending in the session-URL footer block plus a newline) stored 10840 against 10841 sent — the trailing newline stripped, nothing appended, exactly one attribution block. That is thetrailing-newline-strippedcell, and it is a PR-body CREATE reading, which is #18622's surface, not this card's.The variable that is NOT the sent tail, and the one that is left
The triage seat proposed "the sent tail ending in the block" as the trigger, from two
--body=6015sends that read IDENTICAL against this card's three--body=7623sends at +58. That candidate is falsified in both directions, and neither reading needed re-taking:--body=7623refreshes on 2026-09-17 (cited as the seat's, in the claim 5720594990): 47699 to 47757, 49671 to 49729, 52030 to 52088. Their sent tails carried NO block, and the read-back is +58 each.Same endpoint, same shape of sent body (no block in the tail), opposite outcomes. So the live variable is the WRITE CHANNEL, or the identity behind it.
This act cannot vary it, and says so rather than guessing. Both GitHub credentials in this container (
GITHUB_TOKEN,GH_TOKEN) are byte-identical proxy-issued placeholders that resolve to one identity,os-justin; the MCP GitHub write tools are refused to an os-dev by contract. There is one channel here and no second one to compare against. Naming it is the deliverable; measuring it needs a seat that holds the other channel.And the tool does not need to know which channel it is on, which is what lets the cell move. The read-back compares exact bytes: a footer-less body that comes back unchanged is
identical, and one that comes back with exactly the declared block appended isfooter-appended. Those two cells are not confusable — the objection "a cell the tool cannot tell apart must not be forgiven" simply does not apply to this cell. Whichever way the channel goes, the verdict is right.② The class decision
The body-mode append and the re-anchor leave
mutated, and each measured shape gets its OWN declared word:footer-appended— the stored body is the sent one, or its newline-trimmed form, plus exactlyPLATFORM_COMMENT_FOOTER. Both acts now. The measurement it rests on:platform-readings.md:410 「建卡走 RESTPOST /issues:带页脚存活,无页脚合成恰一条(+58);回读后PATCH重送逐字节存下。」 and :411 「issue 正文PATCH识别按整块:送全块或不送页脚都存回恰一条,已有页脚归一末尾不复制。」 — :411 is the act--bodyperforms — plus the live readings above.footer-re-anchored— NEW, becausefooter-appendedsays "plus exactly the footer" and a moved newline added nothing; borrowing that word would make the vocabulary say something untrue about the bytes, which the file refused for good reason. Its measurement is :356/:357 「平台在尾部---前后正反两向归一空行」 / 「送全块即触发该归一 ⇒post-stamped的body档把这点空白判mutated,净零字节良性告警。」 and the four live artefacts PR fix(pm): teach footerReAnchoring the second re-anchor shape — a moved newline is not a lost byte #18758 pinned.mutatednow means one thing — nobody measured this — andsentBodyLandedreads the CLASS alone.body_mutatedis false exactly wherebody_landedis true: one set of bytes, one answer, in$?, on stderr and in--json.classifyReadBacktherefore takes nomode. The act-shaped gate existed for exactly one reason — the issue-body cell was unmeasured — and an exact-bytes comparison cannot tell one act's write from another's anyway. Leaving the parameter behind would leave a knob a caller can set that decides nothing, which is the shape this repo files cards about; a pin asserts the signature carries nomodeat all. The word for the surface survives where it is actually read:notStoredTextstill prints "comment" or "body", and the CLI handsoptions.modeto that.Why this branch and not "rewrite the header to say what IS unmeasured": both were done. The cell moved because it is measured and distinguishable; the header now names the write channel as the thing nobody has measured, with the readings on each side, instead of naming the cell.
The card's sentence, split between two PRs
The card reads 「every seat-post refresh prints a MUTATED warning」.
$?stopped answering 4.read-back: clean — the platform appended its footer (sent N, stored N+58)and--jsonanswersbody_mutated: false. The interim reading the card carries — that the cell is unmeasured — is retired in the header, with the measurement and the channel caveat written in its place.The pins, re-pointed
The two the card names, at their post-#18758 line numbers:
footer-appended, no longer MUTATED, still exit 0, still measured as EXACTLY the declared footer and never as a 58-byte delta, and its line now names the append and carries both byte counts.footer-re-anchoredand neverfooter-appended; the recorded first-difference offsets are still pinned, read fromfirstDifferingByte— the clean class prints no offset line, the same as every other benign class, so the verdict is two lines andreadBack.offsetis null.sentBodyLandedis pinned on the class alone: amutatedverdict carryingfooterReAnchored: truedoes NOT land. The field stays on the result as a measurement--jsonreports; it is no longer a second door to exit 0.The exit-4 controls: every one re-run, every one still red
PR #18758's battery is unchanged and green: a byte lost before the rule; a byte changed at equal length (with the explicit assertion that both sides ARE equal length); a loss inside the footer block; a footer whose link was rewritten; a sanitizer chew under a moved newline; a newline that came from nowhere; a newline inserted somewhere other than immediately before the block; a truncation that happens to end in the block. All eight still exit 4, and
unreadablestill exits 0 as UNVERIFIED.The ablation
Deleting the one branch that turns a measured footer shape into a class, from the committed fix at
cb21adf430:30 of 349 red, and they are the right 30: the moved cell, the new class, the lines that name them, and the four live re-anchor artefacts' "it LANDED" and "measured as the re-anchor by name". Every exit-4 control stays green with the branch deleted — which is what a control is for; one that went red here would have been testing the branch, not the contract. 0 floor problems, so no battery went quiet. Restore is proven by blob-hash equality against
HEADand by an emptygit diff HEAD, never by an exit code, under atrap … EXIT INT TERMwith absolute paths, and an empty hash is treated as failure.Self-test
347 cases across 13 batteries becomes 349 across 13. No battery floor moved;
SELF_TEST_BATTERY_FLOORand every per-battery count are untouched.Derived gates
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackfrom the worktree, no hand-fed path list; change set 1 path,scripts/pm/post-stamped.mjs. Each exit code captured with redirect-then-$?:All 29 exit 0.
pnpm check:pm-dispatch-gateswas run DETACHED with its output to a file (745.9s on this box), never under a foreground timeout. Reconciled with--ran: 29 derived, 29 run, 0 NOT-MEASURED, 0 UNRUN — a DERIVED zero, since all 29 records carry an exit code. The gate list was re-derived after a freshgit fetch origin main(2085be2b2d) and is byte-identical to the first derivation. Repo-widepnpm lint(eslint . --no-inline-config): exit 0, no findings, atcb21adf430.Read, not folded in
--bodyact reaches a PR through the ISSUE endpoint, so the arms above are the issue-body cell's endpoint exercised on a PR object; an issue object on the same channel is the seat's [PM seat] domain:skills — 🟢 os-tesla · session_01W5y9kRg1YtYaMQYExVLRc2 · R1 in seat · landed 5 (#18698 · #18862 fold · #18989 · #19091 · #19036) · in flight 0 · awaiting human merge 2 (objectui#9994 · objectui#9997) · queue 26 (p1 0 dispatchable, p2/p3 held by 北极星第 3 条) · decision box 1 · body r5e #7623 reading, the same direction.This body was written four times, on purpose
The create, the two contrast arms, and this one. ① could not be measured without two sends to an artefact this act owns, and writing another seat's post to measure it is refused; the dispatch named this PR's body as the target. The two arms are the timeline events between the create and this write. This is the last write this act makes to this body.
Generated by Claude Code