Skip to content

docs(core,rest): one adjective for what cloud mounts — licence-gated, not cloud-private - #18759

Merged
huangyiirene merged 1 commit into
mainfrom
claude/issue-18542-organizations-adjective-ruling
Sep 17, 2026
Merged

huangyiirene merged 1 commit into
mainfrom
claude/issue-18542-organizations-adjective-ruling

Conversation

@huangyiirene

Copy link
Copy Markdown
Collaborator

Fixes #18542

Clause-②: no

#17379's census (comment 5704455410) left one five-sentence family that is neither "now
false" nor "still true". Five measurement narratives in packages/core/src/security and
packages/rest/src call the thing cloud's own app mounted "the real cloud-private
@objectstack/organizations" (or "Organizations plugin"). Under ADR-0132 D3 — one name,
two packages — that adjective never says which of the two it means: it is true of the
licence-gated subclass a commercial deployment resolves the name to, and false of the
package name, which in this workspace resolves to an Apache-2.0 member of it.

Triage kept the five on one card so the adjective is chosen once. This is that choice.

The adjective: licence-gated

It is the tree's own established spelling for cloud's variant, and it is the property that
DISCRIMINATES: the open-core build in this repository is not gated, the subclass cloud
resolves the same name to is. Measured on this head: 16 live occurrences of licence-gated
and zero of license-gated — packages/plugins/plugin-security/README.md,
packages/plugins/plugin-auth/src/tenancy-service.ts,
packages/services/service-cluster/src/multi-node-gate-mount.ts,
packages/spec/src/kernel/platform-capabilities.ts (a runtime string),
packages/cli/src/commands/serve.ts and four CHANGELOGs, all reading "a private,
licence-gated subclass".

Where the old adjective sat on the bare package NAME (the three packages/rest sites), the
referent noun subclass is added with it, so the gate attaches to the variant and never to
the Apache-2.0 package — otherwise the repair would trade one false reading ("this package
is private") for another ("this package needs a licence"). The two packages/core sites
already had a noun denoting the mounted instance ("Organizations plugin"), so they take
the adjective alone.

Why the alternatives lose

The five sites

Taken from #17379's census, comment 5704455410 — not from the card body, and no fresh sweep
was run. Line numbers are readings at this head, not identifiers.

# file the adjective as it stood
1 packages/core/src/security/resolve-authz-context.ts:483 "the real cloud-private Organizations plugin"
2 packages/core/src/security/resolve-authz-context.test.ts:1604 same sentence, the test twin
3 packages/rest/src/rest-api-plugin.ts:300 "the real, cloud-private @objectstack/organizations"
4 packages/rest/src/single-kernel-isolated-api-key-matrix.test.ts:21 "the REAL cloud-private @objectstack/organizations"
5 packages/rest/src/single-kernel-isolated-session-org-claim-matrix.test.ts:11 same shape

File surface as declared in the claim: packages/core/src/security/ and packages/rest/src/.
The diff is those 5 files, both halves of the cross-domain surface, nothing outside it. No
other session's edit was found in either file.

Prose, not pins

The three machine assertions the card names are NOT in this diff.
serve-capability-vocabulary.test.ts:92 and doctor-organizations-message-spelling.test.ts:197
(edition === 'enterprise') and harness.host-resolution.test.ts:288,319 (operator strings in
a regex) are class-3 enterprise sites in packages/cli and packages/verify; this card is
the class-1-ambiguous cloud-private family in packages/core + packages/rest.

doctor-organizations-message-spelling.test.ts:188-194 was read before deciding, as the card
requires. It argues that the roster row edition: 'enterprise' records the ENTITLED variant
and is "deliberately not relaxed to match the prose reword". Nothing here disturbs it, and its
reasoning is the one this diff applies — one name, two packages, and the roster names the
entitled variant. No argument to move it is made.

All five edited sites are comment prose. Nothing asserts their text: the three tests that read
these two source files as TEXT (authz-store-unavailable.test.ts,
execctx-authz-input-seam-reachability.test.ts, objectql-slot-consumer-census.test.ts)
assert code shapes only — imports, catch patterns, and field reads whose scanner excludes
comment lines by construction.

Evidence

  • pnpm --filter '@objectstack/rest...' --filter '@objectstack/core...' build — exit 0 (both dependency closures).
  • pnpm --filter @objectstack/core test — 51 files / 1316 tests passed.
  • pnpm --filter @objectstack/rest test — 194 files / 3236 passed, 1 skipped.
  • pnpm --filter @objectstack/core typecheck && pnpm --filter @objectstack/rest typecheck — exit 0, each including its test layer.
  • pnpm lint (repo-wide eslint . --no-inline-config) — exit 0 in 86s, so no narrowing was needed and none is declared.
  • Gate families derived by scripts/pm/dispatch-gates.mjs --commands at this head: 53 derived, 51 run green, 2 NOT MEASURED — check:dual-build-cjs-loads and check:type-check-debt both exit 3, PREREQUISITE NOT MET: they read a whole-repo dist/ this worktree does not have, and CI builds before running them. Reconciled with --ran: "53 derived famil(ies) accounted for — 51 run, 2 NOT-MEASURED".

skip-changeset, measured rather than assumed

Both packages publish, so the label was measured. After the build,
grep -rn "licence-gated" packages/core/dist packages/rest/dist returns zero hits (exit 1,
captured before any pipe). Positive control on the same channel: comment prose DOES reach
published output — cloud#1982 appears at packages/rest/dist/index.d.ts:421, out of a JSDoc
on an exported declaration in rest-server.ts — and the exported symbols (resolveAuthzContext,
RestApiPlugin) hit in dist as expected. The channel exists, the control fires on it, and
none of the five edited comments is on it: nothing published moves. Clause-②: no holds for
the same reason — no accept set, no authorable key and no export moves.

Acceptance notes


Generated by Claude Code

…loud-private"

Five measurement narratives in packages/core/src/security and
packages/rest/src said the reproduction ran with "the real cloud-private
`@objectstack/organizations`" (or "`Organizations` plugin"). Under
ADR-0132 D3 "one name, two packages" that adjective is ambiguous, not
simply false: it is true of the licence-gated subclass cloud's own app
mounts, and false of the package name, which resolves in this workspace
to an Apache-2.0 member of it.

All five take the same adjective, chosen once: `licence-gated`, the
tree's established spelling for cloud's variant (plugin-security
README.md, plugin-auth/src/tenancy-service.ts,
service-cluster/src/multi-node-gate-mount.ts,
spec/src/kernel/platform-capabilities.ts, and the CHANGELOGs of four
packages all read "a private, licence-gated subclass"). Where the
adjective sat on the bare package NAME the referent noun `subclass` is
added with it, so the gate attaches to the variant and never to the
Apache-2.0 package.

Comment prose only: no runtime string, no export, no test assertion and
no behaviour moves.

Claude-Session: https://claude.ai/code/session_01CqmCgU5RGDoJYhHUMVp2af
Co-authored-by: Claude <noreply@anthropic.com>
@huangyiirene huangyiirene added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 17, 2026 — with Claude
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/core, @objectstack/rest, touching 2 documentable anchor(s).

4 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/kernel/runtime-services/sharing-service.mdx (via resolveAuthzContext (symbol, a top-level function))
  • content/docs/permissions/authentication.mdx (via createRestApiPlugin (symbol, a top-level function))
  • content/docs/permissions/authorization.mdx (via resolveAuthzContext (symbol, a top-level function))
  • content/docs/plugins/packages.mdx (via createRestApiPlugin (symbol, a top-level function))

⛔ 3 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v14.mdx (via resolveAuthzContext (symbol, a top-level function))
  • content/docs/releases/v17/17-1.mdx (via resolveAuthzContext (symbol, a top-level function))
  • content/docs/releases/v17/17-3.mdx (via resolveAuthzContext (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • the SDK route bridge reached 60 of 215 client-bound route-ledger rows — the other 155 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 155: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 100 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 32 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 09e16a5745b66ca4e5cdddb6248551d1761f0ddd → packageMentionDocs.

Which tree this was computed on

This run read content/docs from d9deeb6769693f03b06c26124b54dea6cccaa47d — the merge of head 88df1306ac90e9944e3bb1466b0ca866e6224b55 into base 09e16a5745b66ca4e5cdddb6248551d1761f0ddd, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d9deeb6769693f03b06c26124b54dea6cccaa47d && git checkout d9deeb6769693f03b06c26124b54dea6cccaa47d
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 09e16a5745b66ca4e5cdddb6248551d1761f0ddd 88df1306ac90e9944e3bb1466b0ca866e6224b55 && git checkout -B drift-repro 09e16a5745b66ca4e5cdddb6248551d1761f0ddd && git merge --no-ff 88df1306ac90e9944e3bb1466b0ca866e6224b55

node scripts/docs-audit/affected-docs.mjs --json 09e16a5745b66ca4e5cdddb6248551d1761f0ddd

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 09e16a5745b66ca4e5cdddb6248551d1761f0ddd → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actions github-actions Bot added the tests label Sep 17, 2026
@huangyiirene
huangyiirene marked this pull request as ready for review September 17, 2026 19:33
@huangyiirene
huangyiirene added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit 04acdcc Sep 17, 2026
40 checks passed
@huangyiirene
huangyiirene deleted the claude/issue-18542-organizations-adjective-ruling branch September 17, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants