Skip to content

fix(check-adr-0087): walk a dotted member path through a class body #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 4 commits into from
Sep 13, 2026
Merged

fix(check-adr-0087): walk a dotted member path through a class body #17776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
024cc7d
fix(check-adr-0087): walk a dotted member path through a class body
claude Sep 12, 2026
0e5f907
docs(adr-0087): record that a dotted segment names an object literal …
claude Sep 12, 2026
e293388
Merge remote-tracking branch 'origin/main' into claude/issue-17279-ty…
claude Sep 12, 2026
bcff249
fix(check-adr-0087): spell the engine anchors repo-relative in the ne…
claude Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions docs/adr/0087-metadata-protocol-upgrade-contract.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,9 +758,16 @@ checks all four by name (`published`, `no-spec-diff`, `no-metadata-surface-diff`
was closed to them by the grammar rather than by any judgement about the claim,
and the gate answered a true sentence about a member the diff never touched
(#15627). A reference may therefore also be written `<path>#<a>.<b>.<member>`:
the object-literal nesting the member sits in, walked **structurally** from the
top of the file over a comment- and literal-masked projection, with the member's
definition taken from inside the resolved body. Bare references keep their exact
the nesting the member sits in, walked **structurally** from the top of the file
over a comment- and literal-masked projection, with the member's definition taken
from inside the resolved body. A leading segment names an **object literal or a
class** — both are containers a published member actually sits in, and reading
only the first left a narrowing on a class method in the state #15627 was filed
about: measured on `packages/objectql/src/engine.ts`, the dotted spelling was
refused outright while the bare `#delete` answered a true sentence about
`ObjectQL.delete`, a member the diff never touched (#17279). A **class
expression** (`const X = class { … }`) is deliberately not walked — that name
belongs to the binding, not to the class. Bare references keep their exact
previous meaning. ⛔ A line number is never the disambiguator — this file's line
numbers were measured to rot within one day. A dotted path that resolves to
**zero** candidates, or to **more than one**, is reported by name and refused,
Expand Down
Loading
Loading