Repository navigation
[maintainer] refactor(app-shell): split StudioDesignSurface.tsx (12,882 lines) along its component seams, one move-only slice per PR #29988
Description
domain:devx#1 · os-support-ai · session_01WGufzgBDcBNVmSmo7VFHpj
Filing gate: ruling 6583399215 on #29465 (letter A, maintainer 「同意」 2026-11-02T17:11Z), whose after-ruling stroke names a hand-slice card for this file under #24586's ruling, because a React component's closures are not mechanically separable. The file crossed 10,000 lines after #24586 was ruled and never got its card. The maintainer asked for this programme first while the fleet is quiet: 「现在车队不忙，大文件分拆的问题是否可以优先」 (2026-11-03T22:37Z). ⛔ Not a claim. No grade: triage sets it and routes it.
Ruling-ref: 6583399215
Governs: #24586 ruling A (6270097840: one [maintainer] card per file over 10,000 lines, move-only slices, serial with in-flight PRs); the declaration-file bar of ruling 6348891160; ruling 6597555122 item 3 (a test or gate that reads the file by path gains the new module in its reading list in the same PR).
Reader who acts: a domain:ui seat, one slice per dispatch.
What to do
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis 12,882 lines onmainc92b8872and one of the busiest files inui/([Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465 measured 60 commits in 7 days on 2026-11-02).- Each slice moves one seam (a sub-component, a hook, or a group of pure helpers) into its own module beside the file, move-only: no logic, prop or behaviour change; the moved text is byte-identical apart from imports and
export. - Each slice is serial with the file's in-flight PRs: read the open PRs touching the file before claiming, and take a seam none of them edits.
- The first slice proposes a seam table (seam, lines, inbound reads, risk), the way [maintainer] refactor(metadata-protocol): split
src/protocol.ts(33,065 lines, +10,169 in 30 days) along itsObjectStackProtocolImplementationseams, one move-only slice per PR #25467 cut 1 did; later slices take the next row.
Done when
StudioDesignSurface.tsx is below 10,000 lines, or a slice report shows the remaining seams cannot move without a logic change (then a decision goes to #29465).
Re-measure: git show origin/main:ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx | wc -l.
Dedupe (open and closed): StudioDesignSurface, split in:title, 拆分, 29465. Hits: #29465 (names this card as owed), #24586; the StudioDesignSurface hits are feature fixes, none a split card. New.
Activity
objectstack-fleet commentedon Nov 3, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p2 ·
domain:ui·pm:queue· 2026-11-03T23:55Z⛔ Not a claim.
[maintainer]hand-slice card forStudioDesignSurface.tsx(12,882 lines), under [Decision] Split the platform's largest, fastest-growing source files (protocol.ts 32,428 lines, +10,002 in 30 days) the way rest-server.ts was split, or leave them #24586 ruling A and [Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465's after-ruling stroke. A React component's closures are not mechanically separable, so this file is cut by hand rather than by the codemod. A ruled refactor, so p2, as its siblings. One move-only slice per dispatch, serial with any in-flight PR on the file.Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Claim: PM loop round 1 · 2026-11-04T00:32Z
Session:
session_01WGufzedfGwVcebpN5t3ETE(card thread; dispatching seatsession_01WGufzjDyeFwq6AuFu3vwTd)Account:
os-support-aiBranch:
claude/project-thread-1cis03(platform-assigned to the card thread; it can push only this branch)Worktree:
objectstack-issue-29988Domain:
domain:uiSeat:
domain:ui#1File surface: slice 1 only:
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx(move-only), one new sibling module, by-path readers of the file (tests/gates) per ruling 6597555122 item 3, one root.changeset/file; ⛔ no logic, prop or behaviour change; PR saysRefs #29988, notFixes(stop on breach; explain in the report)Container & model:
M,mode:thread,model: TIER_DEFAULT(dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility: ui code produces it (
domain:ui) | no platform path covers it | every Studio/Console user who reaches the surface named in the card bodyThread-read: 6618575277
Premise: holds (re-read on
origin/main88cd0ab58:StudioDesignSurface.tsxis 12,882 lines; no open PR touches it at claim time)Serial constraints cleared: none in flight on
StudioDesignSurface.tsx(seat read 2026-11-04T00:30Z); #24586 ruling A serial rule applies to every later sliceOrder:
/mnt/project-files/ui-orders/29988.md· maintainer scope 「车队可以继续派发了，只派发 p1 p2 ，总并发不超过 20」 (2026-11-03T15:40Z)objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzedfGwVcebpN5t3ETE
os-dev-report
Stamp: 2026-11-04T02:02Z
{ "issue": 29988, "status": "done", "branch": "claude/project-thread-1cis03", "pr": "https://github.com/objectstack-ai/objectstack/pull/30002", "session": "session_01WGufzedfGwVcebpN5t3ETE", "premise_still_valid": true, "summary": "Slice 1 of the move-only split: StudioNavItemInspector, its nav target helpers and StudioPicker (base lines 3376-4353, 978 lines) moved byte-identical into views/studio-design/StudioNavItemInspector.tsx; the only edits are imports, `export` on StudioPicker and a re-export of the inspector from StudioDesignSurface.tsx. StudioDesignSurface.tsx is 12,882 to 11,884 lines (head 1ced76e0). The two tests that scan the file's whole text by path (homeRecoveryRedirectsFollowDeclaration-7373, spec-symbol-ledger-app-shell-7265) now read the new module too; the census 13461 walks the tree itself and has no row in the moved block. PR says Refs #29988; the seam table (11 rows, below) shows rows 1-6 are all low-risk and bring the file to about 9,860 lines.", "tests": "Byte-compare of the moved block: cmp silent, sha256 cfbbe19e358607a6 both sides; color-moved=zebra: only imports, the StudioPicker export line and the re-export are unmoved. Under os-verify-lock at 2e79c497 (ui tree identical at rebased head 1ced76e0): turbo build '@object-ui/app-shell...' VERDICT command-exit 0; app-shell type-check exit 0; ui type-check:scripts exit 0; eslint on changed files exit 0; vitest studio-design dir + 6 by-path/importer files: Test Files 328 passed (328), Tests 2429 passed (2429). Narrowed (declared): full app-shell suite left to CI Test UI. Ablation (ablation-replace.mjs, restored, git diff HEAD empty): '/home' literal injected into the new module reds the 7373 Studio site (1 failed/14 passed), and with alsoReads removed it stays green (15 passed, blind); a local `interface ObjectLike` in the new module reds the 7265 SITES row (1 failed/19 passed), and with the row removed stays green (19 passed, blind). Declaration bar: 697 of 698 other .d.ts byte-identical, ErrorBoundary.d.ts union member order only (normalised identical, control caught a dropped member); declared-surface digest of index.d.ts + StudioDesignSurface.d.ts equal (245 exports, 53af282f1e0f28e8), control caught.", "gates": "dispatch-gates --commands on 1ced76e0: 35 commands, all exit 0 (record in the PR body); --ran: 35 derived, 35 run, 0 NOT-MEASURED. check-platform-checklist --changed-from origin/main exit 0. CI check-runs: in_progress at report time.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "0", "api_writes": "2 — fleet-write relay pr_create (PR #30002, read back identical, no assignees); this os-dev-report comment via post-stamped.mjs. git push of the branch is not a REST write.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [ "carrier: domain:ui seat · docs/qa/platform-checklist/areas/studio-authoring.json cites `StudioDesignSurface.tsx (the Studio menu-entry inspector)` in an item's source list; after this slice that file mounts the inspector but StudioNavItemInspector.tsx defines it. Not edited here (outside the claimed file surface); re-point at the next checklist touch. noted, not filed" ] }Seam table
Measured on
origin/main88cd0ab58, whereui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis 12,882 lines. Every seam is a set of module-scope declarations (the file has no component defined inside another component), so "inbound" below is what the seam reads from the rest of the module and which hooks it calls; no seam closes over another component's state. Line ranges are base lines, comments included. "Left" is the file's line count after that row and every row above it; row 1 is measured, the rest are estimates (lines removed, plus about two import lines per slice).StudioNavItemInspector, its nav target helpers (usePackageNavTargets,NavTargetSelect,NavUrlFields, badge variants,navVisibleText) andStudioPickeruseMetadataClient,useMetadataLocale,useNavTargetLabelInterfacesPillar(inspector);DataPillar,AutomationsPillar(StudioPicker); 7 test files import the inspector through./StudioDesignSurfacePackageSwitcherwithPACKAGE_LIST_TOAST_IDandSTUDIO_LANDING_PATHuseHomePath,useMetadataLocale,useNavigateStudioDesignSurfaceBody;DataPillar(toast id)const homePath = useHomePath()needle, so that reader'salsoReadsgains the new moduleNavTree,NavTreeGroup,ContributedNavRows,OffNavSections, the two rail contexts,navKindName,navOpenedItems, withKIND_ICON/navIconuseMetadataLocale,useNavTargetLabel,useOpenContributorInterfacesPillaronlyFlowRuntimeState,FlowRailState,FlowStatusDot,flowRailStatus,flowDotClass, glyph tables, the flow/label reads, new-flow trigger helpers,pairIdOf, copied-arrival readerAutomationsPillar;AccessPillar(pairIdOf); 2 tests importFlowStatusDotFlowRuntimeStatesite of the app-shell spec-symbol ledger, which gains the new moduleuseHeldEditReport,confirmDropUnsavedWork,findTakenIdentifier,CreateTakenNotice,StudioHeldNotice, the "Show me" focus helpers (useShowInputFocus),announceDraftSaved,StudioReadOnlyLink,StudioBaseCustomizationuseStudioTabRowFoldStudioDesignSurfaceBodyaddedFieldName,extensionFieldsOf,STUDIO_SYSTEM_FIELD_NAMES,renderStudioGridList, the CEL panel stamps,formPreviewSource, the OWD option keysDataPillaronly; 1 test importsrenderStudioGridListAccessPillarwith its new-similar arrival reader andStudioNameLabelpairIdOf, the kit) · 11 hooksStudioDesignSurfaceBody; 7 test filesAutomationsPillarStudioDesignSurfaceBody; 23+ test filesDataPillarStudioDesignSurfaceBody; 38+ test filesclickableNonControlCensus-13461rows keyed by this file, which move with itInterfacesPillarwithinterfacesSaveBody,leafKeyOf,customizeItemKeyStudioDesignSurfaceBody; 29+ test filesStudioDesignSurface/StudioDesignSurfaceBody,PILLARS,METADATA_AREA_TAB,PILLAR_FOR_SURFACE_TYPE, publish-refusal and backfill helpersindex.ts, the console's lazy Studio route, 51 test filesWhat cannot move without a logic change. Anything below the whole-component level of rows 7–11: a pillar's rail, canvas or inspector section, or the surface body's publish flow. Each is JSX plus handlers that close over that component's own
useState/useCallbackvalues, so taking one out needs new props or a hook with parameters, which is a logic change. None of it is needed: rows 1–6 are pure helpers or prop-only components and together bring the file to about 9,860 lines, under the 10,000 bar.Serial order the table implies. Rows 2–6 in any order (none reads another), then rows 7–10 only after row 5, so the pillars never import back from this file.
Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
ACCEPT → PR #30002 (slice 1) comment 6620565365 · head
1ced76e0· 2026-11-04T02:05Z. Landing waits for every check green on that head.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Landed · slice 1 · PR #30002 ·
f7aab89580· 2026-11-04T02:33Zf7aab89580origin/maincontentStudioDesignSurface.tsxis 11,884 lines (was 12,882);StudioNavItemInspector.tsxholds the moved nav item inspector andStudioPickerACCEPT 6620565365. The card stays open (
Refs #29988): the file is still over 10,000 lines.pm:dispatchedand the assignee stay, because slice 2 (seam table row 2,PackageSwitcher) is dispatched next, serial on this merge. Slice 2 also re-points thestudio-authoring.jsonprose source for the menu-entry inspector.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Claim: PM loop round 2 · 2026-11-04T02:34Z
Session:
session_01WGufzedfGwVcebpN5t3ETE(card thread; dispatching seatsession_01WGufzjDyeFwq6AuFu3vwTd)Account:
os-support-aiBranch:
claude/project-thread-1cis03(platform-assigned to the card thread; it can push only this branch)Worktree:
objectstack-issue-29988Domain:
domain:uiSeat:
domain:ui#1File surface: slice 2 only:
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx(move-only, seam row 2PackageSwitcher), one new sibling module, by-path readers of the file per ruling 6597555122 item 3,docs/qa/platform-checklist/areas/studio-authoring.json(source re-point only), one root.changeset/file; ⛔ no logic, prop or behaviour change; PR saysRefs #29988, notFixes(stop on breach; explain in the report)Container & model:
M,mode:thread,model: TIER_DEFAULT(dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility: ui code produces it (
domain:ui) | no platform path covers it | every Studio/Console user who reaches the surface named in the card bodyThread-read: 6620970196
Premise: holds (re-read on
origin/mainf7aab8958:StudioDesignSurface.tsxis 11,884 lines after slice 1, PR #30002)Serial constraints cleared: slice 1 merged (PR #30002,
f7aab89580, 2026-11-04T02:32Z); branch restarts fromorigin/main; #24586 ruling A serial rule appliesOrder:
/mnt/project-files/ui-orders/29988-s2.md· maintainer scope 「车队可以继续派发了，只派发 p1 p2 ，总并发不超过 20」 (2026-11-03T15:40Z)objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzedfGwVcebpN5t3ETE
os-dev-report
Stamp: 2026-11-04T04:01Z
{ "issue": 29988, "status": "done", "branch": "claude/project-thread-1cis03", "pr": "https://github.com/objectstack-ai/objectstack/pull/30008", "session": "session_01WGufzedfGwVcebpN5t3ETE", "premise_still_valid": true, "summary": "Slice 2 of the move-only split (seam row 2): PackageSwitcher, PACKAGE_LIST_TOAST_ID and STUDIO_LANDING_PATH (base f7aab8958 lines 832-846 and 897-1544, 663 lines) moved byte-identical into views/studio-design/PackageSwitcher.tsx; the only edits are imports and `export` on the three names, imported back by the surface and DataPillar. StudioDesignSurface.tsx is 11,884 to 11,205 lines (head 02c3a7f0). The 7373 Studio site's alsoReads and the 7265 ledger SITES gained the new module. studio-authoring.json: the slice 1 menu-entry inspector source re-pointed (app-and-nav-properties r6) and first-run-loop acceptance[0].verify re-pointed for the studio-pkg-chip testid that moved with the switcher (r12); no clause changed. Branch restarted from origin/main after #30002 merged; PR says Refs #29988.", "tests": "Byte-compare: block A 15 lines cmp silent (sha256 aa1ecaea48757927), block B 648 lines cmp silent (e5c09d177d162507); color-moved=zebra: only imports, the module header and the three export lines are unmoved. Under os-verify-lock at ac845e5e (ui/, docs/qa/ and changeset identical at rebased head 02c3a7f0), one chain VERDICT command-exit 0: turbo build '@object-ui/app-shell...' exit 0; app-shell type-check exit 0; ui type-check:scripts exit 0; eslint exit 0; vitest studio-design dir + 7 by-path/importer files: Test Files 329 passed (329), Tests 2445 passed (2445). Narrowed (declared): full app-shell suite left to CI Test UI. Ablation (ablation-replace.mjs, restored, git diff HEAD empty): dropping PackageSwitcher.tsx from the 7373 Studio site's alsoReads reds 'resolves its target through the policy' (1 failed/14 passed; B0 green 15/15); a local `interface ObjectLike` in PackageSwitcher.tsx reds its 7265 SITES row (1 failed/20 passed), and removing the row leaves it green (20 passed, blind). Declaration bar: all 700 base .d.ts byte-identical at head incl. StudioDesignSurface.d.ts; only PackageSwitcher.d.ts added; surface digest 53af282f1e0f28e8 both sides. check-platform-checklist full and --changed-from origin/main exit 0.", "gates": "dispatch-gates --commands on 02c3a7f0: 42 commands, all exit 0 (record in the PR body); --ran: 42 derived, 42 run, 0 NOT-MEASURED. CI check-runs: in_progress at report time.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "0", "api_writes": "2 — fleet-write relay pr_create (PR #30008, read back identical, no assignees); this os-dev-report comment via post-stamped.mjs. git push is not a REST write.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [ "carrier: domain:ui seat · two test comments name StudioDesignSurface.tsx for text that moved with the switcher: PackagesPage.confirmFlows-11784.test.tsx (the eviction) and packages-io.inflightShare-11797.test.tsx (the PACKAGE_LIST_TOAST_ID doc). Prose only, outside this slice's file surface; re-point with the next touch. noted, not filed" ] }Seam table
Carried forward from #30002. Base lines below are at
origin/mainf7aab8958(this PR's base, after slice 1), whereui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis 11,884 lines. "Left" is the file's line count after that row and every row above it: rows 1–2 are measured, the rest are estimates (lines removed, plus about two import lines per slice). Every seam is module-scope; no seam closes over another component's state.StudioNavItemInspector, nav target helpers,StudioPicker)PackageSwitcherwithPACKAGE_LIST_TOAST_IDandSTUDIO_LANDING_PATHuseHomePath,useMetadataLocale,useNavigateStudioDesignSurfaceBody(all three);DataPillar(toast id)NavTree,NavTreeGroup,ContributedNavRows,OffNavSections, the two rail contexts,navKindName,navOpenedItems, withKIND_ICON/navIconuseMetadataLocale,useNavTargetLabel,useOpenContributorInterfacesPillaronlyFlowRuntimeState…readFlowCopiedArrival, incl.FlowStatusDot, glyph tables,pairIdOfAutomationsPillar;AccessPillar(pairIdOf); 2 tests importFlowStatusDotFlowRuntimeStatesiteuseHeldEditReport,confirmDropUnsavedWork,findTakenIdentifier,CreateTakenNotice,StudioHeldNotice, the "Show me" focus helpers,announceDraftSaved,StudioReadOnlyLink,StudioBaseCustomizationuseStudioTabRowFoldStudioDesignSurfaceBodyaddedFieldName…formPreviewSource, the OWD option keys)DataPillaronly; 1 test importsrenderStudioGridListAccessPillarwith its arrival reader andStudioNameLabelStudioDesignSurfaceBody; 7 test filesAutomationsPillarStudioPicker, row 1) · 21 hooksStudioDesignSurfaceBody; 23+ test filesDataPillarStudioPicker) · 17 hooksStudioDesignSurfaceBody; 38+ test filesclickableNonControlCensus-13461rows keyed by this fileInterfacesPillarwithinterfacesSaveBody,leafKeyOf,customizeItemKeyStudioDesignSurfaceBody; 29+ test filesStudioDesignSurface/StudioDesignSurfaceBody,PILLARS,METADATA_AREA_TAB,PILLAR_FOR_SURFACE_TYPE, publish-refusal and backfill helpersindex.ts, the console's lazy Studio route, 51 test filesUnchanged from #30002: nothing below the whole-component level of rows 7–11 moves without a logic change, and none of it is needed, because rows 3–6 bring the file under 10,000. Serial order: rows 3–6 in any order, then rows 7–10 only after row 5.
Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
ACCEPT → PR #30008 (slice 2) comment 6622214696 · head
02c3a7f0· 2026-11-04T04:03Z. Landing waits for every check green on that head.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Landed · slice 2 · PR #30008 ·
73a3ef9fe5· 2026-11-04T04:31Z73a3ef9fe5origin/maincontentStudioDesignSurface.tsxis 11,205 lines (was 11,884);PackageSwitcher.tsxholds the package switcher;studio-authoring.jsonsources re-pointed (r6, r12)ACCEPT 6622214696. The card stays open (
Refs #29988): the file is still over 10,000 lines.pm:dispatchedand the assignee stay; slice 3 (seam table row 3, the Interfaces nav tree rail) is dispatched next, serial on this merge.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Claim: PM loop round 3 · 2026-11-04T04:32Z
Session:
session_01WGufzedfGwVcebpN5t3ETE(card thread; dispatching seatsession_01WGufzjDyeFwq6AuFu3vwTd)Account:
os-support-aiBranch:
claude/project-thread-1cis03(platform-assigned to the card thread; it can push only this branch)Worktree:
objectstack-issue-29988Domain:
domain:uiSeat:
domain:ui#1File surface: slice 3 only:
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx(move-only, seam row 3, Interfaces nav tree rail), one new sibling module, by-path readers of the file per ruling 6597555122 item 3,docs/qa/platform-checklist/**source/verify re-points only, comment-only edits inPackagesPage.confirmFlows-11784andpackages-io.inflightShare-11797tests, one root.changeset/file; ⛔ no logic, prop or behaviour change; PR saysRefs #29988, notFixes(stop on breach; explain in the report)Container & model:
M,mode:thread,model: TIER_DEFAULT(dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility: ui code produces it (
domain:ui) | no platform path covers it | every Studio/Console user who reaches the surface named in the card bodyThread-read: 6622608042
Premise: holds (re-read on
origin/main73a3ef9fe:StudioDesignSurface.tsxis 11,205 lines after slice 2, PR #30008)Serial constraints cleared: slice 2 merged (PR #30008,
73a3ef9fe5, 2026-11-04T04:30Z); branch restarts fromorigin/main; #24586 ruling A serial rule appliesOrder:
/mnt/project-files/ui-orders/29988-s3.md· maintainer scope 「车队可以继续派发了，只派发 p1 p2 ，总并发不超过 20」 (2026-11-03T15:40Z)objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzedfGwVcebpN5t3ETE
os-dev-report
Stamp: 2026-11-04T06:02Z
{ "issue": 29988, "status": "done", "branch": "claude/project-thread-1cis03", "pr": "https://github.com/objectstack-ai/objectstack/pull/30014", "session": "session_01WGufzedfGwVcebpN5t3ETE", "premise_still_valid": true, "summary": "Slice 3 of the move-only split (seam row 3): the Interfaces nav tree rail (NavTree, NavTreeGroup, ContributedNavRows, OffNavSections/OffNavSection, InterfacesRailMarksContext, InterfacesNavContributionsContext, navKindName, navOpenedItems, navTreeHoldsActive, OFF_NAV_TYPES/OffNavType/itemKeyOf, KIND_ICON/navIcon; base eee41490 lines 663-679 and 2249-2673, 442 lines) moved byte-identical into views/studio-design/InterfacesNavRail.tsx; the only edits are imports and `export` on the eleven names InterfacesPillar reads. The contexts moved unchanged (no logic change needed). No reader outside InterfacesPillar existed, so no re-export. StudioDesignSurface.tsx is 11,205 to 10,757 lines (head 36954c62). The 7373 Studio site's alsoReads and the 7265 ledger SITES gained the new module. The two flagged test comments (PackagesPage.confirmFlows-11784, packages-io.inflightShare-11797) now name PackageSwitcher.tsx. docs/qa: no citation cites moved text, so the checklist is untouched (no revision row). Branch restarted from origin/main after #30008 merged; PR says Refs #29988.", "tests": "Byte-compare: block A 17 lines cmp silent (sha256 44978201e446c1bb), block B 425 lines cmp silent (73d3528850a14d73); color-moved=zebra: only imports, the module header, the eleven export lines and the cut separators are unmoved. Under os-verify-lock at 376a48cf (ui/ and changeset identical at head 36954c62), one chain VERDICT command-exit 0: turbo build '@object-ui/app-shell...' exit 0; app-shell type-check exit 0; ui type-check:scripts exit 0; eslint exit 0; vitest studio-design dir + 7 by-path/importer files: Test Files 329 passed (329), Tests 2446 passed (2446). Narrowed (declared): full app-shell suite left to CI Test UI. Ablation (ablation-replace.mjs, restored, git diff HEAD empty): the moved rail carries neither needle, so a planted '/home' literal in InterfacesNavRail.tsx reds the 7373 Studio site (1 failed/14 passed; B0 green 15/15) and dropping the module from alsoReads blinds it (15 passed); a planted `interface ObjectLike` reds its 7265 SITES row (1 failed/21 passed) and removing the row blinds it (21 passed). Declaration bar: 700 of 701 base .d.ts byte-identical at head incl. StudioDesignSurface.d.ts (d0f9665b1e9ed6fc); chrome/ErrorBoundary.d.ts differs by union member order only (identical with unions sorted, ruling 6348891160); only InterfacesNavRail.d.ts added; masked surface digest ce63368a1cf8becf both sides (245 exports). check-platform-checklist full and --changed-from origin/main exit 0.", "gates": "dispatch-gates --commands at b4129e71 (same tree as head 36954c62; the amend rewrote only the co-author trailer to the model-free pair the push hook asks for): 35 commands, all exit 0 (record in the PR body); --ran: 35 derived, 35 run, 0 NOT-MEASURED. CI check-runs: queued at report time.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "10, reads only: list_pull_requests 1 and pull_request_read get_files 9, for the serial check; no GitHub MCP writes", "api_writes": "2 — fleet-write relay pr_create (PR #30014, read back identical, no assignees); this os-dev-report comment via post-stamped.mjs. git push is not a REST write.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [] }Seam table
Carried forward from #30008. Base lines below are at
origin/maineee41490(this PR's base;StudioDesignSurface.tsxis byte-identical at73a3ef9f, where #30008 landed), whereui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis 11,205 lines. "Left" is the file's line count after that row and every row above it: rows 1–3 are measured, the rest are estimates (lines removed, less about two import lines per slice). Every seam is module-scope; no seam closes over another component's state.StudioNavItemInspector, nav target helpers,StudioPicker)PackageSwitcherwithPACKAGE_LIST_TOAST_IDandSTUDIO_LANDING_PATHNavTree,NavTreeGroup,ContributedNavRows,OffNavSections, the two rail contexts,navKindName,navOpenedItems, withKIND_ICON/navIconuseMetadataLocale,useNavTargetLabel,useOpenContributorInterfacesPillaronlyFlowRuntimeState…readFlowCopiedArrival, incl.FlowStatusDot, glyph tables,pairIdOfAutomationsPillar;AccessPillar(pairIdOf); 2 tests importFlowStatusDotFlowRuntimeStatesiteuseHeldEditReport,confirmDropUnsavedWork,findTakenIdentifier,CreateTakenNotice,StudioHeldNotice, the "Show me" focus helpers,announceDraftSaved,StudioReadOnlyLink,StudioBaseCustomizationuseStudioTabRowFoldStudioDesignSurfaceBodynextFieldName…formPreviewSource, the OWD option keys)DataPillaronly; 1 test importsrenderStudioGridListAccessPillarwith its arrival reader andStudioNameLabelStudioDesignSurfaceBody; 7 test filesAutomationsPillarStudioPicker, row 1) · 21 hooksStudioDesignSurfaceBody; 23+ test filesDataPillarStudioPicker) · 17 hooksStudioDesignSurfaceBody; 38+ test filesclickableNonControlCensus-13461rows keyed by this fileInterfacesPillarwithinterfacesSaveBody,leafKeyOf,customizeItemKeyStudioDesignSurfaceBody; 29+ test filesStudioDesignSurface/StudioDesignSurfaceBody,PILLARS,METADATA_AREA_TAB,PILLAR_FOR_SURFACE_TYPE, publish-refusal and backfill helpersindex.ts, the console's lazy Studio route, 51 test filesUnchanged from #30002: nothing below the whole-component level of rows 7–11 moves without a logic change, and none of it is needed, because rows 3–6 bring the file under 10,000. Serial order: rows 4–6 in any order, then rows 7–10 only after row 5.
Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
ACCEPT → PR #30014 (slice 3) comment 6623885036 · head
36954c62· 2026-11-04T06:04Z. Landing waits for every check green on that head.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Landed · slice 3 · PR #30014 ·
9d1a465f01· 2026-11-04T06:36Z9d1a465f01origin/maincontentStudioDesignSurface.tsxis 10757 lines (was 11,205);InterfacesNavRail.tsxholds the Interfaces nav tree railACCEPT 6623885036. The card stays open. Seat ruling with devx#1 after the maintainer questioned slice size (2026-11-04T06:19Z): slice 4 is the final slice. It carries seam rows 4, 5 and 6 in one PR (three modules, each block byte-compared), closes the card with
Fixes #29988, and leaves the file under 10,000 lines. Rows 7–10 (whole pillars) stay in the seam table for a later card. Fallback: row 4 alone if combining hits a cycle, a census re-key, or more than 3,000 changed lines.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Claim: PM loop round 4 · 2026-11-04T06:36Z
Session:
session_01WGufzedfGwVcebpN5t3ETE(card thread; dispatching seatsession_01WGufzjDyeFwq6AuFu3vwTd)Account:
os-support-aiBranch:
claude/project-thread-1cis03(platform-assigned to the card thread; it can push only this branch)Worktree:
objectstack-issue-29988Domain:
domain:uiSeat:
domain:ui#1File surface: slice 4 (final):
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx(move-only, seam rows 4, 5, 6), three new sibling modules, by-path readers of the file per ruling 6597555122 item 3,docs/qa/platform-checklist/**source/verify re-points only, one root.changeset/file; ⛔ no logic, prop or behaviour change; PR saysFixes #29988(file under 10,000 lines) (stop on breach; explain in the report)Container & model:
L,mode:thread,model: TIER_DEFAULT(dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility: ui code produces it (
domain:ui) | no platform path covers it | every Studio/Console user who reaches the surface named in the card bodyThread-read: 6624384366
Premise: holds (re-read on
origin/main9d1a465f0:StudioDesignSurface.tsxis 10757 lines after slice 3, PR #30014)Serial constraints cleared: slice 3 merged (PR #30014, 2026-11-04T06:35Z); branch restarts from
origin/main; #24586 ruling A serial rule appliesOrder:
/mnt/project-files/ui-orders/29988-s4.md· maintainer scope 「车队可以继续派发了，只派发 p1 p2 ，总并发不超过 20」 (2026-11-03T15:40Z)objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzedfGwVcebpN5t3ETE
os-dev-report
Stamp: 2026-11-04T08:25Z
{ "issue": 29988, "status": "done", "branch": "claude/project-thread-1cis03", "pr": "https://github.com/objectstack-ai/objectstack/pull/30027", "session": "session_01WGufzedfGwVcebpN5t3ETE", "premise_still_valid": true, "summary": "Slice 4 (final), one PR, one commit per seam row: row 4 flow rail helpers (base 9d1a465f0 lines 7614-7960, 347 lines) -> AutomationsFlowRail.tsx; row 6 Data pillar helpers (443-460, 5135-5202, 5281-5375, 181 lines) -> DataPillarHelpers.tsx; row 5 pillar kit (504-643, 663-751 incl. the Show me section comment, 764-843, 2233-2258, 335 lines) -> StudioPillarKit.tsx. Byte-identical apart from imports and `export` (38 names gained export). The five names StudioDesignSurface exported before (FlowStatusDot, NewFlowTrigger, StudioHeldNotice, StudioReadOnlyLink, StudioBaseCustomization) are re-exported there, so every importer through ./StudioDesignSurface is unchanged. renderStudioGridList stays in the file: its eslint-disable line would be an unused directive (an eslint error, measured on the first cut) in a module exporting no component, so it cannot move unchanged. StudioDesignSurface.tsx is 10,757 to 9,928 lines (under 10,000), so the PR says Fixes #29988. No fallback trigger: no import cycle, no census re-key, 1,941 changed lines. Readers: 7373 alsoReads and 7265 SITES gained the three modules. Checklist: four studio-authoring source re-points with revision rows (held-edit-leave-guard r6, automations-rail-and-new-flow r3, flow-status-matches-runtime r3, access-permission-set-lifecycle r8), no clause changed. Rows 7-10 not moved, marked available to a later card.", "tests": "Byte-compare of all eight blocks against base 9d1a465f0: all cmp silent (commands and sha256 in the PR body); color-moved=zebra: 1,678 lines coloured moved, the unmoved lines are only imports, module headers, the 38 export edits, two re-export lines with comments and two cut separators. Under os-verify-lock at 16500092 (ui/, docs/qa/ and changeset identical at rebased head ec616a8a), one chain VERDICT command-exit 0: turbo build exit 0; app-shell type-check exit 0; ui type-check:scripts exit 0; eslint exit 0 (warnings only); vitest studio-design dir + 8 importer/by-path files: Test Files 330 passed (330), Tests 2490 passed (2490). Narrowed (declared): full app-shell suite left to CI Test UI. Ablation, 12 legs plus B0: for each new module a planted '/home' literal reds the 7373 Studio site (1 failed/14 passed) and dropping the module from alsoReads blinds it (15 passed); a planted interface ObjectLike reds its 7265 SITES row (1 failed/24 passed) and dropping the row blinds it (24 passed); tree restored each time. Declarations: 699 of 702 base .d.ts byte-identical; ErrorBoundary.d.ts and outboundAgentText.d.ts differ by union member order only; StudioDesignSurface.d.ts now re-exports the five names and every base declaration chunk appears verbatim in it or the three new .d.ts files (except the header-plus-imports chunk); surface digest 245 exports both sides, identical with the declaring file of a type masked (6e1f795576824163). check-platform-checklist full and --changed-from origin/main exit 0.", "gates": "dispatch-gates --commands on ec616a8a: 42 commands, all exit 0 (record in the PR body); --ran: 42 derived, 42 run, 0 NOT-MEASURED. CI check-runs: queued at report time.", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "2, reads only: list_pull_requests twice, for the serial check; no GitHub MCP writes", "api_writes": "2 — fleet-write relay pr_create (PR #30027, read back identical, no assignees); this os-dev-report comment via post-stamped.mjs. git push is not a REST write.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [ "carrier: domain:ui seat · renderStudioGridList stays in StudioDesignSurface.tsx because moving it unchanged would leave an unused eslint-disable directive (react-refresh/only-export-components) in a module exporting no component; a later card can move it and drop that line if the maintainer wants row 6 whole. noted, not filed", "carrier: domain:ui seat · spec-symbol-parity.test.ts comment says StudioDesignSurface declares type FlowRuntimeState; it now lives in AutomationsFlowRail.tsx. Prose only, outside this slice's file surface. noted, not filed" ] }Seam table
Carried forward from #30014. Base lines below are at
origin/main9d1a465f0(this PR's base, after slice 3), whereui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis 10,757 lines. "Left" is the file's line count after that row and every row above it, measured at this PR's commits.StudioNavItemInspector, nav target helpers,StudioPicker)PackageSwitcherwithPACKAGE_LIST_TOAST_IDandSTUDIO_LANDING_PATHNavTree…KIND_ICON/navIcon)FlowRuntimeState…readFlowCopiedArrival, incl.FlowStatusDot, glyph tables,pairIdOf→AutomationsFlowRail.tsxAutomationsPillar;AccessPillar(pairIdOf); 2 tests importFlowStatusDot(re-exported)nextFieldName…STUDIO_SYSTEM_FIELD_NAMES,formFieldNames…formPreviewSource→DataPillarHelpers.tsxDataPillaronlyrenderStudioGridList(5204–5279, 76 lines) stays, see What changesuseHeldEditReport,confirmDropUnsavedWork,findTakenIdentifier,CreateTakenNotice,StudioHeldNotice, the "Show me" focus helpers with their section comment,announceDraftSaved,StudioReadOnlyLink,StudioBaseCustomization→StudioPillarKit.tsxuseStudioTabRowFoldStudioDesignSurfaceBody;StudioBundleItemEditor.tsx,StudioMetadataArea.tsxand 6 tests import its types or components through./StudioDesignSurface(re-exported)AccessPillarwith its arrival reader andStudioNameLabelStudioDesignSurfaceBody; 7 test filesAutomationsPillarStudioPicker, row 1) · 21 hooksStudioDesignSurfaceBody; 23+ test filesDataPillarStudioPicker) · 17 hooksStudioDesignSurfaceBody; 38+ test filesclickableNonControlCensus-13461rows keyed by this file)InterfacesPillarwithinterfacesSaveBody,leafKeyOf,customizeItemKeyStudioDesignSurfaceBody; 29+ test filesStudioDesignSurface/StudioDesignSurfaceBody,PILLARS,METADATA_AREA_TAB,PILLAR_FOR_SURFACE_TYPE, publish-refusal and backfill helpersindex.ts, the console's lazy Studio route, 51 test filesRows 4–6 now live outside the file, so a later card can move rows 7–10 without an import cycle back into it.
Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
ACCEPT → PR #30027 (slice 4, final,
Fixes #29988) comment 6626275393 · headec616a8a· 2026-11-04T08:28Z. Landing waits for every check green on that head.objectstack-fleet commentedon Nov 4, 2026
domain:ui#1 · os-support-ai · session_01WGufzjDyeFwq6AuFu3vwTd
Landed · slice 4 (final) · PR #30027 ·
c618e890ec· 2026-11-04T08:57Zc618e890ecorigin/maincontentStudioDesignSurface.tsxis 9928 lines, under the 10,000 bar (was 12,882 at claim); split acrossStudioNavItemInspector.tsx,PackageSwitcher.tsx,InterfacesNavRail.tsx,AutomationsFlowRail.tsx,DataPillarHelpers.tsx,StudioPillarKit.tsxACCEPT 6626275393. The card is closed by
Fixes #29988(state: closed completed).pm:dispatchedis removed in this stroke. Four move-only PRs landed: #30002, #30008, #30014 and #30027. Not moved, and available to a later card if the maintainer asks: seam rows 7–10 (the four whole pillars), plusrenderStudioGridList, which needs itsreact-refreshdirective dropped to move.