Repository navigation
Codemod split pilot: generate the sql-driver.ts split with a deterministic script, verified byte-identical #29520
Description
domain:devx#1 · os-warren · session_01JQwxbaBjisxkQo9hht9bFB
Filing gate: ruling 6583399215 on #29465 (letter A, maintainer 「同意」 2026-11-02T17:11Z), which names this pilot card as the domain:devx seat's to file. ⛔ Not a claim. No grade: triage sets it and routes it.
Ruling-ref: 6583399215
Governs: #24586 ruling A (6270097840, one move-only programme per file over 10,000 lines), the declaration-file bar of ruling 6348891160 on #25222, and the landing plan 6582376616 on #29465.
What to build
- A deterministic codemod (ts-morph;
packages/clialready depends onts-morph^28) that applies the cut pattern the hand series already used on this file ([maintainer] refactor(driver-sql): splitsrc/sql-driver.ts(22,096 lines, +2,533 in 30 days) along itsSqlDriverseams, one move-only slice per PR #25521, closed after cut 21): a whole section's method bodies move to a section module, theSqlDriverclass keeps one-line stubs, and shared members are reached through the host pattern the existing modules use (packages/drivers/driver-sql/src/sql-driver-*.ts, e.g.sql-driver-introspection.ts,sql-driver-schema-sync.ts). - The script's own check: every moved body is byte-identical to its source (AST text comparison), and the package's declaration files pass ruling 6348891160's bar (sorted string-literal unions compare equal; no declaration added or removed).
- Run it on
packages/drivers/driver-sql/src/sql-driver.ts(18,333 lines onmain04e0c2c0, one commit in the last 7 days, no open PR on it) in a draft PR that carries the script and the generated split, plus type-check and the full suite.
How it lands (landing plan 6582376616)
- Phase 0, no pause: build and prove the script and the generated pilot in the draft PR. The PR is over 3000 changed lines, so it takes contract review, the final four-piece set and the maintainer's approval.
- Phase 1, a window the maintainer orders (「车队什么时候空闲是有我安排的」): seats land or park open PRs on the file, the dev re-runs the script on the latest
main(regenerated, never rebased), CI runs once, the maintainer approves and the PR enters the merge queue. - ⛔ A pilot that fails byte-identity or the declaration bar is reported as a fork on [Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465 and option B applies there. The generated split is never hand-edited to pass.
After the pilot merges
Per the ruling, one codemod card per remaining file goes to its lane: packages/spec/src/conversions/registry.ts → domain:spec (per-entry files with a generated index, as #7297 did); packages/objectql/src/engine.ts (#25522 is released into its card) and the rest of packages/metadata-protocol/src/protocol.ts (#25467 stops cutting once its codemod card is claimed) → domain:server. StudioDesignSurface.tsx stays on hand slices. Note the current freeze on protocol.ts (server seat 5, until 2026-11-03 06:00Z at the latest) before any work there.
Done when
The draft PR holds the script and the generated sql-driver.ts split, its byte-identity and declaration checks pass, type-check and the full suite are green, and it has landed in the maintainer's window (or the fork is reported on #29465).
Dedupe: searched codemod split, sql-driver.ts split script, generated split: only #29465, #25521, #24586. New.
Activity
objectstack-fleet commentedon Nov 2, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: p2 ·
domain:devx·pm:queue· 2026-11-02T17:30Z⛔ Not a claim.
driver-sql/src/sql-driver.ts, verified byte-identical, landing as a draft. Tooling, sodomain:devx. The split itself is move-only. p2.Generated by Claude Code
objectstack-fleet commentedon Nov 2, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Claim: PM loop round 3
Session:
session_017ihL2gLghEqeDKTbDTC7ZdAccount:
marchtianBranch:
claude/issue-29520-sql-driver-codemod-pilotWorktree:
objectstack-issue-29520Domain:
domain:devxSeat:
domain:devx#2File surface: one new codemod script (and its self-check) under
scripts/; the generated split ofpackages/drivers/driver-sql/src/sql-driver.tsintopackages/drivers/driver-sql/src/sql-driver-*.tssection modulesContainer & model:
L,mode:subagent,model: default tier,effort: highClause-②: no
Metadata-protocol: none
Responsibility: the move-only split of
sql-driver.ts(over 18,000 lines) is generated by a deterministic, byte-identity-checked script instead of by hand (ruling 6583399215 on #29465, option A)Thread-read: 6583797610
Premise: holds
Serial constraints cleared: none needed for phase 0 (a draft only). Phase 1 waits for the maintainer's window, per the landing plan 6582376616; the script is re-run on the latest
mainthen, never rebased.Phase 0 only: the draft PR is over 3000 changed lines, so it lands through contract review, the final four-piece set and the maintainer's approval in the window the maintainer names.
objectstack-fleet commentedon Nov 2, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "status": "done", "branch": "claude/issue-29520-sql-driver-codemod-pilot", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598", "head": "9414843b4a", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "premise_still_valid": true, "yield_premise_holds": false, "summary": "Phase 0 pilot, draft PR #29598. It holds two things. The first is scripts/codemod-split-sql-driver.mjs: a deterministic ts-morph codemod that applies the hand series' cut pattern per SqlDriver section banner. It proves its own output (byte-identity: undoing the split rebuilds the base file byte-for-byte; the ruling 6348891160 item 1 declaration bar on two built dists; a 23-case self-test). The second is the split it generated, unedited: 20 method bodies into 10 section modules, with stubs on the class. Both proofs pass, and the driver-sql, driver-turso and driver-sqlite-wasm suites match the base counts exactly. The yield is what the seat must rule on. Under the binding pattern only 20 of 254 methods can move, and sql-driver.ts goes 18,333 -> 18,225 lines (-108, 0.6%). These are the same limits that closed the hand series at cut 21.", "measurements": { "sections": "23 banners in the class, all named in SECTION_MODULES; 10 sections move at least one method, 13 move none", "methods": "20 of 254 move", "lines": "sql-driver.ts 18,333 -> 18,225 (wc -l): 263 body lines out, 135 stub lines in, 20 import+comment lines in; 10 new modules, 642 lines; the script prints 18,334 -> 18,226 (it counts the empty string after the final newline)", "stay_reasons": "module-value 119, already-moved 78, tenant-chokepoint 77, no-yield 43, parameter-shape 21, this-write 19, no-section 14, static 11, comment-in-parameters 7, field-call 6, inferred-return-type 6, type-parameters 3, name-taken 3, module-local-type 2, reserved-name 1", "relaxed_upper_bounds": "method counts only, no output generated: admit value imports from sql-driver.ts -> 47 methods, 17,184 lines; also widen check-tenant-chokepoint SCAN_FILES -> 69 methods, 15,925 lines; without the no-yield rule (literal whole section) -> 63 methods and sql-driver.ts GROWS to 18,398 (+65)", "byte_identity": "20/20 moved bodies, parameter lists, return types and async flags identical to base; undoing the split rebuilds base sql-driver.ts byte-for-byte; --verify --base b16ee8ba06 exit 0 (and --base dbca3ef034 exit 0)", "declaration_bar": "index.d.ts and index.d.mts: raw base = raw head = normalised base = normalised head = 0f33bf3febaac3c7aa96f68a4226d752766b8203ab7acade523b69f9aaa44d74; raw diff lines 0; d.ts export names 92 = 92; positive control (first private member made public) 8b716bae7c2a072f50610f2a55a7a8619049383183fda0247a3c0a411537945f != base; normaliser = the ruling's one-liner verbatim, rerun by hand on both files -> 0f33bf3f...; runtime CJS 59 = 59, ESM 59 = 59, CJS = ESM; both dists built at merged main b16ee8ba06 (unsplit input) and at head", "determinism": "output tree sha256 35afbb967b5aa063886af8a663d94969b88f0a73822a5f4b9677bb76925b4738 on: plan run, --write at dbca3ef034, --write on merged main b16ee8ba06; on-disk tree hashes the same; input sha256 e73b1ce952e1e449aee59d906d955809d6d8b718ecc02fcf2523fc699acee775 both times (main had not touched sql-driver.ts)", "changed_lines": "2,333 (+2,105 / -228, 12 files): under the 3,000 human-merge threshold, not over it as the order assumed; the PR stays draft per the landing plan" }, "claims": [ "moved bodies are byte-identical and nothing else in sql-driver.ts moved -> scripts/codemod-split-sql-driver.mjs verify() (rebuild-equals-base check)", "the declaration bar is ruling 6348891160 item 1 (a)-(d) plus the positive control -> scripts/codemod-split-sql-driver.mjs dtsBarFor(), normaliseUnionOrder(), NORMALISER_ONE_LINER", "what stays and why is mechanical -> scripts/codemod-split-sql-driver.mjs STAY_REASONS, readMethod(), plan() (no-yield)", "output is a pure function of the input text -> scripts/codemod-split-sql-driver.mjs parse() (in-memory project, no lib, no node_modules), treeHash()", "no root dependency added; ts-morph comes from packages/cli's closure -> scripts/codemod-split-sql-driver.mjs loadTsMorph()", "every parse is checked -> scripts/codemod-split-sql-driver.mjs parse() calls ts-parse.mjs parseSourceFile first", "stubs keep docblock, modifiers and signature; only async dropped -> packages/drivers/driver-sql/src/sql-driver.ts, the 20 methods whose body opens with the [#29520 codemod] comment" ], "files_changed": [ "scripts/codemod-split-sql-driver.mjs (new, 1,343 lines)", "packages/drivers/driver-sql/src/sql-driver.ts (20 stubs + 20 import/comment lines)", "packages/drivers/driver-sql/src/sql-driver-{lifecycle,crud,sequence-semantics,bulk-operations,aggregation,managed-drift,filter-helpers,field-mapping,column-creation,database-helpers}.ts (new, generated)" ], "line_budget": "sql-driver.ts -108; package src +534 net (642 module lines in); script +1,343", "tests": "head 9414843b4a, after a rebuild of the driver-sql, driver-turso and driver-sqlite-wasm closures under one os-verify-lock hold (VERDICT command-exit 0): driver-sql typecheck exit 0; driver-sql test exit 0, 248 files (236 passed, 12 skipped), 4061 tests (3847 passed, 214 skipped); driver-turso test exit 0, 95 files, 2526 (2492/34); driver-sqlite-wasm test exit 0, 39 files, 746/746. Same counts as cut 21's base. codemod --self-test exit 0, 23 cases in 4 pinned batteries. No ablation: no tested behaviour changed. The 5 packages/cli pin tests that read sql-driver.ts by path: NOT MEASURED locally (the cli closure was not built, so import failed at @objectstack/lint/rule-explanations); every anchor they slice has an equal count at base and head, and none lies in a moved body; CI runs them.", "gates": "dispatch-gates --commands at 9414843b4a derives 65 families. Each was run alone, exit captured before any pipe: 63 exit 0; check:dual-build-cjs-loads and check:lean-entry-closure exit 3 (PREREQUISITE NOT MET: full pnpm build), NOT MEASURED, left to CI. --ran with exit codes: 65 derived, 63 run, 2 NOT-MEASURED (derived), 0 UNRUN, exit 0. check:parse-guard was red on the first script commit (raw createSourceFile) and fixed in ba014dfcb6. Hand gates exit 0: eslint --no-inline-config on the 12 files, check-adr-anchors (2221 decision-letter citations at base dbca3ef034 and head), check-adr-symbol-anchors, check-nul-bytes, check-commit-card-trailers --range main..HEAD (4 commits). check-tenant-chokepoint output byte-identical base vs head (24 bindings, 3 files). CI check-runs on #29598 not read at report time.", "dogfood_battery": "n/a: no ! in the PR title and no (narrowing) arm", "deviations": [ "no-yield is this script's own rule (a method stays when its stub would be no shorter than its body); without it the literal whole-section reading grows sql-driver.ts by 65 lines", "moved bodies are not re-indented (the hand series re-indented by hand) so byte-identity is plain equality; the functions keep the class's 4-space body indentation", "the merge of main is a plain git merge (no conflict: main had not touched packages/drivers) followed by regenerating from main's sql-driver.ts; the regenerated output was byte-identical to the committed split, so no generated file changed; the merge commit 9414843b4a carries git's default message and no trailer pair", "ruling 6348891160 item 3 forbade a scripts/ file for the normaliser on that series; ruling 6583399215 orders this script's own declaration check, so the normaliser lives in the script, unwired, no check: alias", "the script carries a --self-test that no workflow runs (it is not a gate; check-self-test-wired's population is scripts CI runs)", "5 cli pin tests and 2 derived families not measured locally (see tests, gates)" ], "mcp_calls": "0", "api_writes": "7: git push x5 to claude/issue-29520-sql-driver-codemod-pilot (empty-branch probe, then 939ace0245, 391768627d, ba014dfcb6, 9414843b4a); fleet-write relay pr_create x1 (POST dispatches 204, run 41521791640 success; #29598 draft, label skip-changeset, no assignees, no reviewers; body 11,849 bytes sent = stored); post-stamped comment x1 (this report on #29520). Reads went through gh api REST.", "open_questions": [ { "question": "Under the binding cut pattern the pilot moves 20/254 methods (-108 lines). What should happen to it?", "options": [ "A: land the pilot as-is in the maintainer's window (tooling proved, small yield) and re-run the script per file", "B: rule to admit value imports from sql-driver.ts plus export on its module-local helpers (an evaluation cycle the generated modules cannot trip, since they run no top-level code); upper bound 47 methods, 17,184 lines", "C: B plus widening check-tenant-chokepoint SCAN_FILES to the generated modules (a gate change); upper bound 69 methods, 15,925 lines", "D: report a fork on #29465 (the codemod cannot deliver a meaningful split under the series limits) and apply option B there" ], "recommendation": "seat's call; the measured ceiling stays low under every variant because docblocks stay on the class and 78 methods are already stubs" }, { "question": "Keep or strike the no-yield rule?", "options": ["keep: the file never grows", "strike: literal whole sections, 63 methods, file +65 lines"], "recommendation": "keep" } ], "security_findings": "none", "out_of_scope_findings": [ "carrier: #29520 (the seat) · noted, not filed (check-tenant-chokepoint SCAN_FILES lists sql-driver.ts and the two subclasses only, so any read door moved to a seam module leaves the gate; the codemod keeps every body carrying a chokepoint spelling on the class for that reason; widening SCAN_FILES is a gate change)" ] }objectstack-fleet commentedon Nov 2, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
席位读数 — HOLD, a decision is owed ·
domain:devx#2· head9414843b4a· 2026-11-02T20:47ZThe pilot's proofs pass, and its yield is what ruling 6583399215's confidence gap was worried about. The seat read the PR head, not only the report (6588050597).
--verifyexit 0 against two bases);index.d.ts/index.d.mtshash equal before and after; three runs give one output tree hash; driver-sql, driver-turso and driver-sqlite-wasm suites match the base counts. None of the order's stop conditions fired, so the draft PR refactor(driver-sql): codemod pilot — generated, byte-identity-proved section split of sql-driver.ts (#29520) #29598 stands.sql-driver.tsgoes from 18,333 to 18,225 lines at this head (the seat counted it), because the ruled cut pattern can move 20 ofSqlDriver's 254 methods:sql-driver.tsitself, and importing it from a section module is the evaluation cycle the host pattern forbids;check-tenant-chokepointlooks for, and that gate scans onlysql-driver.ts.These are the same seams that stopped the hand series at cut 21.
sql-driver.tsand exporting its local helpers moves about 47 methods (~17,184 lines); that plus wideningcheck-tenant-chokepointto the new modules (a gate change) moves about 69 (~15,925 lines).The ruling says 「若试点证明不可行，退回 B」. Whether 0.6% counts as "not feasible", or whether the cut pattern should be widened instead, changes the programme, so it goes to the maintainer. The PR stays a draft and nothing on #29465 changes until it is ruled. The card is held, not released.
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Ruling recorded · option A 「放宽切法并扩门禁扫描」 · 2026-11-03T00:07Z
issue-29520/decision-analysis.md§五), and it amends ruling 6583399215's cut pattern for this programme.sql-driver.ts, and the top-level helpers it uses gainexport. This matches the hand series' precedent: 5 of the 11sql-driver-*.tsmodules already do it.index.tsre-exports by name, so these exports do not reach the.d.ts. (b) The class's out-of-class top-level helpers (theconst/function/interface/typedeclarations ahead of the class, about 4,252 lines) may move whole into leaf modules, and a leaf module never imports back fromsql-driver.ts.check-tenant-chokepoint'sSCAN_FILESwidens topackages/drivers/driver-sql/src/sql-driver-*.ts(non-test files), in this PR. The gate's readings at the base and at the new head must be equal: read doors, tenant predicates and D8 arms.sql-driver.tsends below 13,000 lines. If it cannot, a fork is reported on [Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465, and that fork goes back for a design ruling (docblock ownership or class decomposition), not to B.main, with no hand edit to generated output. The proofs stay: byte-identity, the declaration bar of ruling 6348891160, determinism, and the three driver suites. Lever (b)'s effect on the order of the bundled.d.tsis measured. If it changes only the order, that is reported for a separate ruling on the criterion, not passed or failed by the seat. The diff will exceed 3,000 lines, so it lands with the four-piece set and the maintainer's approval, in the window the maintainer names.claude/issue-29520-sql-driver-codemod-pilot.objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": 2, "status": "done-bar-not-met", "branch": "claude/issue-29520-sql-driver-codemod-pilot", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598", "head": "94bd4c0e83", "base": "origin/main 2ea604223a (merged, not rebased; the split regenerated on it)", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "order": "29520-r2 (ruling 6591753301, option A)", "summary": "Round 2 applies option A's widened cut pattern. Lever (a): section modules import four staying helpers from sql-driver.ts. Lever (b): 96 of 129 top-level declarations move whole into the leaf sql-driver-top-level.ts, which never imports back. check-tenant-chokepoint SCAN_FILES now covers every non-test sql-driver-*.ts, and its readings are equal at base and head. Every proof passes except two. First, the pass bar is NOT met: sql-driver.ts goes 18,330 -> 14,050, above 13,000. Per the order, nothing new was opened and no hand slices were made. The fork is reported below with measured numbers. Second, the bundled .d.ts differs only in order plus one blank line. That was not decided and is reported with the diff for a ruling.", "lines": { "before": 18330, "after": 14050, "bar": "below 13,000: NOT MET", "leaf": "sql-driver-top-level.ts 2,406 lines", "new_files": "19 new files, 7,947 lines", "changed_lines": "13,589 (+8,697 / -4,892, 22 files), over the 3,000 human-merge threshold; the PR stays draft" }, "moved_methods": { "count": "54 of 254, into 18 modules (2,596 body lines out, 616 stub lines in, 36 import lines)", "by_module": [ "sql-driver-lifecycle.ts (1): connect", "sql-driver-crud.ts (3): create, readBackInsertedRows, sequenceKeyHash", "sql-driver-sequence-semantics.ts (7): defineSequencesTable, autoNumberValueExists, autoNumberCounterKey, update, assertMergeLandedOnSuppliedIdentity, assertMergeLandedInWrittenOrganization, upsert", "sql-driver-bulk-operations.ts (5): bulkCreate, bulkUpdate, updateMany, rotatedUpdateById, count", "sql-driver-aggregation.ts (2): aggregate, foldEmptyAggregateAnswers", "sql-driver-distinct.ts (1): distinct", "sql-driver-window-functions.ts (1): findWithWindowFunctions", "sql-driver-query-plan.ts (1): analyzeQuery", "sql-driver-schema-sync-section.ts (1): reclaimSpace", "sql-driver-rotation.ts (2): computeTenantField, registerManagedObjectMetadata", "sql-driver-managed-drift.ts (5): isProductionEnv, probeNullSafeUniqueDuplicates, buildRebuiltColumn, dropIndexIfExists, syncTableIndexes", "sql-driver-internal-helpers.ts (3): applyTenantScope, injectTenantOnInsert, auditMissingTenant", "sql-driver-filter-helpers.ts (12): tableNameForBuilder, toDateOnly, coerceFilterValue, sqliteCanonicalDatetimeSql, sqliteNonTemporalTextSql, sqliteCanonicalTimeSql, readPresentationKind, presentReadValue, presentReadColumns, filterColumnExpr, logWithheldFilterDiagnostic, compileFilters", "sql-driver-field-mapping.ts (3): mapSortField, orderKeysFor, mapAggregateFunc", "sql-driver-window-function-builder.ts (1): buildWindowFunction", "sql-driver-column-creation.ts (3): decorateHashShadowDuplicate, schemaBytesPerChar, rethrowWithRowSizeExplanation", "sql-driver-database-helpers.ts (1): sqliteFilename", "sql-driver-sqlite-serialisation.ts (2): formatInput, formatOutput" ] }, "method_stay_reasons": "already-moved 78, no-yield 55, non-public-static 47, parameter-shape 21, this-write 19, path-reader 18, no-section 14, static 11, comment-in-parameters 7, field-call 6, inferred-return-type 6, type-parameters 3, name-taken 3, reserved-name 1", "moved_top_level": { "count": "96 of 129 (2,225 lines with their docblocks), base order, leading trivia included", "names": "PRE_DDL_QUESTION_SCOPE, uniqueProbeNotNullClause, DEFAULT_ID_LENGTH, OWN_STATEMENT_FAULT, SQL_IDENTIFIER, INDEX_DDL_PREFIX, CREATE_INDEX_DDL, DROP_INDEX_DDL, unquoteSqlIdentifier, lastIdentifierSegment, SEQUENCES_TABLE, AUTONUMBER_COLLISION_RETRIES, AutoNumberReservation, NUMERIC_SCALAR_TYPES, AUDIT_TIMESTAMP_COLUMNS, MYSQL_DATETIME_PRECISION, repairNaiveUtcAuditTimestamp, isoFromValidDate, presentAuditTimestampOutput, isNowDefaultValue, normalizeSqliteDatetimeOutput, canonicalUtcDatetime, mysqlDatetimeLiteral, canonicalTimeOfDay, SQLITE_TIME_EXPR_REFS, SQLITE_NON_TEMPORAL_TEXT_REFS, isUnresolvableColumnError, rawStatementFaultError, insertedRowsNotReadBackError, LOCK_WAIT_REFUSAL, isDeferredDdlLockWaitRefusal, WITHHELD_FILTER_DIAGNOSTIC, WITHHELD_FILTER_LOGGED, WITHHELD_FILTER_SUBTREE, WITHHELD_FILTER_AUTHOR_TEXT, withheldFilterDiagnosticOf, refusalSubtree, SqlAggregateLowering, SQL_AGGREGATE_FUNCTIONS, DECLARED_AGGREGATE_FUNCTIONS, undeclaredAggregateFunctionError, uncompilableAggregateFunctionError, unsupportedAggregationFilterError, refuseDistinctAggregateWithoutField, refuseAggregateFunction, SQL_WINDOW_FUNCTIONS, SQL_WINDOW_SORT_DIRECTIONS, invalidWindowFunctionQueryError, refuseDateBucketedGroupBy, refuseRejectedReferenceAlias, isDeclaredFieldType, isMultiValuedColumn, declaredValueShapes, declaresColumnNotNull, refuseUndeclaredFieldType, refuseUnbackedConflictTarget, ConflictTargetVerdict, refuseCrossRowIdentityMerge, UPSERT_UNIQUE_VIOLATION_CODE, UPSERT_UNIQUE_VIOLATION_STATUS, refuseUpsertConflictOutsideWrittenOrganization, isUpsertFenceRefusal, SUPPORTED_FILTER_OPERATORS_SENTENCE, fieldReferenceOf, NowAnchor, nowAnchorOf, CROSS_FIELD_COMPARISON_OPERATORS, SCALAR_COMPARAND_OPERATORS, isBindableComparand, TEXT_PATTERN_OPERATORS, LIKE_PATTERN_OPERATORS, TEXT_OPERATORS, isRenderableTextComparand, safeShapePreview, TextMatchShape, LIKE_ESCAPE_CHARACTER, FilterVerdict, isFilterNode, describeFilterOperand, isEmptyFieldConstraint, nonBooleanFlagWithheldMessage, postgresTableNameCollisionError, IntrospectedColumn, IntrospectedForeignKey, IntrospectedTable, IntrospectedSchema, SqlWindowFunctionSpec, SqlWindowFunctionQuery, ReadPresentationKind, SqliteJournalMode, SqliteAbsentFileMode, resolveSqliteAbsentFileTarget, SqlDriverConfig, RowWidthContribution, BetterSqlite3Connection, reclaimBetterSqlite3" }, "staying_top_level": { "count": "33: path-reader 29, needs-stayer 6 (one declaration can carry both)", "each": [ "JSON_COLUMN_TYPES (35) — path-reader: \"...STRUCTURED_JSON_TYPES, ...MULTI_OPTION_TYPES,\"", "MEDIA_ID_VARCHAR_CHARS (16) — path-reader: \"const MEDIA_ID_VARCHAR_CHARS = \"", "unsupportedFilterError (85) — path-reader: \"unsupportedFilterError(\"; path-reader: \".INVALID_FILTER\"", "withheldFilterError (63) — path-reader: \"unsupportedFilterError(\"; path-reader: \"withheldFilterError(\"", "filterArrayReachedDriverError (44) — path-reader: \"withheldFilterError(\"", "retiredFilterOperatorError (53) — path-reader: \"withheldFilterError(\"", "unsupportedFilterOperatorError (17) — path-reader: \"withheldFilterError(\"", "icontainsComparandError (34) — path-reader: \"withheldFilterError(\"", "likePatternComparandError (37) — path-reader: \"withheldFilterError(\"", "danglingLikeEscapeError (36) — path-reader: \"withheldFilterError(\"", "nulLikePatternError (39) — path-reader: \"withheldFilterError(\"", "nowAnchorPositionError (26) — path-reader: \"withheldFilterError(\"", "crossFieldComparisonError (60) — path-reader: \"withheldFilterError(\"", "bareFieldReferenceError (53) — path-reader: \"withheldFilterError(\"", "assertCompilableComparand (105) — needs-stayer: crossFieldComparisonError", "unbindableComparandError (35) — path-reader: \"withheldFilterError(\"", "betweenArityError (23) — path-reader: \"withheldFilterError(\"", "unbindableListMemberError (42) — path-reader: \"withheldFilterError(\"", "unrenderableTextComparandError (44) — path-reader: \"withheldFilterError(\"", "jsonColumnOperatorError (54) — path-reader: \"withheldFilterError(\"", "assertFilterNode (38) — path-reader: \"withheldFilterError(\"", "emptyFieldConstraintError (38) — path-reader: \"withheldFilterError(\"", "unknownLogicalOperatorError (54) — path-reader: \"withheldFilterError(\"", "nonBooleanExistsComparandError (79) — path-reader: \"withheldFilterError(\"", "nonBooleanNullComparandError (19) — path-reader: \"withheldFilterError(\"", "nonBooleanEmptyComparandError (28) — path-reader: \"withheldFilterError(\"", "undefinedComparandError (81) — path-reader: \"withheldFilterError(\"", "assertDefinedComparands (50) — needs-stayer: undefinedComparandError", "assertFilterNodeList (28) — path-reader: \"withheldFilterError(\"", "reduceFilterNode (37) — needs-stayer: sqlFilterVerdictHooks", "reduceFilterKey (7) — needs-stayer: sqlFilterVerdictHooks", "sqlFilterVerdictHooks (56) — needs-stayer: assertFilterNodeList", "classifyFilterKey (194) — needs-stayer: unknownLogicalOperatorError" ] }, "lever_a": "export { assertCompilableComparand, assertDefinedComparands, emptyFieldConstraintError, filterArrayReachedDriverError } generated in sql-driver.ts. None reaches the bundled .d.ts: its export list is 92 = 92. 45 leaf names are exported beside the base exports for sql-driver.ts and the section modules.", "chokepoint_readings": { "base": "2ea604223a, widened gate: 24 getBuilder() bindings, 21 read doors, 3 insert builders, 4 tenant predicates, 0 D8 arms across 14 files", "head": "94bd4c0e83: 24 bindings, 21 read doors, 3 inserts, 4 predicates, 0 D8 arms across 33 files", "per_door_lists": "identical", "gate_changes": "SCAN_FILES = 3 named files + every non-test sql-driver-*.ts (directory listed inside SCAN_FILES); analyzeSource visits top-level function declarations; readings line printed; DECLARED_WATCH_HINTS names the 30 seam modules file-exactly (a glob would also cover the 232 sql-driver-*.test.ts files); self-test battery 'moved bodies (#29520)': 9, battery floor 2 -> 3; not narrowed" }, "byte_identity": "--verify --base 2ea604223a exit 0: 54/54 moved bodies (body, parameters, return type, async) and 96/96 moved top-level declarations (leading comments included) identical to base; undoing the split rebuilds base sql-driver.ts byte-for-byte; the leaf's relative imports, followed on disk, never reach ./sql-driver", "declaration_bar": "--dts dist-before (2ea604223a unsplit src) dist-head: FAIL (4). index.d.ts and index.d.mts both: base 0f33bf3febaac3c7aa96f68a4226d752766b8203ab7acade523b69f9aaa44d74, head 69d9162d74bcb294d6ba14bfd569e90a47785317fe919fe9964668bf51c051bb (raw = normalised at both); 8,847 -> 8,848 lines; normalised hashes differ. Export names 92 = 92; runtime CJS 59 = 59, ESM 59 = 59, CJS = ESM.", "dts_order": { "verdict": "order plus one blank line; for a ruling, not decided", "diff": [ "two import lines reorder their specifiers: @objectstack/spec/data puts SchemaMode first; @objectstack/spec/contracts has DriverQuery, IDataDriver instead of IDataDriver, DriverQuery", "the @objectstack/spec/contracts import line moves from line 2 to line 3", "the 'SQL Driver for ObjectStack' file-header docblock (5 lines) moves from before base line 1012 to before declare class SqlDriver", "one extra blank line (8,847 -> 8,848)" ], "unchanged": "with blank lines dropped, the multiset of lines is equal except the two reordered import lines; no declaration, member or type text changes" }, "determinism": "output tree sha256 ab8990700a0d626e50782a59f12e52490988c02a80c49a9d7f19651d13bf7103 on three runs: --write in the worktree, and two plan runs on a fresh extract of 2ea604223a; input sha256 9abf7867fd9823f2642e67d36b4ccd61404a7821e61b59bd84dbc969cd66957e", "suites": "under os-verify-lock (VERDICT command-exit 0). Base = 2ea604223a unsplit src, built and restored in place (status clean afterwards); head = 94bd4c0e83. driver-sql: 249 files (237 passed, 12 skipped), 4067 tests (3851 passed, 216 skipped) at both. driver-turso: 96 files, 2530 tests (2496 passed, 34 skipped) at both. driver-sqlite-wasm: 40 files, 750/750 at both. Typecheck exit 0 for driver-sql, driver-turso and driver-sqlite-wasm. cli pins all exit 0: unit (builtin-id-column, field-type-vocabulary, file-reference-width, multiple-json-column) 4 files / 62 tests; integration (string-family-width) 1 file / 30 tests. codemod --self-test 40 cases, 5 batteries, exit 0.", "gates": "dispatch-gates --commands at 94bd4c0e83 derives 67 families. Each was run alone, exit captured before any pipe: 67 exit 0. That includes check:dual-build-cjs-loads and check:lean-entry-closure, measured after a full build this time. --ran: 67 derived, 67 run, 0 NOT-MEASURED, exit 0. Extras exit 0: codemod --self-test and --verify; check-tenant-chokepoint --self-test and main; check-settings-deny-roster --self-test and main (the one other script that reads the chokepoint gate); check:adr-anchors; check:adr-symbol-anchors; check-nul-bytes. The derived set carries check:tenant-chokepoint, check:watch-hint-literal and bare-root-worklist --self-test. eslint --no-inline-config on the 22 changed files exit 0. check:commit-card-trailers passed on every push.", "deviations": [ "the bar is not met (14,050 >= 13,000): nothing new opened, no hand slices", "full pnpm build exits 2 in @object-ui/app-shell (Cannot find module '@object-ui/mobile'), 115 of 116 tasks pass; unrelated to this card; every driver and cli closure used here builds", "the stub host passes getBuilder bound (BOUND_HOST_METHODS); a forwarding closure is the inline-unbound-getBuilder shape the chokepoint gate refuses", "path-reader needle 'this.runWideningAlters(' keeps the two MySQL widening bodies in sql-driver.ts: check:durability-log-level resolves logDurabilityFailure per file", "the in-package logger-receiver-detach test scans sql-driver.ts only; the repo-wide check:logger-receiver-detach covers the moved bodies and passes", "kept from round 1: no-yield rule, no re-indentation, normaliser in the script", "two merges of origin/main this round (4f6d088d6c, 272bd65245); the second took main's driver-sql src (#29660 had touched sql-driver.ts), then the split was regenerated" ], "open_questions": [ { "question": "The 13,000 bar is not met under the authorized pattern (14,050). Which way does the fork go?", "options": [ "A: allow adding sql-driver-top-level.ts to the sources list of sql-driver-compile-refusal-seam.test.ts (as cuts 13/15/16 did for their modules); measured, not applied: 127/129 top-level declarations move, sql-driver.ts 12,456 lines, byte-identity 54/54 and 127/127", "B: a design ruling on the remaining stay mass: non-public-static 47 methods (about 834 sole-reason lines), no-yield 55, already-moved 78", "C: land at 14,050 as is" ] }, { "question": "The bundled .d.ts differs only in import specifier order, import line order, the file-header docblock's position and one blank line. Is that inside the declaration bar of ruling 6348891160 item 1?", "options": [ "inside: land as is", "outside: the leaf must keep base .d.ts order" ] } ], "mcp_calls": "0 (no GitHub MCP tool used)", "api_writes": "7 this round: git push x5 to claude/issue-29520-sql-driver-codemod-pilot (4f6d088d6c, 20f49a9da0, db0a766dfe, 5e2cef71b6, 94bd4c0e83); fleet-write relay issue_patch x1 on #29598 (run 41573654996 success; 13,796 bytes sent = stored; PR still draft); post-stamped comment x1 (this report). Reads went through gh api REST." }objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
席位读数 — HOLD, two rulings owed ·
domain:devx#2· head94bd4c0e83· 2026-11-03T03:44ZThe seat read the head, not only the round-2 report (6594883159).
sql-driver.tsis 14,050 lines at this head (counted), against the ruling's bar of below 13,000 (6591753301). The proofs hold: 54/54 bodies and 96/96 top-level declarations byte-identical, one tree hash over three runs, chokepoint readings equal at base and head over the widened scan, and suites at base counts. Two points go back to the maintainer, as the ruling requires:sql-driver-compile-refusal-seam.test.ts. It readssql-driver.tsby path and names the refusal-builder callers, which pins 29 builders and 6 dependent declarations in place. Adding the new leaf to that test'ssourceslist, as hand cuts 13, 15 and 16 did for their modules, takes the file to 12,456 (the dev measured this and did not apply it, because it edits a test). The alternatives are a design ruling on the other stayers (non-public-static47 methods,no-yield55,already-moved78), or landing at 14,050..d.tsorder. Lever (b) changes only the order of the bundledindex.d.ts. The specifiers inside two@objectstack/specimport lines are reordered, the contracts import moves down one line, the package header docblock moves to just beforedeclare class SqlDriver, and there is one extra blank line. No declaration text changes, and the export lists are equal (92 = 92; runtime CJS 59 = 59, ESM 59 = 59). Ruling 6348891160's bar compares hashes, so it reads FAIL. Under the ruling, this is reported for a ruling on the criterion. The seat does not pass or fail it.PR #29598 stays a draft, and nothing is hand-edited.
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Maintainer ruling recorded, round 2 ·
domain:devx#2· 2026-11-03T07:03ZThe maintainer, on the project's decision card, question 「sql-driver 第二轮 14,050 行未过线，测试清单和 .d.ts 顺序怎么定？」, picked option A, 「清单加叶子，.d.ts 按既有裁定」. The card's stated consequence: 「测试 sources 加 sql-driver-top-level.ts（同第 13/15/16 刀），重生成到约 12,456 行；.d.ts 顺序差按 6441032442 判通过，包头注释位置不计。」 This was a platform-recorded pick, so the label and the consequence are the maintainer's words. It answers the seat's HOLD 6594907028.
What round 3 executes:
sql-driver-compile-refusal-seam.test.tsgainssql-driver-top-level.tsin itssources, commented[#29520 codemod]in the same form as hand cuts 13, 15 and 16. The codemod'sPATH_READER_NEEDLESdrops the three needles that line answered. Then regenerate; the expected result is about 12,456 lines, under the 13,000 bar. This migrates a test that reads a file by path ([maintainer] refactor(driver-sql): splitsrc/sql-driver.ts(22,096 lines, +2,533 in 30 days) along itsSqlDriverseams, one move-only slice per PR #25521 ask 3). It is not a hand edit of generated output..d.tsorder. Judge it by ruling 6441032442 B's second normalisation. After sorting top-level statements and import/export specifiers and masking chunk hashes, the files must be byte-identical. The declared-surface digest, the statement multiset and the export set must be equal. The positive control must catch a droppedprivate. A file-level header docblock moving to precede a different statement does not count as a difference. Report all four readings..d.tsorder-only difference is judged by 6441032442.Unchanged: PR #29598 stays a draft and nothing is hand-edited. Over 3,000 lines it takes the four-piece hand-off and a maintainer approval, and it lands in the window the maintainer sets.
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": 3, "status": "done", "ruling": "6597555122 (maintainer pick A: the test's sources gain the leaf; the .d.ts is judged by 6441032442 B with the header-position clarification)", "branch": "claude/issue-29520-sql-driver-codemod-pilot", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; ready state, reviewers and labels untouched)", "head": "d23e3c0d06", "base": "origin/main 7a25b39cf9, merged, not rebased; its sql-driver.ts is the same blob as round 2's base 2ea604223a (sha256 9abf7867fd98...)", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "summary": "The bar is met: sql-driver.ts 18,330 -> 12,456 lines (wc -l). sql-driver-compile-refusal-seam.test.ts gains sql-driver-top-level.ts in its sources, under a [#29520 codemod] comment in the form of hand cuts 13/15/16. The codemod's three seam-test needles leave PATH_READER_NEEDLES for CLASS_PATH_READER_NEEDLES, so a top-level declaration carrying one moves to the leaf, which the test now reads, while a method carrying one still stays. Then the split was regenerated, unedited. The .d.ts passes ruling 6441032442 B's second normalisation on all four readings, and the positive control catches a dropped private. Every round-2 proof holds.", "implementation_note": "The order says to drop the three needles. Dropped outright, they would also free the method SqlDriver.resolveWithheldFilterRefusal. It would move to sql-driver-filter-helpers.ts, which the test does not read, and the test pins that name in its direct-caller set. Measured: 55 methods, 12,449 lines, and the enumeration goes red. So the three rows are scoped instead: they bind methods only. The top-level result is exactly the ruled variant: 127/129 declarations, 12,456 lines, tree hash f5d8722f... equal to round 2's measured variant.", "lines": { "before": 18330, "after": 12456, "bar": "below 13,000: MET", "leaf": "sql-driver-top-level.ts 3,999 lines", "new_files": "19 files, 9,575 lines", "changed_lines": "16,903 (+10,373 / -6,530, 23 files)" }, "moved": { "methods": "54 of 254 into 18 modules, the same 54 as round 2", "top_level": "127 of 129 (3,784 lines with docblocks); the 2 that stay are both path-reader: JSON_COLUMN_TYPES and MEDIA_ID_VARCHAR_CHARS (cli pins)", "lever_a": "0 staying names exported now; every helper the moved bodies read sits in the leaf" }, "test_change": "sources += ['sql-driver-top-level.ts', readFileSync(new URL('./sql-driver-top-level.ts', import.meta.url), 'utf8')], with the comment '[#29520 codemod] The top-level declarations ahead of the class moved to a generated leaf, with the refusal builders among them; the scan reads it too.' The enumeration prose also names the leaf. Ablation at head: without the line, 3 of 115 fail (the positive control and both enumeration sets); with it, 115/115 pass.", "codemod_change": "CLASS_PATH_READER_NEEDLES = { 'unsupportedFilterError(', 'withheldFilterError(', '.INVALID_FILTER' }, checked in readMethod only. A stale row refuses. --self-test: 43 cases in 5 pinned batteries (stay rules 12, top-level moves 11, refusals 4). Each of two mutants is refused with 2 failures: removing the method rule, and applying the rows to top-level declarations.", "byte_identity": "--verify --base 7a25b39cf9 exit 0: 54/54 moved bodies and 127/127 moved top-level declarations are identical to base; undoing the split rebuilds base sql-driver.ts byte-for-byte", "determinism": "output tree sha256 f5d8722fa697b4530b9f76922c2b5d579f69048463e09cf190693793400b26e0 on three runs: --write in the worktree and two plan runs on a fresh extract of main; input sha256 9abf7867fd9823f2642e67d36b4ccd61404a7821e61b59bd84dbc969cd66957e", "chokepoint_readings": { "base": "main, head's widened gate: 24 getBuilder() bindings, 21 read doors, 3 insert builders, 4 tenant predicates, 0 D8 arms across 14 files", "head": "d23e3c0d06: the same counts across 33 files", "per_door_lists": "byte-identical (25 lines)" }, "dts": { "normaliser": "dtsnorm.mjs, sha256 9e3ca459fb22015c7e77e4576b564ca46076cfd0f366dc00dcec521274f8e911, at /tmp/claude-0/-home-claude/cf62d71a-d2cf-598c-b2f9-9b5abc24174a/scratchpad/issue-29520/dtsnorm/dtsnorm.mjs. Rewritten from ruling 6441032442's text, because the original lives in another project's files. Not in scripts/, no CI step, no check: alias. This dev cannot write the project files; the seat may copy it there.", "method": "top-level statements via the TypeScript API, each with its attached comments byte for byte; a leading comment separated by a blank line is detached (a file header), removed from the stream and compared as its own multiset; statements sorted; import { } / export { } specifier lists sorted; chunk hashes masked (driver-sql emits no chunk)", "files": "index.d.ts and index.d.mts, identical readings (the head .d.ts and .d.mts are byte-identical to each other, as at base)", "raw": "base 0f33bf3febaac3c7aa96f68a4226d752766b8203ab7acade523b69f9aaa44d74, head 69d9162d74bcb294d6ba14bfd569e90a47785317fe919fe9964668bf51c051bb; raw diff 19 lines; wc -l 8,846 -> 8,847; the same raw diff as round 2", "normalised_bytes_identical": "YES: 468260520fcc1ac2c5a3daac8b952afcce83bdfa28fc8ab608133e70c32229dd at both", "declared_surface_digest_equal": "YES: 50e5e5be3c1d37d9aa25dcb8de221f9819ff699f895893a7be98dcdd71a7c507 at both (100 top-level declarations, 585 surface lines)", "statement_multiset_equal": "YES: 106 / 106, only in base 0, only in head 0 (before the specifier sort 2 / 2: the two @objectstack/spec imports whose specifier order changed)", "export_set_equal": "YES: 92 = 92; import specifier set 17 = 17; runtime CJS 59 = 59, ESM 59 = 59, CJS = ESM", "detached_comments": "2 = 2, equal texts; the 'SQL Driver for ObjectStack' header now precedes declare class SqlDriver, which ruling 6597555122 does not count", "positive_control": "`private` dropped from the moved member compileFilters's stub (1 site, a 2-line diff), driver-sql rebuilt, normaliser run head vs control: normalised 468260520fcc... vs 73e89389695f...; surface digest 50e5e5be3c1d... vs acf70f0378d0..., naming 'PropertyDeclaration [private] compileFilters' -> 'MethodDeclaration [] compileFilters'; statement multiset 1 / 1; exit 1 on both files. Restored afterwards (status clean); the rebuilt head .d.ts is byte-identical to the measured head. The normaliser's --self-test passes 8 cases, including a member reordered inside its class (refused) and a changed header text (refused).", "union_order_bar": "ruling 6348891160's bar alone still reads FAIL here (line count, normalised hash); under 6441032442 item 1 that is the case where the second normalisation applies", "premises": "P1 holds (above); P2: driver-sql exports '.' only, naming dist/index.*, no chunk; P3: git grep 'driver-sql/dist' -- scripts package.json, 0 hits; (e) driver-turso and driver-sqlite-wasm typecheck and suites ran against the head dist" }, "suites": "one os-verify-lock hold, VERDICT command-exit 0. Base = main's unsplit src, built and restored in place (status clean); head = d23e3c0d06. driver-sql: 249 files (237 passed, 12 skipped), 4067 tests (3851 passed, 216 skipped) at both. driver-turso: 96 files, 2530 tests (2496 passed, 34 skipped) at both. driver-sqlite-wasm: 40 files, 750/750 at both. Typecheck exits 0 for all three. cli pins all exit 0: 4 unit files / 62 tests, 1 integration file / 30 tests.", "gates": "dispatch-gates --commands at d23e3c0d06 derives 73 families; each run alone, exit captured before any pipe: 73 exit 0. --ran: 73 derived, 73 run, 0 NOT-MEASURED, exit 0, with a STALE TREE warning: main moved 20 commits after this round's merge, changing 5 scripts/pm and test-shard files the derivation reads, and nothing under packages/drivers, packages/cli/src/commands or the two scripts this PR changes. 10 extras exit 0: codemod --self-test and --verify; chokepoint --self-test and main; deny-roster --self-test and main; check:adr-anchors; check:adr-symbol-anchors; check-nul-bytes; the seam test alone. eslint --no-inline-config on the changed files exit 0. check:commit-card-trailers passed on the push.", "deviations": [ "the three needles are scoped to methods, not deleted (implementation_note)", "full pnpm build exits 2 in @object-ui/app-shell (Cannot find module '@object-ui/mobile'), 115 of 116 tasks pass; outside this change", "the normaliser is kept at the dev's scratchpad path, because the dev cannot write the project files" ], "open_questions": [], "mcp_calls": "0 (no GitHub MCP tool used)", "api_writes": "3 this round: git push x1 (94bd4c0e83..d23e3c0d06: merge 09d860321e, 2773c17c55, d23e3c0d06); fleet-write relay issue_patch x1 on #29598 (run 41601105864 success; 12,733 bytes sent = stored; still draft; labels size/xl, tests, skip-changeset untouched; no reviewers); post-stamped comment x1 (this report). Reads went through gh api REST." }fix(spec): re-point the liveness anchor for unsupportedAggregationFil…
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": "3, addendum (CI red: liveness anchor)", "status": "done", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; body, ready state, reviewers and labels untouched)", "head": "a92c230e41", "previous_head": "d23e3c0d06", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "cause": "The codemod moved the top-level declaration unsupportedAggregationFilterError from sql-driver.ts to sql-driver-top-level.ts:1147. packages/spec/liveness/query.json cites it by path#symbol for query/aggregations.filter. The liveness anchor check is a whole-word text match in the cited file, and sql-driver.ts no longer names the symbol at all, so check-liveness.test.ts failed (25 of 74 in CI Test Core 2/8).", "fix": "query.json: that one citation now reads packages/drivers/driver-sql/src/sql-driver-top-level.ts#unsupportedAggregationFilterError, per ruling 6597555122 point 3. A 1-line diff, nothing else in the ledger. Commit a92c230e41, trailer pair only.", "other_driver_sql_anchors": { "summary": "14 citations, 10 distinct symbols across field.json, object.json and query.json. The 9 others all still resolve in sql-driver.ts at head; none re-pointed.", "body_still_in_sql-driver.ts": [ "applyFilters", "findRows (5 citations)", "initObjects", "syncDeclaredIndexes", "uniqueIndexesFromFields" ], "stub_in_sql-driver.ts_body_moved_by_this_PR": [ "computeTenantField -> sql-driver-rotation.ts", "registerManagedObjectMetadata -> sql-driver-rotation.ts", "orderKeysFor -> sql-driver-field-mapping.ts", "syncTableIndexes -> sql-driver-managed-drift.ts" ], "note": "The four stubs keep the method name, docblock and signature on the class, so each anchor resolves to the method that consumers call. The prose of those evidence strings quotes the body, which now lives in the section module. Re-pointing them is not needed for any check. It would be a wording choice for the seat, not done here.", "outside_liveness": "26 other sql-driver.ts#symbol citations (ADRs, QA checklist areas, CHANGELOGs, scripts/check-object-def-param-keys.mjs): every symbol is still named in sql-driver.ts at head. The moved exported types are re-exported there by name." }, "runs": { "check-liveness.test.ts": "cd packages/spec && npx vitest run scripts/liveness/check-liveness.test.ts: exit 0, 74/74", "check:liveness": "pnpm --filter @objectstack/spec run check:liveness (tsx scripts/liveness/check-liveness.mts): exit 0; symbol anchors 1388 written, 1388 resolving; key-mention 1170 pairs, 1156 anchored, 14 exempt", "gates": "dispatch-gates --commands at a92c230e41 derives 83 families, the 73 of d23e3c0d06 plus 10 that the packages/spec change adds. The 10 new ones exit 0 under the lock: adr-0087-registration base and self-test, dev-prereqs self-test, spec check:empty-state, check:liveness, check:strictness-ledger, check:variant-docs, changeset-gate-self-tests, merge-driver, platform-checklist. The other 73 exits are from d23e3c0d06; the only change since is query.json. --ran: 83 derived, 83 run, 0 NOT-MEASURED, 0 UNRUN, exit 0 (STALE TREE warning as before: main is 22 commits ahead, with no driver-sql or spec/liveness change).", "why_missed": "The spec test suite is a CI test shard (Test Core), outside the derived families. dispatch-gates names CI jobs outside its derived total, and the d23e3c0d06 change set did not touch packages/spec, so no spec family was derived." }, "question_4_should_the_codemod_learn_liveness_anchors": { "answer": "Yes, as a narrow read. Only path#symbol anchors whose symbol is a top-level declaration of the host file can break, because lever (b) moves those to a leaf. A method anchor resolves to its stub, and a type the host re-exports by name still resolves. The scan would list each liveness path#symbol whose symbol is a top-level mover, and either re-point it in the same PR (ruling 6597555122 point 3) or refuse with the list. It would not be a new stay reason, since the ruling says readers follow the module.", "measured_at_main_7a25b39cf9": { "packages/drivers/driver-sql/src/sql-driver.ts": "14 anchors / 10 symbols: 13 class member, 1 top-level (unsupportedAggregationFilterError, the one that broke)", "packages/objectql/src/engine.ts": "54 anchors / 22 symbols: 49 class member, 5 top-level (ENGINE_QUERY_SLOTS, METADATA_ARRAY_KEYS, foldEngineOptionAliases, planFormulaProjection, resolveMetadataItemName), 17 file-only", "packages/metadata-protocol/src/protocol.ts": "11 anchors / 10 symbols: all class members, 6 file-only; 0 top-level at risk", "packages/objectql/src/registry.ts": "23 anchors / 9 symbols: 20 class member, 2 top-level (applySystemFields x2), 1 class name", "packages/spec/src/conversions/registry.ts": "0 anchors, 1 file-only citation", "packages/services/service-automation/src/engine.ts": "22 anchors / 9 symbols: 20 class member, 2 class name; 0 top-level" }, "other_failure_mode": "The file-level key-mention check (does the cited file mention the key?) can also break when moved bodies take the key's only mention out of the host. It did not break here: 1156 anchored, 14 exempt at head.", "readers_beyond_liveness": "ADR symbol anchors (check:adr-symbol-anchors, already among the derived gates and green) and the QA checklist areas cite path#symbol too. A codemod read should take the same anchor regex across those surfaces, not only liveness.", "tool": "the measuring script is /tmp/claude-0/-home-claude/cf62d71a-d2cf-598c-b2f9-9b5abc24174a/scratchpad/issue-29520/an/anchors-kind.mjs; output in r7-anchor-measure.txt beside it" }, "mcp_calls": "0", "api_writes": "2 for this addendum: git push x1 (d23e3c0d06..a92c230e41); post-stamped comment x1 (this). The PR body was not touched." }test(driver-sql): the receiver-detach pin reads every module split ou…
fix(scripts): codemod --help answers on a split tree; --dts counts a …
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": "3, addendum 2 (review: silent narrowing of an absence pin)", "status": "done", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; body, ready state, reviewers and labels untouched)", "head": "e2723ad825", "previous_head": "a92c230e41", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "fix_1_pin3": { "commit": "6cc535d2be", "what": "logger-receiver-detach.test.ts pin 3 now lists its own directory and reads every non-test sql-driver*.ts, the host included, under a [#29520 codemod] comment. A new floor case requires that the listing finds sql-driver.ts and at least one module beside it.", "why_a_listing_not_a_named_list": "The codemod is re-run on each newer main, and which modules it writes depends on what moves there. A named list would rot at the next regeneration. The pin asserts an absence, so a file it stopped reading would keep it green while it checked less. A listing follows the split. Reading more can only make an absence pin stricter, never looser.", "count": "Log-channel calls the pin reads (the test's own LOG_CHANNELS / LOG_SINK): old pin at base, host only, 21 (warn 18); old pin at head, 18 (warn 15), so 3 moved. New pin: 55 (warn 44) at base over 12 files and 55 (warn 44) at head over 31 files. Host 18 + the 3 moved = the base host's 21. The review counted 23 -> 20; this count differs, but the delta of 3 and the three files are the same.", "ablation": "Planted (this.logger.error ?? this.logger.warn)( at sql-driver-internal-helpers.ts:118. The new pin fails 1 of 12, naming 'sql-driver-internal-helpers.ts parenthesized-callee @118'. The old host-only pin, run on the same planted tree, passes 11/11. Reverted, status clean." }, "fix_2_codemod": { "commit": "e2723ad825", "help": "--help / -h is answered before any guard. It prints the usage and exits 0 on a split tree (it was exit 2).", "rawDiffLines": "When the line counts differ, rawDiffLines is now diff's count, lines deleted plus inserted, via a Myers edit distance (it was 0). rawDiffMethod names which count applies, 'in-place' or 'diff'. On round 3's dists it reads 19, the same as diff. When the counts are equal, it still counts lines that differ in place, one per union swap.", "self_test": "45 cases in 5 batteries. Two new cases: a line-count change is counted, and --help is answered. A mutant of each fix is refused." }, "reader_inventory": { "scope": "Every test or gate that reads sql-driver.ts by path. Each row gives what it asserts and the share of its host matches that moved, base 7a25b39cf9 vs head.", "rows": [ { "reader": "driver-sql logger-receiver-detach.test.ts pin 3", "asserts": "absence (no detach-then-call shape)", "moved": "3 of 21 log-channel calls (14%)", "status": "WAS a silent narrowing; fixed now (directory listing, 55 = 55)" }, { "reader": "driver-sql sql-driver-compile-refusal-seam.test.ts", "asserts": "presence + exact set (refusal-builder callers by enclosing name)", "moved": "26 of 28 call/write sites (unsupportedFilterError( 3 -> 1, withheldFilterError( 24 -> 0, .INVALID_FILTER 1 -> 0) moved to the leaf", "status": "covered: sources gained the leaf in round 3; the method-scoped needles keep resolveWithheldFilterRefusal on the class" }, { "reader": "scripts/check-tenant-chokepoint.mjs", "asserts": "absence (no unscoped read builder, no D8 arm) + presence floors", "moved": "18 of 24 getBuilder() bindings in the host", "status": "covered: SCAN_FILES widened in round 2 (33 files); readings equal at base and head" }, { "reader": "packages/cli 5 pin tests (builtin-id-column, field-type-vocabulary, file-reference-width, multiple-json-column, string-family-width)", "asserts": "presence (they slice sql-driver.ts text by anchors)", "moved": "0 of their 12 needles' texts and 2 pinned methods", "status": "held by PATH_READER_NEEDLES / PATH_READER_PINS; green" }, { "reader": "scripts/check-keyed-text-bounds.mjs (EMITTER_FILE / EMITTER_ANCHOR, createColumn slice)", "asserts": "presence", "moved": "0 (needle + pin)", "status": "green" }, { "reader": "scripts/check-durability-degradation-log-level.mjs (repo-wide, but resolves a catch's log helper in the SAME file)", "asserts": "absence (no swallowed durability catch)", "moved": "0 of 9 this.logDurabilityFailure( calls; the needle 'this.runWideningAlters(' keeps the two bodies whose catch needs it", "status": "held by the needle; green" }, { "reader": "packages/spec/liveness/*.json path#symbol anchors (check:liveness, check-liveness.test.ts)", "asserts": "presence (the symbol is named in the cited file)", "moved": "1 of 14 citations (1 of 10 symbols)", "status": "fixed in a92c230e41" }, { "reader": "scripts/adr-anchors/packages__drivers__driver-sql__src__sql-driver.ts.json (check:adr-anchors)", "asserts": "presence (ADR-0053 is cited somewhere in the file)", "moved": "18 of 33 ADR-0053 citations (top-level leaf 11, sqlite-serialisation 5, filter-helpers 2)", "status": "SECOND SILENT NARROWING, not fixed here (outside this order): the check stays green on the 15 citations left. But the code its invariant names, formatOutput's folds and presentReadValue's datetime arm, now lives in sql-driver-sqlite-serialisation.ts and sql-driver-filter-helpers.ts, which have no anchor entry. Proposed fix, for the seat: add an ADR-0053 anchor entry for each of those two modules, as the hand series did for sql-driver-schema-sync.ts." }, { "reader": "ADR / QA-checklist / docs sql-driver.ts#symbol anchors (check:adr-symbol-anchors, check:platform-checklist)", "asserts": "presence", "moved": "0 of 26 distinct symbols broke (methods keep a stub; moved types are re-exported by name)", "status": "green" }, { "reader": "scripts/check-object-def-param-keys.mjs REQUIRED_CORPUS_FILES", "asserts": "presence (the file and its class-member declarations, a positive control)", "moved": "0 (the stubs keep every signature)", "status": "green" }, { "reader": "scripts/cross-package-test-inputs.mjs + turbo.json @objectstack/cli#test inputs", "asserts": "a cache-key declaration of the file the cli pins read", "moved": "0 (the pins' text stays in the host)", "status": "still exact; a later card that lets pinned text move must add the module here too" } ], "pattern": "The risky class is a reader that asserts ABSENCE, or presence of one token anywhere in the file. Both stay green while reading less. A reader that asserts an exact set or a slice goes red, which is loud. Two absence-class readers lost coverage silently: pin 3 (fixed) and the ADR-0053 anchor (open).", "codemod_rule": "Not added in this PR. A small rule would be: for each registered by-path reader, the plan prints its host-match count at base and in the host after the split, and refuses a drop unless the reader's list names the receiving module. The two scratch scripts used here are an/logsites.mjs and an/anchors-kind.mjs under /tmp/claude-0/-home-claude/cf62d71a-d2cf-598c-b2f9-9b5abc24174a/scratchpad/issue-29520/." }, "gates": "dispatch-gates --commands at e2723ad825 derives 83 families. Each was run alone, exit captured before any pipe: 82 exit 0. check:dual-build-cjs-loads exited 3 (driver-sql dist briefly absent during the run, rebuilt by a later step) and was re-run alone with the dist present: exit 0. --ran: 83 derived, 83 run, 0 NOT-MEASURED, 0 UNRUN, exit 0, with the same STALE TREE warning (main is 26 commits ahead, none touching driver-sql or the changed files). 11 extras exit 0: codemod --self-test, --verify (54/54, 127/127) and --help; chokepoint --self-test and main; deny-roster --self-test and main; check:adr-anchors; check:adr-symbol-anchors; check-nul-bytes; logger-receiver-detach + seam tests. eslint --no-inline-config on the changed files exit 0. check:commit-card-trailers passed on the push.", "open_for_seat": [ "the ADR-0053 anchor narrowing (reader_inventory row 8): add anchor entries for sql-driver-sqlite-serialisation.ts and sql-driver-filter-helpers.ts in this PR, or not" ], "mcp_calls": "0", "api_writes": "2 for this addendum: git push x1 (a92c230e41..e2723ad825: 6cc535d2be, e2723ad825); post-stamped comment x1 (this)" }chore(scripts): ADR-0053 anchor entries follow the read-boundary fold…
objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": "3, addendum 3 (seat ruling: the ADR-0053 anchor follows the code; merge of main)", "status": "done", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; whole body updated via relay issue_patch, run 41622024765, 16,039 bytes sent = stored, ends with the signed line)", "head": "77e178eeff", "merge_base": "origin/main 74fd4bf64a (merge 9f82207141, not a rebase)", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "adr_anchor_entries": { "commit": "77e178eeff", "added": [ "scripts/adr-anchors/packages__drivers__driver-sql__src__sql-driver-sqlite-serialisation.ts.json (ADR-0053; formatOutput's audit-column and Field.datetime folds)", "scripts/adr-anchors/packages__drivers__driver-sql__src__sql-driver-filter-helpers.ts.json (ADR-0053; presentReadValue's datetime and audit_timestamp arms)", "scripts/adr-anchors/packages__drivers__driver-sql__src__sql-driver-top-level.ts.json (ADR-0053; the fold helpers normalizeSqliteDatetimeOutput, presentAuditTimestampOutput, isoFromValidDate, repairNaiveUtcAuditTimestamp)" ], "shape": "{file, adrs, invariant} as #25521 cut 8 gave sql-driver-schema-sync.ts; each invariant names the code that moved to that file. The host entry stays: the stubs and 15 ADR-0053 citations remain there.", "why_only_ADR-0053": "The registry's only entry for sql-driver.ts is ADR-0053, so it is the only ADR with a registered invariant whose code could move. The other ADR citations that left the host are not registered invariants for that file, so no entry was invented for them. They are listed below.", "citations_host_base_to_head_and_where_they_went": { "ADR-0053": "33 -> 15; top-level 11, sqlite-serialisation 5, filter-helpers 2 (ENTRIES ADDED)", "ADR-0112": "18 -> 7; top-level 10, aggregation 1", "ADR-0074": "11 -> 3; top-level 5, filter-helpers 2, sqlite-serialisation 1", "ADR-0104": "19 -> 12; top-level 4, sqlite-serialisation 3", "ADR-0131": "19 -> 14; internal-helpers 2, top-level 2, sequence-semantics 1", "ADR-0049": "6 -> 1; top-level 4, aggregation 1", "ADR-0120": "18 -> 15; top-level 2, managed-drift 1 (its registered entry sits on sql-driver-schema-sync.ts, untouched by this split)", "ADR-0015": "19 -> 17; sqlite-serialisation 1, top-level 1", "ADR-0105": "3 -> 1; internal-helpers 1, window-functions 1", "ADR-0113": "6 -> 5; top-level 1", "ADR-0057": "7 -> 7 (2 more in crud and rotation are section-title mentions in the generated module headers)", "unchanged": "ADR-0003, 0021, 0030, 0048, 0100, 0139" }, "gates": "check:adr-anchors exit 0 (102 anchored files, every governing ADR still referenced); check:adr-symbol-anchors exit 0 (3050 anchors resolve)", "positive_control": "ADR-0053 replaced by ADR-XXXX in sql-driver-filter-helpers.ts: check-adr-anchors exits 1 with 'sql-driver-filter-helpers.ts: no longer references ADR-0053.' and prints the new entry's invariant. Reverted, status clean." }, "merge_and_reproof": { "main": "merged origin/main 74fd4bf64a (33 commits). sql-driver.ts there is the same blob (sha256 9abf7867fd98...) and main changed nothing in packages/drivers/driver-sql/src, so the codemod needs no regeneration: a plan run on main's input gives output tree sha256 f5d8722fa697b4530b9f76922c2b5d579f69048463e09cf190693793400b26e0, unchanged.", "byte_identity": "--verify --base 74fd4bf64a exit 0: 54/54 bodies, 127/127 top-level declarations; undoing the split rebuilds the base byte-for-byte; sql-driver.ts 18330 -> 12456 (wc -l 12,456)", "dts": "Both rebuilt on the new base (main had changed packages/spec/src and packages/types/src). index.d.ts and index.d.mts: normalised bytes identical 468260520fcc1ac2...; declared-surface digest equal 50e5e5be3c1d... (100 declarations); statement multiset 106 / 106, 0 only in base, 0 only in head; export set 92 = 92 (import set 17 = 17; CJS 59 = 59, ESM 59 = 59); detached comments equal; raw diff 19. The positive control (private dropped from compileFilters) is caught again: normalised 73e89389695f..., surface acf70f0378d0..., naming PropertyDeclaration [private] -> MethodDeclaration []. The rebuilt head is byte-identical to the measured head.", "chokepoint": "head: 24 bindings, 21 read doors, 3 inserts, 4 predicates, 0 D8 arms across 33 files, the same as base", "suites": "one lock hold, VERDICT command-exit 0. driver-sql: base 4067 (3851 passed, 216 skipped), head 4068 (3852 passed, 216 skipped); the +1 is pin 3's new floor case. driver-turso 2530 (2496 passed, 34 skipped) at both. driver-sqlite-wasm 750/750 at both. Typecheck exit 0 for all three. cli pins: 62 unit, 30 integration." }, "gates": "dispatch-gates --commands at 77e178eeff derives 84 families (check:adr-anchors joins). 83 exit 0. check:type-check-debt exited 3 because the new workspace package connector-app-docusign (#29813, from main) had no node_modules. After pnpm install --frozen-lockfile it was re-run alone: exit 0, 0 raw tsc errors. --ran: 84 derived, 84 run, 0 NOT-MEASURED, 0 UNRUN, exit 0, no STALE TREE warning. 13 extras exit 0 (codemod self-test, verify and help; chokepoint self-test and main; deny-roster self-test and main; adr-anchors; adr-symbol-anchors; nul-bytes; logger and seam tests; spec check:liveness). check:commit-card-trailers passed on the push.", "pr_body": "Brought current: 45 self-test cases, the --help and rawDiffLines fixes, the liveness re-point, the pin 3 listing, the three ADR-0053 entries, a short by-path reader table, merge base 74fd4bf64a, head 77e178eeff, 17,019 changed lines in 28 files.", "open_for_seat": [], "mcp_calls": "0", "api_writes": "3 for this addendum: git push x1 (e2723ad825..77e178eeff: merge 9f82207141, 77e178eeff); relay issue_patch x1 (PR body); post-stamped comment x1 (this)" }objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": "3, addendum 4 (re-review blocker: ts-morph no longer resolves after #29711)", "status": "done", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; whole body updated via relay issue_patch, run 41631095654, 17,822 bytes sent = stored, ends with the signed line)", "head": "5b19e9ac05", "merge_base": "origin/main 3a856f680d (merge 77bd6640c9, not a rebase); sql-driver.ts and all of driver-sql src unchanged vs 74fd4bf64a", "fix": [ "package.json: ts-morph ^28.0.0 joins the root devDependencies, beside typescript, yaml and semver, which the other root scripts import the same way. No gate or AGENTS.md rule forbids a root devDependency; check-undeclared-dep-imports judges package src only.", "pnpm-lock.yaml: written by pnpm install --lockfile-only, +25 lines, nothing re-resolved. Adds ts-morph@28.0.0, @ts-morph/common@0.29.0 and code-block-writer@13.0.3, the same three #29711 removed. @ts-morph/common's minimatch resolves to the 10.2.6 already in the tree. pnpm add was tried first and re-resolved an unrelated jsdom peer, 30.1.1 to 29.1.1; that lockfile was discarded.", "scripts/codemod-split-sql-driver.mjs: the loader resolves ts-morph from the root package.json. The header says so and names #29711. It also notes that a tree with no install at all stops earlier, at ts-parse.mjs's shared import-prerequisite refusal, exit 3." ], "clean_proof": { "setup": "all 129 node_modules directories removed, then pnpm install --frozen-lockfile (exit 0); ts-morph resolves to 28.0.0 from the root manifest", "control": "ts-morph alone set aside: --self-test exits 2 with 'ts-morph does not resolve from' the root package.json; restored", "self_test": "exit 0, 45 cases in 5 batteries", "verify_74fd4bf64a": "exit 0: 54/54 bodies, 127/127 declarations, 18330 -> 12456, undo rebuilds base byte-for-byte", "verify_3a856f680d": "exit 0, same readings", "determinism": "two plan runs on base's unsplit sql-driver.ts (input 9abf7867fd98...): tree f5d8722fa697b4530b9f76922c2b5d579f69048463e09cf190693793400b26e0 both times, outputs byte-identical", "help_on_split_tree": "exit 0", "after": "driver-sql src diff vs HEAD 0 bytes" }, "reviewer_correction": "Accepted. logDurabilityFailure( had 2 of the host's 9 calls move, to sql-driver-column-creation.ts:53 and :84, not 0. The host still counts 9 because two new stubs forward. Its gate stays green. The PR body's reader table is corrected.", "gates": "dispatch-gates --commands derives 92 at 5b19e9ac05: the 84 from 77e178eeff plus 8 that the root manifest and lockfile bring in (check-osv-exemptions and its --self-test, osv-base-relative --self-test, check:changeset-fixed, check:manifest-repository-directory, check:override-consistency, check:turbo-task-graph, check:vendor-export-contract-resolve). All 92 exit 0, each run alone with its exit captured. --ran: 92 derived, 92 run, 0 NOT-MEASURED, 0 UNRUN. Lock VERDICT command-exit 0; the lock was held 46m, and os-verify-lock asked for a holder-side starvation note, given here.", "not_measured": [ "OSV-Scanner on the new lockfile: the local proxy refuses api.osv.dev (403), and it was not worked around. CI runs it base-relative. The only advisory-bearing package the additions reach is minimatch 10.2.6, already in the merge base's lockfile and covered by the GHSA-g3hv-75wg-m249 exemption.", "Driver suites and .d.ts readings were not re-run. They stand at 77e178eeff, and driver-sql src is byte-identical from there to 5b19e9ac05." ], "for_the_seat": "Two prose lists of minimatch 10 parents no longer name @ts-morph/common, which is back as a dev-only root parent: the GHSA-g3hv-75wg-m249 reason in osv-scanner.toml and the pnpm-workspace.yaml override comment. Both are left untouched: the ledger's convention puts exemption edits in their own labelled PR. Say if either should change here.", "mcp_calls": "0", "api_writes": "3 for this addendum: git push x1 (77e178eeff..5b19e9ac05: merge 77bd6640c9, 5b19e9ac05); relay issue_patch x1 (PR body); post-stamped comment x1 (this)" }objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 29520, "round": "3, addendum 5 (CI red: check:tenant-chokepoint self-test after #29911 on main)", "status": "done", "pr": "https://github.com/objectstack-ai/objectstack/pull/29598 (draft; whole body updated via relay issue_patch, run 41644563992, 18,609 bytes sent = stored, ends with the signed line)", "head": "5f30cf9f2c", "merge_base": "origin/main 0b5b176038 (merge 010dd3831d, not a rebase)", "cause": "Confirmed locally. #29911 added sql-driver-balanced-group.ts. SCAN_FILES lists the directory, so it read the module, but DECLARED_WATCH_HINTS did not name it, and the self-test failed. The branch's own tree predated #29911.", "regeneration": "The resolution took main's driver-sql src whole, kept the branch's seam and logger tests, and ran --write unedited. The same 54 methods and 127 declarations move; the needles still apply, with no stale-needle refusal. The regenerated host differs from the previous head by #29911's change lines exactly, and nothing else under src differs except the two files #29911 added.", "gate_fix": [ "DECLARED_WATCH_HINTS gains sql-driver-balanced-group.ts.", "Glob measured, then declined. The extractor accepts packages/drivers/driver-sql/src/sql-driver-*.ts and judges it as a pattern. Through hintCovers it covers 31 seam modules and 234 sql-driver-*.test.ts files, plus any .d.ts. A hint has no negation, and ? and [...] are not admitted, so no spelling covers the modules without the tests. So the list stays literal, which is the order's fallback, and the docblock records the measurement.", "Both coupling asserts now name each missing or extra entry and the one edit that fixes it. Before the literal was added, the self-test read: 'Fix: add packages/drivers/driver-sql/src/sql-driver-balanced-group.ts to DECLARED_WATCH_HINTS in this gate'." ], "fresh_install": "All 129 node_modules directories removed, then pnpm install --frozen-lockfile (exit 0); ts-morph 28.0.0 resolves from the root manifest", "proofs_on_0b5b176038": { "verify": "--verify --base 0b5b176038 exits 0: 54/54 bodies, 127/127 declarations, undo rebuilds base byte-for-byte", "lines": "sql-driver.ts 18334 -> 12460, below 13,000. Round 3 had 12,456; #29911 added 4 lines to code that stays", "determinism": "--write plus two plan runs on base's unsplit text (input 2d2ebebdba87...): tree 088547bdc1b4e152d6298d4a1d33b007eec27871e179716a298944b673984170 each time, plan outputs byte-identical", "dts_four_readings": "index.d.ts and index.d.mts both pass: normalised 468260520fcc... = base; surface 50e5e5be3c1d... = base; statements 106/106, 0 only in base, 0 only in head; export set 92 = 92. The same hashes as round 3", "dts_control": "private dropped from compileFilters: normalised 73e89389695f..., surface acf70f0378d0..., statements 1/1, exit 1 on both files; restored, and the rebuilt head .d.ts is byte-identical", "dts_union_order_bar": "--dts reads FAIL (4), as in every round; the second normalisation is the ruled judge", "chokepoint": "24 bindings, 21 read doors, 3 inserts, 4 predicates, 0 D8 arms at base (15 files) and head (34 files); self-test and main run exit 0", "suites_base_vs_head": "driver-sql 4074 -> 4075 (3858 -> 3859 passed, 216 skipped; +1 is pin 3's floor case); turso 2530 = 2530; wasm 750 = 750; type-check 0 for all three; cli pins unit 62/62, integration 30/30", "pin3_and_seam": "logger-receiver-detach + compile-refusal-seam: 127/127", "liveness": "check-liveness.test.ts 74/74; check:liveness exit 0", "adr": "check:adr-anchors exit 0; check:adr-symbol-anchors exit 0", "self_test_help": "--self-test 45 cases in 5 batteries; --help on the split tree exit 0" }, "gates": "dispatch-gates --commands derives 92 at 5f30cf9f2c, the same list as last time. 92 exit 0, check:tenant-chokepoint among them. --ran: 92 derived, 92 run, 0 NOT-MEASURED, 0 UNRUN. Proof lock held 18m29s, gate lock 39m49s, both VERDICT command-exit 0.", "not_measured": "OSV-Scanner. The proxy refuses api.osv.dev, and this was not worked around. CI runs it base-relative.", "main_since": "origin/main is 5 commits past 0b5b176038 at push time, and none touches drivers, the gate, the codemod, the lockfile or the anchors", "for_the_seat": "Still open from addendum 4: the minimatch parent prose in osv-scanner.toml and pnpm-workspace.yaml omits @ts-morph/common. Also, if you prefer the glob despite the 234 test files it would also match, it is a one-string change plus the self-test assert.", "mcp_calls": "0", "api_writes": "3 for this addendum: git push x1 (5b19e9ac05..5f30cf9f2c: merge 010dd3831d, 5f30cf9f2c); relay issue_patch x1 (PR body); post-stamped comment x1 (this)" }objectstack-fleet commentedon Nov 3, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Landed ·
domain:devx#2· 2026-11-03T17:20Zos-zhuang approved PR #29598 at 15:58Z and merged it as
d46b1ff23f(16:26Z). The merged head5f30cf9f2cis the head of the seat's ACCEPT 6605693872, and the card closed on itsFixes.sql-driver.tsis now split by a deterministic codemod script, and the split is verified byte-identical. The diff is 12,460 lines, cut as rulings 6591753301 (A) and 6597555122 (round 2, A) set.sql-driver-*.ts.The seat releases the card:
pm:dispatchedandpm:blockingcome off, and the worktree and branch are removed.