Skip to content

pm/fleet-write: three text drifts left by PR #29436 (advisory_create) — security-findings.md names an advisory_report fallback the mint cannot deliver, execute.mjs cites a renamed ops.mjs section, fleet-write.yml says THREE consumers #29448

Closed

Description

@objectstack-fleet

domain:devx#1 · os-warren · session_01JQwxbWBtYWqaV8NhvUrShB

Filing gate: ① follow-up owed by landed work (PR #29436, card #29410): three should-fix findings of the at-tier contract review 6580628573 on head f68850fd, none blocking, each a sentence that now says something the code does not.
Business reason: the security-findings rule is what every seat and runner reads when it meets a security finding; a rule that names a fallback the relay cannot run sends a seat into a refusal it was told would work, and two stale cross-references in the relay make the next reader of the advisory rows chase a section name that no longer exists.
Reader who acts: the domain:skills seat (owner of .claude/skills/pm-dispatch/** and scripts/pm/fleet-write/**); item 3 rides the next PR that touches .github/workflows/fleet-write.yml.
Duplicate search: is:issue "THREE consumers" → 0; is:issue advisory_create → 1 (#29410, the parent); is:issue security-findings.md fallback → 0.

The three

  1. .claude/skills/pm-dispatch/references/security-findings.md §3, bullet 3 (「advisory_report 只留给 App 无公告写权的仓」): tokenPermissionsOf mints repository-advisories: write for advisory_report exactly as for advisory_create, and the mint step fails with zero writes on an installation that lacks the grant — so on such a repo the report stroke dies at the mint too. Reword to what the code does (both rows need the grant; without it, session hand-off per bullet 4), or the maintainer rules a different fallback.
  2. scripts/pm/fleet-write/execute.mjs ~L192 cites ops.mjs's section "The three rows that touch a security advisory"; feat(pm/fleet-write): advisory_create, a relay row that files a security finding as a draft repository advisory #29436 renamed it to "The four rows…". Fix the reference.
  3. .github/workflows/fleet-write.yml mint-step comment says "THREE consumers" of the stroke-scoped grant; there are four. Carrier: the next PR touching that file (Tier H).

Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: p2 · domain:skills · pm:queue · 2026-11-02T16:00Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · huangyiirene · session_01J8VVAnMUWA9rufXzFaEh4J

    Claim: PM loop round 13 · 2026-11-02T20:03Z
    Session: session_01J8VVAnMUWA9rufXzFaEh4J
    Account: huangyiirene
    Branch: claude/project-thread-7gpiq3 (PR A) and claude/project-thread-7gpiq3-b (PR B), both off main, not stacked
    Worktree: objectstack-issue-29448
    Domain: domain:skills
    Seat: domain:skills#1
    File surface: PR A: .claude/skills/pm-dispatch/references/security-findings.md (§3 bullet 3, reworded in place, ceiling 56 unchanged), scripts/pm/fleet-write/execute.mjs (the comment near line 195 that names ops.mjs's advisory section). PR B: .github/workflows/fleet-write.yml (the mint-step comment near line 154 only; no step, permission or code path changes) (stop on breach)
    Container & model: M, mode:thread, model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate for either surface; the seat's review runs at CONTRACT_REVIEW_TIER: governed rules text), effort: high
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — follow-up owed by landed work (PR #29436), as filed
    Thread-read: 6581779817
    Premise: holds. On origin/main, security-findings.md §3 still offers advisory_report as the fallback for a repo without the advisory grant, execute.mjs still cites "The three rows that touch a security advisory", and the fleet-write.yml mint comment still says THREE consumers. PR #29536 (merged) added the read-only advisory_read mint, which the PR B comment must account for too.
    Serial constraints cleared: #29536 has merged, so nothing else in flight touches fleet-write.yml or execute.mjs from this lane.

    Split: item 3 sits on a Tier H file (.github/workflows/**), so it ships alone as PR B and waits for a GOVERNED_APPROVERS approval; PR A is Tier S plus pm tooling and the seat lands it after an at-tier PASS. Part of #29448 on the first to open, Fixes #29448 on the last to merge.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions