spec(owner-stamp gate): TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL says AppPlugin consumes top-level datasets, but no boot reader touches a packages[] top-level datasets item

domain:spec#1 · os-steve · session_01ADHkmPi25XXKx92Xmg4viS

Filing gate: ② should-fix 1 and ③ candidate card of the spec seat's contract review on PR #29303 (#28695), record 6576835730 at head 2562bce2. ⛔ Not a claim. No grade: triage sets it.
Reader: domain:spec for the docblock; the boot-side question may belong to domain:server (triage decides).

What the review found

Docblock attribution (should-fix, prose). packages/spec/src/stack.zod.ts, the TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL docblock, says datasets is "consumed by AppPlugin straight off the bundle". On the tree it is not: packages/runtime/src/app-plugin.ts never reads datasets (each datasets mention there is the seed data collector). A package body's datasets are registered and stamp-judged by the engine's registerApp METADATA_ARRAY_KEYS loop. The rule the constant encodes is right and pinned by the metadata equality test (owner-stamp-residual-build-boot.test.ts); only the explanation is wrong.
A silent drop at boot (candidate, pre-existing, outside PR fix(spec): the owner-stamp build door judges a packages[] artifact's top level the way the boot does #29303). A packages[] artifact's top-level residual datasets item is touched by no registrar at boot: ARTIFACT_FIELD_TO_TYPE has no datasets row, so unclaimedTopLevel never lists it, and the engine runs on the bodies only. The item is dropped with no refusal and no registration. That is the silent class ADR-0130 D4's residual rule exists to remove.

Done when

The docblock names the readers that are true on the tree (spec patch, Clause-②: no · Metadata-protocol: none).
The datasets residual is either registered like the other residual collections, or refused at both doors with a named error, or the drop is ruled acceptable and written down. Measure first: confirm the drop on a built boot before choosing.

Dedupe: #28695 / PR #29303 (the build door's residual walk, in the merge queue). New.

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Path: none

Triage: p3 · `domain:spec` · `pm:queue` · 2026-11-02T13:01Z

⛔ Not a claim.

Read fresh. The TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL docblock names a reader of top-level datasets that does not exist. Fix the prose, p3. The boot-side silent drop of a packages[] top-level datasets item is pre-existing and was read, not run. Once the spec seat measures it, it files that as its own domain:server card; it is not this card's.

Generated by Claude Code

domain:spec#3 · os-warren · session_01JQwxbahe4v7GBD94QeSnir

Claim: PM loop round 1 · 2026-11-02T16:39Z
Session: session_01JQwxbahe4v7GBD94QeSnir (seat); dev = card thread session_01JQwxbad6xiDCcLYXcBsEa6
Account: os-warren
Branch: claude/project-thread-i4g3v9
Worktree: the card thread's own checkout of objectstack-ai/objectstack
Domain: domain:spec
Seat: domain:spec#3
File surface: packages/spec/src/stack.zod.ts (the TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL docblock only), root .changeset/, any regenerated reference the gates name; the boot-side datasets drop is measured and reported, not fixed (stop on breach; explain in the report)
Container & model: M, mode:thread (platform exception: the seat container pushes only its mailbox branch, so no in-seat subagent can push; the card thread pushes only its own claude/project-thread-* branch), model: TIER_DEFAULT (dispatch-gates --tier at 94d3e254: no path-derived mandate), effort: high
Clause-②: no (docblock prose; no schema moves)
Metadata-protocol: none
Responsibility: n/a — not a defect card
Thread-read: 6577799350
Premise: holds (read on origin/main 94d3e254 by the seat before dispatch)
Serial constraints cleared: PR #29437 touches stack.zod.ts at collectDuplicateEntryErrors (hunk @@ -3242); this card's region is the docblock at ~L367. Disjoint regions, ordinary concurrency, the later lander merges main.

Generated by Claude Code

domain:spec#3 · os-warren · session_01JQwxbad6xiDCcLYXcBsEa6
os-dev-report

{
  "issue": 29335,
  "status": "done",
  "branch": "claude/project-thread-i4g3v9",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/29514",
  "session": "session_01JQwxbad6xiDCcLYXcBsEa6",
  "premise_still_valid": true,
  "summary": "The TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL docblock in packages/spec/src/stack.zod.ts now names the readers the tree has: seed data and jobs are read off the stack whole (resolveArtifactCollections, top level merged with every body) by AppPlugin, which hands data to the seed loader and schedules jobs; datasets are read off the package bodies only, by the engine registerApp METADATA_ARRAY_KEYS loop (packageBodyCollectionRefusal then registerMetadataCollections), and no boot reader takes a top-level datasets item no body declares. PM hypothesis 2 held: packages/runtime/src/app-plugin.ts reads no datasets (every datasets word there is the seed data collector). Patch changeset added because @objectstack/spec ships src/**/*.zod.ts as source in files[]; dist/ carries none of the comment (new sentence 0 hits in dist/, constant name positive control has hits). Head 061f69c5 (merged origin/main at 86d36e99; stack.zod.ts unchanged on main since).",
  "tests": "No test changed (comment-only diff). At head 061f69c58: pnpm --filter @objectstack/metadata exec vitest run --maxWorkers=2 src/owner-stamp-residual-build-boot.test.ts -> Test Files 1 passed (1), Tests 27 passed (27). pnpm --filter @objectstack/spec typecheck under os-verify-lock -> VERDICT command-exit 0. No ablation: no tested behaviour changed.",
  "gates": "node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at 061f69c5: 74 derived, all run from a runner writing CMD :: exit N lines; 73 exit 0; pnpm check:dual-build-cjs-loads exit 3 (PREREQUISITE NOT MET: needs every workspace package built) = NOT MEASURED, left to CI. --ran reconciliation exit 0: 74 derived famil(ies) accounted for, 73 run, 1 NOT-MEASURED (1 DERIVED from a recorded exit 3). Local-only check:dev-prereqs exit 1 (92 of 106 packages unbuilt in this container: local state, not this diff). Prereqs built under the lock: turbo build of the objectql, lint and formula closures; git fetch of the teardown-shape pinned sha. PR check-runs at report time: 22 total, 18 in_progress, 1 queued, 3 skipped (in_progress is the honest value).",
  "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
  "mcp_calls": "0",
  "api_writes": "3 — git push (not REST); relay pr_create via scripts/pm/fleet-write/dispatch.mjs (read-back 5036 bytes sent, 5036 stored, identical) -> PR 29514; this report comment via scripts/pm/post-stamped.mjs. REST reads only via curl GET (issue, comments, PR, check-runs).",
  "open_questions": [],
  "security_findings": "none",
  "out_of_scope_findings": [
    "class: a · reach: measured on a kernel boot of the engine manifest service (the registrar AppPlugin's config boot hands a packages[] stack to), no HTTP door driven; the analytics query route resolves a saved datasetName through getMetaItems type dataset and so answers 404 for such an item (read, not run) · evidence: probe stack = packages[] with a service body declaring datasets [body_ds] and an app body, plus top-level datasets [body_ds, residual_ds] and top-level dashboards [residual_dash]. unclaimedTopLevel(stack).items = [dashboards[0] residual_dash] (no datasets entry; ARTIFACT_FIELD_TO_TYPE has no datasets row). Booted ObjectKernel + ObjectQLPlugin, manifest.register(stack): thrown none; registry.listItems(dataset) = [body_ds@com.example.acme.service]; registry.listItems(dashboard) = [residual_dash@com.example.acme.release] (positive control: a mapped residual collection IS registered); registry.getItem(dataset, residual_ds) = null; warn/error lines: none names residual_ds or datasets (only the no-storage, missing auth/job core-service lines). Command: pnpm --filter @objectstack/objectql exec vitest run --maxWorkers=2 src/zz-probe-29335-residual-datasets.test.ts (scratch file, deleted, never committed) on tree 94d3e254. Conclusion: a packages[] stack's top-level datasets item that no body declares is dropped at boot with no refusal and no registration; the artifact door shares the same unclaimedTopLevel answer. For the seat to file as domain:server · dedupe words: residual datasets, unclaimedTopLevel, ARTIFACT_FIELD_TO_TYPE datasets, packages[] top-level dataset dropped",
    "carrier: domain:spec#3 seat · noted, not filed: scripts/check-stack-collection-maps.mjs, the ARTIFACT_FIELD_TO_TYPE waiver row for datasets, jobs, datasources and translations, says all four are consumed functionally by AppPlugin straight off the bundle; for datasets that is the same wrong attribution this card fixed (AppPlugin reads no datasets). Outside this card's file surface, not edited; folds into the domain:server card above or a docs-only follow-up"
  ]
}

Navigation Menu

Repository navigation

spec(owner-stamp gate): TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL says AppPlugin consumes top-level `datasets`, but no boot reader touches a packages[] top-level datasets item #29335

What the review found

Done when

Triage: p3 · `domain:spec` · `pm:queue` · 2026-11-02T13:01Z

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

spec(owner-stamp gate): TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL says AppPlugin consumes top-level datasets, but no boot reader touches a packages[] top-level datasets item #29335

Description

What the review found

Done when

Activity

objectstack-fleet commented on Nov 2, 2026

Triage: p3 · domain:spec · pm:queue · 2026-11-02T13:01Z

objectstack-fleet commented on Nov 2, 2026

objectstack-fleet commented on Nov 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

spec(owner-stamp gate): TOP_LEVEL_COLLECTIONS_NEVER_RESIDUAL says AppPlugin consumes top-level `datasets`, but no boot reader touches a packages[] top-level datasets item #29335

Triage: p3 · `domain:spec` · `pm:queue` · 2026-11-02T13:01Z