Skip to content

docs(adr-0143): append an amendment note that the installer-client server slice has landed (the "until the server slice lands … held degraded" sentence is now history) #29256

Closed

Description

@objectstack-fleet

domain:server#2 · os-steve · session_01ADHkmQxwoGb5fSnrFkpxmt

立卡门: ① 已落地工作欠的后续(ADR 文本,受治理 Tier H),PR #29097 合约复审记录 6574689504 ③ should-fix 2 点名。
业务理由: ADR-0143 是连接器认证的现行依据,读者(开发者、各车道席位、复审)按它判断行为;#29097 落地后,D2「Slices」条里「Until the server slice lands, the key is declared and not served … held degraded for a missing clientId」描述的已不是现状。不修,读者会以为 clientSource: 'installer' 仍不生效。
动手的读者: domain:server 席,在 #29097 合并后,按仓库的只追加 ADR 修订注记做法(Amended-by / 同行续写锚点)给 docs/adr/0143-outbound-connector-auth-is-open-tier.md D2 加一条注记,⛔ 不改写原句。
查重: ADR-0143 held degraded clientId 4 命中(#28864 #28299 #26702 等,均非此注记)。

Blocked-by: #28866

What to append

One amendment note at D2's "Slices" bullet: the server slice landed in PR #29097. The connect door takes the installer's client (clientId, optional clientSecret), and the grant handle uses it for authorize, exchange and refresh. An instance declaring clientSource: 'installer' is no longer held degraded for a missing clientId. The ui slice is #28869.

Acceptance

  • Append-only note in the repo's ADR amendment shape; the original sentence stays as written.
  • The ADR index or generated pages regenerate if the gate asks.
  • Governed Tier H: a draft until GOVERNED_APPROVERS approve.

Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: p3 · domain:server · pm:blocked · 2026-11-02T10:58Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#2 · os-steve · session_01ADHkmQxwoGb5fSnrFkpxmt

    Unblocked · 2026-11-02T15:39Z

    #28866 landed (PR #29097, ec0316ea44, merged 2026-11-02T15:29Z). An oauth2 connector declaring clientSource: 'installer' connects with the administrator's client { clientId, clientSecret }, and the connection state reads client { source, clientId, hasSecret } (key names ruled A, 6580268872). This card's blocker is gone: the server slice the note records is on main; governed Tier H, so its PR stays a draft until a GOVERNED_APPROVERS approval.

    State: pm:blocked → pm:queue, recorded by this comment.


    Generated by Claude Code

  3. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#2 · os-steve · session_01ADHkmQxwoGb5fSnrFkpxmt

    Claim: PM loop round 1 · card thread · 2026-11-02T15:43Z
    Session: session_01ADHkmQxwoGb5fSnrFkpxmt (the seat); the card thread is session_01ADHkmPosotet8HaKtCv2id
    Account: os-steve (the seat's linked user; the card's assignee)
    Branch: claude/project-thread-i5savo (the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)
    Worktree: the card thread's own container checkout
    Domain: domain:server
    Seat: domain:server#2
    Ruling-ref: the note records what landed under 6566728470 (letter B, installer-supplied OAuth client) and 6580268872 (letter A, key names); no ruling of its own is owed. Filed p3 by domain:server#2 as should-fix 2 of contract review 6574689504.
    File surface: docs/adr/0143-outbound-connector-auth-is-open-tier.md (one append-only amendment note at D2's "Slices" bullet; + a generated ADR index only if a gate requires it). ⛔ Nothing else. Governed Tier H: a draft until a GOVERNED_APPROVERS approval; never marked ready by the thread.
    Container & model: M, mode:thread, model: opus (TIER_DEFAULT; --tier names no path mandate: PM's call), effort: low
    Clause-②: no
    Metadata-protocol: none
    Responsibility: the code is ADR-0143's D2 text · the platform path is a reader of the ADR who takes clientSource: 'installer' as declared and not served · reached by every developer, seat and reviewer judging connector auth against the ADR
    Thread-read: none
    Premise: holds (PR #29097 merged 2026-11-02T15:29Z, ec0316ea44 on origin/main)
    Serial constraints cleared: none — no open PR touches the ADR-0143 file, and no open claim on a pm:dispatched card names it (read this act). The #29106 thread's governed note is on ADR-0066, a different file.
    Resume-from: none — fresh from origin/main

    State: pm:queue → pm:dispatched, assigned to os-steve, recorded by this claim.


    Generated by Claude Code

  4. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#2 · os-steve · session_01ADHkmPosotet8HaKtCv2id
    os-dev-report

    {
      "issue": 29256,
      "status": "done",
      "branch": "claude/project-thread-i5savo",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/29483",
      "session": "session_01ADHkmPosotet8HaKtCv2id",
      "premise_still_valid": true,
      "summary": "Appended one amendment note to ADR-0143, a nested blockquote under the Slices bullet of the 2026-11-02 D2.1 note, recording that the server slice landed in PR #29097 (ec0316ea44): the connect door takes the closed body { clientId, clientSecret? }, the grant handle uses that client for authorize, exchange and refresh, the state reads client { source, clientId, hasSecret } and never the secret, and an installer instance is no longer held degraded for a missing clientId; the ui slice #28869 is named as open. The original sentence, the Status line and the Amends header are unchanged. Draft PR, Tier H, skip-changeset.",
      "tests": "Docs only: no unit test, no ablation (os-dev: docs are not ablated). node scripts/check-adr-symbol-anchors.mjs on 0a3e4078: exit 0, 2983 anchors resolve, 706 symbol / 2230 file-level, vs origin/main aca58cdb 2977 / 702 / 2228: the 4 new symbol anchors and 2 test-file anchors resolve.",
      "gates": "Head 0a3e4078 (794155db + merge of origin/main 8ca9dd7b). dispatch-gates --commands: 21 commands, identical list on both heads; all 21 exit 0 on 794155db and again on 0a3e4078 (check-adr-links +self-test, check-closing-keyword-parity +self-test, check-comment-mask-corpus, plan-test-core-shards --self-test, lint check:doc-formula-expressions after the formula+lint build under os-verify-lock VERDICT command-exit 0, check:adr-anchors, check:adr-index (README current, no regen), check:adr-symbol-anchors, check:ci-filter-parity, check:closed-ceremony-text, check:cross-package-test-inputs, check:doc-authoring, check:driver-memory-census, check:gitlink-declared, check:nul-bytes, check:pm-governed-merges, check:pm-prior-rulings, check:refd-timer-probe, check:watch-hint-literal). --ran: 21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUN. pnpm lint: no package touched, nothing to lint. CI check-runs: in_progress at report time.",
      "dogfood_battery": "n/a — no ! in the PR title and Clause-②: no",
      "mcp_calls": "6 — reads only: issue_read get x1, issue_read get_comments x3, pull_request_read get_files x1, pull_request_read get x1; no write tool",
      "api_writes": "2 — fleet-write relay pr_create (PR #29483, labels skip-changeset, body read back 4626/4626 bytes identical); post-stamped os-dev-report comment on #29256. Plus git push (not REST).",
      "files_changed": ["docs/adr/0143-outbound-connector-auth-is-open-tier.md (+28 / -0)"],
      "line_budget": "28 added, 0 removed, 1 file; under the 3000 human-merge threshold",
      "deviations": [
        "The harness asks to assign os-steve and request their review on the new PR through MCP writes; the standard order forbids MCP writes and PR assignees and the delta says request no reviewer, so neither was done.",
        "The PR footer is the repo's session-URL form (AGENTS.md), not the harness's robot-emoji footer."
      ],
      "open_questions": [],
      "security_findings": "none",
      "out_of_scope_findings": []
    }

    Stamped 2026-11-02T16:09Z.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:serverDomain lane — seat card indexed by label:pm:seatpriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions