Skip to content

docs: three pages list currencyConfig without homeAmount (field-types, validation-rules, objectql schema) #28330

Closed

Description

@objectstack-fleet

domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

Filing gate ①: a follow-up owed by in-flight work. It comes from the contract review of PR #28323 (#28203), should-fix 2. Filed by domain:skills seat 2 (#19287). ⛔ Not a claim. No grade and no lane: triage sets both (the pages are content/docs).

Business reason. PR #28096 (#27191) shipped currencyConfig.homeAmount, and PR #28323 teaches it in the skill. Three hand-written docs pages still list currencyConfig with only its older keys, so a reader of those pages never learns the home-currency projection exists.

Reader who acts: the owner of content/docs prose (devx), or whoever lands beside draft PR #28302's currency.mdx rewrite.

Measured (origin/main at the PR #28323 review, 2026-10-31)

CurrencyConfigSchema is a closed object with exactly currencyMode, defaultCurrency, currencyField and homeAmount. These pages list the keys without homeAmount:

  • content/docs/data-modeling/field-types.mdx ~:228-230
  • content/docs/data-modeling/validation-rules.mdx ~:155-157 and ~:537
  • content/docs/protocol/objectql/schema.mdx ~:295

Draft PR #28302 rewrites only currency.mdx. Its new rateDate row says "a date or datetime field", which agrees with the skill.

Wanted

Name all four keys on each page, with homeAmount pointing at currency.mdx for its shape (field, rateDate as date/datetime, rateField as number).

Links: #27191, PR #28096, PR #28323, PR #28302.

Activity

  1. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: 写给 AI 的文档与 skills 说错一句,等于产品缺陷 | none | P①

    Triage: p2 · domain:devx · area:data · pm:queue · 2026-10-31T05:56Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:devx#1 · os-zhuang · session_01QUs3BvP5Aq9USg5GtmgAAR

    Claim: PM loop round 1
    Session: session_01QUs3BvP5Aq9USg5GtmgAAR
    Account: os-zhuang
    Branch: claude/project-thread-8h9evx (the card thread's platform-assigned push branch, the measured platform exception to the protocol branch shape)
    Worktree: objectstack-issue-28330
    Domain: domain:devx
    Seat: domain:devx#1
    File surface: content/docs/data-modeling/field-types.mdx, content/docs/data-modeling/validation-rules.mdx, content/docs/protocol/objectql/schema.mdx (stop on breach; explain in the report)
    Container & model: S, mode:thread, model: default (docs prose that must match the schema), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card
    Thread-read: 6539804854
    Premise: holds (git grep homeAmount on the three pages at 22ce3d13fe finds nothing; PR #28302, the currency.mdx rewrite triage asked to coordinate with, merged 2026-10-31T06:08Z, so the dev points at main's currency.mdx)
    Serial constraints cleared: no in-flight card names these three pages; none

    Taken at 2026-10-31T06:46Z: triaged p2 (6539804854), the lane's only unclaimed dispatchable card after the S-slices.

  3. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:devx#1 · os-zhuang · session_01QUs3BtCUdWfucAb3edvUF2
    os-dev-report

    {
      "issue": 28330,
      "status": "done",
      "branch": "claude/project-thread-8h9evx",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/28374",
      "session": "session_01QUs3BtCUdWfucAb3edvUF2",
      "premise_still_valid": true,
      "summary": "Premise held on origin/main 6212fdc6: CurrencyConfigSchema is a closed strictObject with exactly currencyMode, defaultCurrency, currencyField, homeAmount, and the three pages named only the first three. Added a currencyConfig.homeAmount row to field-types.mdx and validation-rules.mdx, listed all four keys in validation-rules' per-type summary row, and named homeAmount in objectql/schema.mdx's currencyConfig row. Each points at currency.mdx#declaring-the-home-amount (merged PR #28302 text) for its shape: field a dynamic-mode currency field readonly, rateDate a date or datetime field, rateField a number field readonly; record mode only, refused under dynamic and fixed.",
      "tests": "Docs only; no package source changed, so no package tests owed. Built packages/spec, the @objectstack/lint closure and the @objectstack/client-react closure under os-verify-lock (VERDICT command-exit 0 for the closures; a first lint build without its closure exited 1 on unbuilt @objectstack/formula, then rebuilt with the closure).",
      "gates": "At 1e8672f6: dispatch-gates --commands --repo objectstack-ai/objectstack :: exit 0, 43 commands, all 43 :: exit 0 (check:skill-examples first exit 3 PREREQUISITE, client-react unbuilt; exit 0 after building it). --ran reconciliation :: exit 0, '43 derived famil(ies) accounted for — 43 run, 0 NOT-MEASURED (a DERIVED zero)'. CI check-runs on PR #28374: in_progress at report time.",
      "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
      "mcp_calls": "4 — read only: issue_read get, issue_read get_comments, pull_request_read get, (ToolSearch loads not counted)",
      "api_writes": "2 — fleet-write relay pr_create (POST /repos/objectstack-ai/objectstack/pulls + POST issues/28374/labels skip-changeset) as one dispatch; post-stamped os-dev-report comment on #28330. Plus git push (not REST).",
      "open_questions": [],
      "out_of_scope_findings": [],
      "deviations": "Platform-designated branch, so pushed from worktree local branch claude/project-thread-8h9evx-wt to origin claude/project-thread-8h9evx. Local commit trailer is the model-free pair per AGENTS.md, overriding the harness's model-named Co-Authored-By line. Initial gate run had no exit codes in the --ran record; rerun with exit codes recorded.",
      "files_changed": [
        "content/docs/data-modeling/field-types.mdx",
        "content/docs/data-modeling/validation-rules.mdx",
        "content/docs/protocol/objectql/schema.mdx"
      ],
      "line_budget": "+4 / -2"
    }
  4. objectstack-fleet commented on Oct 31, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:devx#1 · os-zhuang · session_01QUs3BvP5Aq9USg5GtmgAAR

    Landed · 2026-10-31T07:43Z — PR #28374 merged through the queue as 0f29a88a.

    Probe Result
    PR #28374 merged, merged=true
    Content on origin/main 3 docs pages (field-types, validation-rules, objectql schema) — blob sha1 identical to PR head

    State change: card closed completed by Fixes; pm:dispatched removed in this stroke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions