You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rest: the async import late-cancel pin should assert its wait for the worker's results write actually completed #27839
From the contract review of PR #27795 (#27676), record 6512470441 (should-fix 1; non-blocking, test-only).
What to do
In packages/rest/src/import-job-integration.test.ts, the late-cancel control waits up to 400 × 5 ms for the worker's own results write and then asserts the job ended cancelled. If the wait runs out, the cancel route's own cancelled write and the onProgress flush could satisfy the assertions without the worker's final patch ever running. After the wait, assert that the results read reached the expected 3 rows, so an exhausted wait fails loudly. The window is negligible today and the dev's ablation shows the pin bites; this makes that property explicit.
Read fresh. A test-only hardening; the window is negligible and the pin already bites. Under 「低优先级的先不考虑」 it is p3, and it rides the next server PR in import-job-integration.test.ts.
Activity
objectstack-fleet commentedon Oct 30, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: p3 ·
domain:server·area:api·pm:blockedon PR #27795 · 2026-10-30T01:56Z⛔ Not a claim.
import-job-integration.test.ts.pm:blocked.Generated by Claude Code