Repository navigation
spec/service-datasource: tidy the EngineDatasourceDef.driver contract after #27666 — member doc, listDatasourceDefs read-back, required reconnect previous, stale test and guide lines (epic #27261) #27727
Description
epic:#27261#1 · marchtian · session_017ihL2c5z3q4h8inrn5kwqV
Filing gate: ① should-fix findings owed by landed work (#27666, PR #27715), from its contract review 6508089206 (④ should-fix 1–4 and the ③ prose note). No must-fix; none opens a path today.
Reader: the epic PM (#27261), by pull; the fix spans packages/spec/src/contracts/data-engine.ts, packages/objectql/src/engine.ts, packages/services/service-datasource/src/datasource-connection-service.ts, packages/objectql/src/external-driver-floor.test.ts, content/docs/data-modeling/virtual-objects.mdx.
Dedupe (open AND closed): follow-ups of #27666 filed by the epic PM → none.
reach: read on the reviewed head df7e3c66; see 6508089206 ④ for each file:line.
type: Bug
维护者速读
- 现象： service-datasource: a runtime-origin or reconnected plugin-driver datasource loses the #27277 external-driver floor, because the connection service registers the datasource def without its driver id and unregisterDriver drops the stored one (epic #27261) #27666 加了
EngineDatasourceDef.driver后，契约文字、读回接口和一个可选参数还没完全跟上。 - 原因： 复核找出的 4 条 should-fix，外加指南里一处旧说法。
- 影响： 目前没有可触发的问题；主要防止下一个调用方照旧文档写出不受兜底层保护的数据源。
- 最小修法： 见下方 Task。
- 需要您做的： 无。
Task
-
IDataEngine.registerDatasourceDef?member doc: "last write wins, except an absentdriverkeeps the id stored before it". -
ObjectQL.listDatasourceDefsreturnsdriver, or the key doc says the read-back omits it. -
DatasourceConnectionService.reconnect:previousbecomes required, or the restore refuses to register a def whose driver it cannot name (a host callingreconnectwithoutpreviouswould serve a kept plugin pool unfloored). -
external-driver-floor.test.ts~:468-469: the keep test names the caller class it models (write-gate facts only), not the connection service. -
virtual-objects.mdx~:634: drop "ADR-0015 … Tier A" (epic [Decision] Ontology over external systems: virtual objects on ADR-0015 federation — two driver tiers (plugin code · declarative OpenAPI), pushdown/identity/catalog/cache rules, Studio and AI drafts (2026 ontology research + deep design) #27261's term, not ADR-0015's).
Clause-②: decided by the dev from the diff (making previous required narrows an exported method's accept set) · Metadata-protocol: none. Touches packages/spec/src/**: owes a full Fable review and a CONTRACT_REVIEW_TIER record before landing.
Activity
objectstack-fleet commentedon Oct 29, 2026
epic:#27261#1 · marchtian · session_017ihL2c5z3q4h8inrn5kwqV
Claim: PM loop round 7 2026-10-29T21:54Z
Session:
session_017ihL2c5z3q4h8inrn5kwqV(epic PM); implementing card threadsession_017ihL2fhwqSBmy1XBXfcoU1Account:
marchtianBranch:
claude/project-thread-eecjmj(the card thread's platform-assigned branch — measured platform exception toclaude/issue-<n>-<slug>)Worktree:
objectstack-issue-27727Domain:
domain:serverSeat:
epic:#27261#1(epic PM; nodomain:*seat). Maintainer order, 田騏 2026-10-29T21:50Z: 「给我解释后续还有哪些卡，以及为什么不派」 (epic subtree p3 cards are dispatched, not left by pull)File surface:
packages/spec/src/contracts/data-engine.ts(member and key docs),packages/objectql/src/engine.ts(listDatasourceDefs),packages/services/service-datasource/src/**(reconnect'sprevious, tests),packages/objectql/src/external-driver-floor.test.ts(the keep test's framing),content/docs/data-modeling/virtual-objects.mdx(the "ADR-0015 … Tier A" line), generated references the spec change re-records,.changeset/**(stop on breach; explain in the report)Container & model:
S,mode:thread,model: default tier (dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no (narrowing)
Metadata-protocol: none
Responsibility: #27666 (PR #27715) added
EngineDatasourceDef.driver; its contract review 6508089206 (④ should-fix 1–4, ③ prose note) found the restThread-read: none
Premise: holds — on
origin/maintheregisterDatasourceDef?member doc still says "last write wins",listDatasourceDefsreturns nodriver, andreconnect'spreviousis optional.Serial constraints: none in flight on these files. Contract face (published spec contract): the PR body says "Fable review owed", and it does not land until a
CONTRACT_REVIEW_TIERrecord PASS is on its head.objectstack-fleet commentedon Oct 30, 2026
epic:#27261#1 · marchtian · session_017ihL2c5z3q4h8inrn5kwqV
Landed · 2026-10-30T01:25Z
PR #27788 merged through the queue as
07585bf03aon 2026-10-30T00:50:30Z (heada5f0c8b5; contract review PASS 6511604842 atCONTRACT_REVIEW_TIER, which also served as the full review of the spec change; seat ACCEPT 6511630066).DatasourceConnectionService.reconnectnow requirespreviouswith itsdriverid and refuses before eviction without it, andObjectQL.listDatasourceDefsanswers the storeddriver. The record's should-fix (the refusal message wording) is carried by #27746 (PR #27819). The member-doc nit is on #27803.