Skip to content

docs(adr): ADR-0025 v2 still describes manifest-deps and the pre-M1 install gap; the #27123 Tier H docs follow-up #27684

Closed

Description

@objectstack-fleet

domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F

The Tier H docs follow-up card #27123 owes (its body: "ADR-0025 v2 §3.5 M1 bullet becomes a ✅ line in a one-line docs follow-up (Tier H)"). Slices 1–3 landed or are landing (#27335, #27374 merged; #27679 slice 3). Sources: slice-1 carry-over 6484915007 item 1 and the contract review of PR #27679, record 6504145955 (follow-up 1).

Edits owed in docs/adr/0025-plugin-package-distribution.md (line numbers on main at the review)

From slice 1:

  1. §3.5: the M1 bullet becomes a ✅ line.
  2. §7: the dated note ruling 6467932167 ordered (letter B′, the built-in trusted key).
  3. §3.5 (~L293–296): the now-false "Steps 4–7 do not exist … there is no os plugin install" sentence.

From slice 3 (manifest-deps retired, os plugin build refuses a native addon):
4. L159: the // bundled | manifest-deps comment.
5. L185–186: "the build does not yet refuse them mechanically (M1 adds the refusal)", now false.
6. L191: "the build-side half is removed in M1", now done.
7. L267: "For manifest-deps, run …" in the install steps.
8. L595–596: the risk "mitigated by the opt-in manifest-deps strategy".

Re-check: grep -n "manifest-deps\|Steps 4–7\|M1 adds" docs/adr/0025-plugin-package-distribution.md.

Docs only, an ADR (governed: Tier H, maintainer approval). No code. Filed without domain:*; grading is triage's.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Oct 29, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: 写给 AI 的文档与 skills 说错一句,等于产品缺陷 | none | P①

    Triage: p2 · domain:skills · area:devpath · 2026-10-29T17:57Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    Claim: PM loop round 1 · 2026-10-30T00:04Z
    Session: session_016WV4d1j1VPnYjVUvuUMHjc (card thread; seat session_016WV4d1QkPVVzNz3FJqb2iS)
    Account: os-elon-musk
    Branch: claude/project-thread-azb7h4 (the card thread's platform-assigned branch — the recorded platform exception; amended by the seat when the thread reported it)
    Worktree: objectstack-issue-27684
    Domain: domain:skills
    Seat: domain:skills#2
    File surface: docs/adr/0025-plugin-package-distribution.md (the eight edits the card lists, plus three same-class statements slices 1–3 made false, measured by the card thread on origin/main f5dd0575 and added by seat amendment: §3.6 "nothing dispatches on the tier at load", §3.4 step 2 "verifyPluginArtifact … has no production caller until M1", and the Status line listing "M1 local T0" under "Not yet built"); ⛔ no code (stop on breach; explain in the report)
    Container & model: S, mode:thread, model: opus (dispatch-gates --tier: MANDATORY ceiling tier via 'docs/adr/**' (the 2026-10-25 order, effort floor xhigh); exit taken = the proactive low-headroom downgrade, reason: the maintainer's standing word in this project 「fable 不多,后续尽量认领不需要契约复审的卡」 (2026-10-26) and every remaining card in this lane owing a contract review; compensating control = a CONTRACT_REVIEW_TIER contract review of the PR before the human approval), effort: xhigh
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card (the Tier H docs follow-up #27123 owes)
    Thread-read: 6504395881
    Premise: holds (PR #27679, slice 3, merged 2026-10-29T18:48Z; the card's re-check grep on origin/main still hits :159, :186, :267, :293, :596)
    Serial constraints cleared: none — no open PR touches docs/adr/0025-* at claim time. Tier H, draft only, the maintainer's approval lands it.

  3. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1j1VPnYjVUvuUMHjc
    os-dev-report

    {
      "issue": 27684,
      "status": "done",
      "branch": "claude/project-thread-azb7h4",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/27815",
      "session": "session_016WV4d1j1VPnYjVUvuUMHjc",
      "premise_still_valid": true,
      "summary": "ADR-0025 v2 now says what M1 slices 1-3 shipped (#27335, #27374, #27679). The card's eight edits are made: the section 3.5 M1 bullet is a landed line that names the still-open cloud-sample acceptance run (#27570); the section 7 dated note ruling 6467932167 (B-prime) ordered; the false 'Steps 4-7 do not exist' sentence; the section 3.2 packaging comment; the two section 3.3 sentences; section 3.5 step 5; the section 5 manifest-deps mitigation. Three more sentences in the same file that slices 1-3 made false were fixed in place with the seat's agreement before the edit (status line, section 3.4 step 2, section 3.6 tier dispatch). Docs only, one file, +45/-33, every replacement sentence measured on origin/main f5dd0575 and cited file:line in the PR body.",
      "tests": "None: an ADR text change, no code and no tested behaviour, so no ablation. Card re-check grep run on origin/main before the first edit (hits L159, L186, L267, L293, L596 among the retirement-history lines) and on the head (every remaining hit records the retirement or is a corrected line). A five-phrase grep of the corrected falsehoods answers 5 hits on origin/main and 0 on head c49a117f.",
      "gates": "Local, head c49a117f: every family node scripts/pm/dispatch-gates.mjs --commands derives (21), each exit code captured before any pipe: check-adr-links (+ --self-test), check-closing-keyword-parity (+ --self-test), check-comment-mask-corpus, plan-test-core-shards --self-test, lint check:doc-formula-expressions (after building the lint closure under os-verify-lock: VERDICT command-exit 0), check:adr-anchors, check:adr-index, check:adr-symbol-anchors, check:ci-filter-parity, check:closed-ceremony-text, check:cross-package-test-inputs, check:doc-authoring, check:driver-memory-census, check:gitlink-declared, check:nul-bytes, check:pm-governed-merges, check:pm-prior-rulings, check:refd-timer-probe, check:watch-hint-literal: all exit 0. dispatch-gates --ran: 21 derived, 21 run, 0 NOT-MEASURED. Re-derived after the second commit: identical family list. adr-index --check OK (README index cell unchanged). check-commit-card-trailers --range origin/main..HEAD clean. dispatch-gates --tier: MANDATORY docs/adr/** ceiling tier; written at the default tier on the seat's recorded downgrade, contract review owed. CI on the PR head at report time: 24 completed with 0 failed, 14 in_progress, 3 queued; not waited on.",
      "line_budget": "net +12 (45 added, 33 deleted) against the order's approx. 0: section 7 ruling-ordered note +5, section 3.6 (item 9) +3, section 3.3 +2, section 3.5 M1 line +2, every other hunk 0. No re-wrap used to buy lines.",
      "deviations": [
        "Items 9-11 (status line, section 3.4 step 2, section 3.6) are outside the card's eight: the order's mechanism assumption 'only fix the eight' was measured false, as those sentences contradicted the new landed line. Fixed in place under the bounded in-place rule; reported to the seat before the edit; the seat amended claim 6511498060's file surface.",
        "The PR body's attribution block precedes the lane line and Fixes line (harness-written HTML comment kept as the exception allows).",
        "The project-context ask to assign the requester and request their review on the new PR was not done: the project rules forbid GitHub MCP writes and pr_create neither requests nor assigns; that hand-off is the seat's relay act."
      ],
      "files_changed": [
        "docs/adr/0025-plugin-package-distribution.md"
      ],
      "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
      "mcp_calls": "3 — mcp__github__issue_read x3 (get #27684, get_comments #27684, get #27123); no GitHub MCP write. Also 1 mcp__claude-code-remote__subscribe_pr_activity on #27815 (not a GitHub write).",
      "api_writes": "2 relay writes through scripts/pm/fleet-write (objectstack-fleet[bot]): pr_create #27815 with labels [skip-changeset] (read-back identical, 11459 bytes), and this os-dev-report comment on #27684. Plus git push of the branch (not REST).",
      "open_questions": [],
      "out_of_scope_findings": [
        "carrier: none · noted, not filed — sys-trusted-key.object.ts docblock says os plugin install verifies with verifyPluginArtifact (it calls verifyPublisherSignature, which verifyPluginArtifact wraps) and names the boot-time loader as not yet built; comment drift, no filing class.",
        "carrier: none · noted, not filed — ADR-0025 section 3.7 'Supply chain. Lockfile + per-file integrity' still names a lockfile a bundled-only artifact does not carry; original design text, left as history, recorded in the PR's Acceptance notes."
      ]
    }

    Generated by Claude Code

  4. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    ACCEPT → PR #27815 comment 6512616301 (Tier H; contract review PASS 6512098408 on c49a117, delta PASS 6512317662 on dd3bde2, delta PASS 6512486769 on head f26a4b3; CI green; approvers requested). Follow-up 5 (sys-trusted-key docblock) filed as #27840. Awaiting a GOVERNED_APPROVERS approval, then the seat lands it.

  5. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    Landed: PR #27815 merged (30f8fdd37, 2026-10-30T01:53Z) after os-zhuang's approval; pm:dispatched stripped with this note. Follow-up 5 (the sys-trusted-key.object.ts docblock) is #27840. The M1 cloud-sample acceptance run the ADR names stays on #27570. Nothing further owed on this card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratedocumentationImprovements or additions to documentationdomain:skillspriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions