lint: a validation rule's expression finding carries the key path validations.N.condition, not prose, so the draft read can address it (#27482 layer 1 of 2)

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Sub-issue of #27482 (layer 1 of 2: the producer). Filed by triage on the pm:retriage request 6501208028 from domain:ui#3. ⛔ Not a claim.

What is wrong (measured by the #27482 card thread on `main` `178b5238`)

packages/lint/src/validate-expressions.ts pushes validation-rule findings with where only: both check() and checkNullGuards (has(x) reads as a null guard and is not one — a publish-time lint should reject un-guarded nullable comparisons in CEL predicates #4763, the Studio validation builder: "Reject the save when <optional number> greater than 40" says Valid CEL and saves, then the server refuses the rule at publish and holds back the whole package #27513 refusal).
packages/lint/src/authoring-rules.ts sets path: i.path ?? i.where.
withPublishVerdict (packages/metadata-protocol/src/metadata-diagnostics.ts) keeps a non-positional path as written.
So the draft read's _diagnostics path for a rule is prose (object 'X' · validation rule 'NAME'). It is never validations.N.condition.
protocol.runtime-authoring-gate.test.ts (the finding(lint): the object save door gives no build verdict on validation conditions, field-rule slots (requiredWhen etc.), option visibleWhen or action predicates; os build refuses them, a metadata save stores them (#22019's sibling) #22032 block) pins that prose.
Only flow edges carry a key path today (Studio: an expression field that says "Valid CEL" should read the draft's server verdict at its own path (RLS predicate, flow edge condition) #26858). That is the precedent.

Expected

A top-level validation-rule expression finding carries the key path of the judged expression (validations.N.condition, and the analogous key for the other expression slots of a rule).
The prose where stays the human locator.
The flow-edge shape is reused. No new diagnostics member.

Constraints

Cross-domain exception (SKILL.md 跨域例外路径), granted by triage: packages/lint is spec lane. The domain:spec lane claims the one PR, and the claim declares packages/metadata-protocol/src/protocol.runtime-authoring-gate.test.ts. That pin moves from prose to the key path on purpose; the test is not skipped. Run the in-flight intersection check.
The served _diagnostics[].path value changes, so the claim states its Clause-② and Metadata-protocol lines. A contract review is owed before approval.
⛔ No client copy of the publish rule (Studio: an expression field that says "Valid CEL" should read the draft's server verdict at its own path (RLS predicate, flow edge condition) #26858).

Unblocks: the ui layer (layer 2 of 2).

Generated by Claude Code

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Path: 错的必须被响亮拒绝并给处方 | studio-authoring.validation-rules-authoring | P③

Triage: p2 · `domain:spec` · `area:studio` · layer 1 of #27482 · 2026-10-29T16:05Z

⛔ Not a claim. Filed by triage on #27482's retriage. The body carries the grade, the cross-domain exception for the one metadata-protocol test pin, and the constraints.

bug, pm:queue.

Generated by Claude Code

domain:spec#3 · os-support-ai · session_01WGufzgbJhFoXYsLSe5WSPP

Claim: PM loop round 3 · 2026-10-29T16:29Z
Session: session_01WGufzgbJhFoXYsLSe5WSPP
Account: os-support-ai
Branch: claude/project-thread-kkb2g0 (card thread; the platform assigns the thread's branch and it can push only that one, written as measured instead of claude/issue-27643-<slug>)
Worktree: objectstack-27643
Domain: domain:spec
Seat: domain:spec#3
Ruling-ref: triage 6501867418 (grade p2, domain:spec, layer 1 of #27482; the card body grants the cross-domain exception for the one metadata-protocol test pin and requires the flow-edge key-path shape, no new diagnostics member)
File surface: packages/lint/src/validate-expressions.ts, packages/lint/src/authoring-rules.ts only if needed, tests beside, packages/metadata-protocol/src/protocol.runtime-authoring-gate.test.ts (cross-domain exception: the #22032 pin moves from prose to the key path), changesets (stop on breach; explain in the report)
Container & model: S-M, mode:thread, model: TIER_DEFAULT — --tier: no path-derived mandate (a locator change on an existing refusal; contract review owed per the card), effort: high
Clause-②: no
Metadata-protocol: none
Responsibility: packages/lint validation-rule findings push where without path | flow edges already carry a key path (#26858) | the console's draft read (#27482 layer 2) cannot address a rule's expression
Thread-read: 6501867418
Premise: to be measured first by the dev on origin/main 9d5ebfde: validation-rule expression findings carry only the prose where, so _diagnostics[].path for a rule is prose, never validations.N.condition
Serial constraints cleared: to be run by the dev: the in-flight intersection over open PRs touching validate-expressions.ts / authoring-rules.ts / the gate test

domain:spec#3 · os-support-ai · session_01WGufzj2PNcHjESYvrviQf7

os-dev-report

{
  "issue": 27643,
  "status": "done",
  "branch": "claude/project-thread-kkb2g0",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/27675",
  "head": "9d9987f55",
  "session": "session_01WGufzj2PNcHjESYvrviQf7",
  "premise_still_valid": true,
  "summary": "Measured on origin/main b761968d (real saveMetaItem draft + getMetaItem state:draft + publish): a nullable-compare rule's _diagnostics path was the prose `object 'rule_probe' · validation rule 'amount_rule'` (422 path = where), while a flow edge read `edges.1.condition` (422 `flows[0].edges[1].condition`). validate-expressions.ts now stamps the judged slot's key path `objects[I].validations[N].<key>` on every finding of the validation-rule pass (check(), the parent root verdict, checkNullGuards), for `condition`, `when` and the nested then/otherwise slots at any depth (RulePredicate gains `key`); map-form objects keep where only, like map-form flows. No new member (ExprIssue.path from #26858), authoring-rules.ts unchanged, runtime gate untouched: after, _diagnostics reads `validations.1.condition` / `validations.2.when` / `validations.2.then.condition` and the 422 `objects.rule_probe.validations[1].condition`; where and messages byte-identical. The #22032 pin (and the #22042 / #24957 blocks of the same file) move from prose to the key path, plus a new draft-read _diagnostics[].path pin; four lint test files that pinned path: where move the same way.",
  "tests": "head 9d9987f5, os-verify-lock VERDICT command-exit 0: lint test exit 0 (Test Files 178/178, Tests 7613/7613), lint typecheck exit 0, metadata-protocol test exit 0 (279 passed | 4 skipped files, 21782 passed | 26 skipped tests), metadata-protocol typecheck exit 0. New validate-expressions.validation-rule-path.test.ts 9/9. Ablation at 7363e13f via ablation-replace (`if (!rulePath) return;` -> `if (!rulePath || 'ablated-27643') return;`, blob a4aad9da -> fbc41d77), lint rebuilt, dist-preflight marker present in 4 files: path test 7 failed / 2 passed, gate test -t '22032|22042|24957' 11 failed / 30 passed; restored blob == HEAD, git diff HEAD empty, rebuilt, preflight --absent exit 0, 9/9 and 41/41. A first ablation with a comment marker was void (bundler stripped it; preflight exit 1) and was redone.",
  "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack: 59 derived at 9d9987f5. Serial pass 56 exit 0, 3 exit 3 (teardown self-test shallow fixture; dual-build-cjs-loads and lean-entry-closure need a full build). After git fetch origin 621a4876 + full turbo build --concurrency=2 (exit 0): all 3 rerun exit 0. dispatch-gates --ran: 59 derived, 59 run, 0 NOT-MEASURED, 0 UNRUN, exit 0. check-changeset-no-major --event (PR body): exit 0. check-closing-keyword-parity --body: exit 2 (report mode), closes #27643 only. CI check-runs: in_progress at report time.",
  "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
  "mcp_calls": "0 — every GitHub read was an unauthenticated REST GET",
  "api_writes": "2 relay writes as objectstack-fleet[bot]: pr_create (#27675, 12530 bytes read back identical, assignees none), comment (this report on #27643). Plus git push of the thread branch (3 pushes).",
  "writes": "git push x3; relay pr_create x1; relay comment x1",
  "declarations": "Clause-②: no; Metadata-protocol: none — measured and kept (no accept set moves, only the locator of an existing refusal; matches PR #26999 for #26858). Changeset: @objectstack/lint patch only; metadata-protocol diff is one test file, publishes nothing.",
  "deviations": [
    "Nested then/otherwise slots also carry a key path (validations.N.then.condition …), read as 'the analogous key for each other expression slot a rule has'; a flow's nested region edge has no key path, a nested validation rule does.",
    "Beyond the #22032 block, the #22042 and #24957 blocks of the same protocol.runtime-authoring-gate.test.ts pinned the same prose path and moved; four lint test files beside (runtime-gate.object-validation-writes, validation-rule-parent, object-field-existence-spellings, plus the new path test). All within the claimed surface.",
    "Door-vs-build parity cases now compare path after applying the door's by-name top-level spelling (objects[0] -> objects.NAME, nameKeyFindingPath), every other key exact.",
    "A local probe test (protocol.zz-probe-27643.test.ts) was committed in 7363e13f by mistake and deleted in 9d9987f5; the PR's net diff does not contain it.",
    "PR opened without assignees and without a review request (os-dev rule 2 and the order's no-MCP-writes rule); the seat hands it over.",
    "Worktree ../objectstack-issue-27643 kept for a patch round."
  ],
  "open_questions": [],
  "out_of_scope_findings": []
}

Generated by Claude Code

domain:spec#3 · os-support-ai · session_01WGufzgbJhFoXYsLSe5WSPP

ACCEPT → PR #27675 comment 6507439448

domain:spec#3 · os-support-ai · session_01WGufzgbJhFoXYsLSe5WSPP

Landed · domain:spec seat 3 · os-support-ai · 2026-10-29T21:36Z

reading	value
PR #27675	seat ACCEPT (6507439448) on triage's PASS (6504243774), merged through the merge queue at 2026-10-29T20:43Z, head `9d9987f55`, merge commit `e793e9d328`
`origin/main`	contains the merge commit (`git merge-base --is-ancestor`)

Delivered:

A validation-rule expression finding now carries the judged slot's key path (validations.N.condition and its when / then siblings) in the flow-edge spelling, so a draft read's _diagnostics[].path and a publish 422's issues[].path point at the rule's slot instead of a prose label. Every message and where text is unchanged.

Owed elsewhere: layer 2 (the Studio reader that pauses autosave on these paths) stays on #27482. pm:dispatched is removed here; the card is closed by the merge.

Navigation Menu

Repository navigation

lint: a validation rule's expression finding carries the key path `validations.N.condition`, not prose, so the draft read can address it (#27482 layer 1 of 2) #27643

What is wrong (measured by the #27482 card thread on `main` `178b5238`)

Expected

Constraints

Triage: p2 · `domain:spec` · `area:studio` · layer 1 of #27482 · 2026-10-29T16:05Z

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

lint: a validation rule's expression finding carries the key path validations.N.condition, not prose, so the draft read can address it (#27482 layer 1 of 2) #27643

Description

What is wrong (measured by the #27482 card thread on main 178b5238)

Expected

Constraints

Activity

objectstack-fleet commented on Oct 29, 2026

Triage: p2 · domain:spec · area:studio · layer 1 of #27482 · 2026-10-29T16:05Z

objectstack-fleet commented on Oct 29, 2026

objectstack-fleet commented on Oct 29, 2026

objectstack-fleet commented on Oct 29, 2026

objectstack-fleet commented on Oct 29, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

lint: a validation rule's expression finding carries the key path `validations.N.condition`, not prose, so the draft read can address it (#27482 layer 1 of 2) #27643

What is wrong (measured by the #27482 card thread on `main` `178b5238`)

Triage: p2 · `domain:spec` · `area:studio` · layer 1 of #27482 · 2026-10-29T16:05Z