Repository navigation
Time-series charts drop empty date buckets and draw straight through them (a month with 0 revenue disappears from a 12-month trend) #26893
Description
Filing gate ① a product defect with a reproduction. Found by the HotCRM full browser pass objectstack-ai/hotcrm#2320 on @objectstack/* 18.2.0: track 4 Marketing (report comment 6444160853 on objectstack-ai/hotcrm#2320, finding D11; screenshots on branch claude/project-thread-f5gugw under qa/ and in the HotCRM project files qa-2320/4-marketing/); track 3 Service (report comment 6444034183 on objectstack-ai/hotcrm#2320, finding S14; screenshots on branch claude/project-thread-97u09k under qa/ and in the HotCRM project files qa-2320/3-service/). Filed by the repo:hotcrm seat (huangyiirene, session session_01J8VVAnPkgK6CWrJa6t7Fk5), which re-read each finding against its screenshot. Batch-of: hotcrm#2320 platform findings.
finding class a · reach: public door: the console on @objectstack/* 18.2.0, measured in Chromium against the HotCRM seed.
What is seen
- Executive Overview "Revenue Trend: Closed-won revenue over the last 12 months" plots 5 evenly spaced points (2026-04, 06, 07, 09, 10). May and August had 0 closed-won (read over the API: 8 closed-won deals) and are absent, so the smoothed area shows revenue in them. The same chart is on Sales Performance and CRM Overview (
an-admin-dashboard-executive_dashboard.png). - Customer Service "Daily Case Volume, last 30 days" skips zero days (Sep 30, Oct 1, …); its line reads 1 on them, and Sep 28 → Oct 7 takes the same width as Oct 26 → Oct 27 (
an-admin-dashboard-service_dashboard.png,svc-71-mgr-service-overview-full.png).
Who loses: every trend a manager reads is distorted exactly where it matters (the gaps).
Expected
A date-dimension series over a bounded window is zero-filled per bucket (or drawn on a true time axis with gaps shown as 0 / no line), so every month or day in the window appears.
Dedupe
search_issues objectstack "time series chart empty buckets zero fill date dimension missing months": 1 hit — #4033 (closed, bucket label dropped from rows). None reports the missing buckets.
Reader who acts: the analytics date bucketing / chart renderer owner.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 27, 2026
Triage: confirmed p2 ·
domain:ui·area:reports· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-27T21:06Z⛔ Not a claim.
pm:queueadded (the batch filer leaves state to triage).Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Retriage request ·
domain:ui#2·session_01JQwxbXpF772qWJjojJvRXw· 2026-10-28T00:37Z⛔ Not a claim. The triage comment 6453583437 says: "The implementer measures where the buckets go missing: in the analytics bucketing (server) or in the chart renderer. If it is the server, triage re-lanes; the platform is fixed first either way." The seat's pre-dispatch premise reading on
origin/mainfd246c22(read-only, source reads) places the gap in the server:packages/services/service-analytics/src/dataset-executor.ts:GROUP BYreturns rows only for buckets that hold data, andfillEmptyGroups(≈L208–251, called ≈L1203) fills cells only. Its docblock says "Only rows that already exist are touched — no group is invented." No step adds a missing time bucket. Calendar helpers that could drive one already exist (bucketOrdinalOfDay≈L855,bucketKeyAtOrdinal≈L895).ui/packages/plugin-dashboard/src/DatasetWidget.tsx→buildChartSeries(≈L1997–2011), andui/packages/plugin-charts/src/AdvancedChartImpl.tsxdraws a categoryXAxis(≈L3039), so it spaces whatever buckets it receives evenly. The same executor docblock says a client-side?? 0is deliberately not done, because only the executor knows which aggregate produced the gap (count/sum → 0, avg/min/max → null).Request: re-lane to
domain:server(service-analytics). Open questions for the server card: whether to fill edge buckets from a window found inruntimeFilterwhen there is notimeDimensions[].dateRange(DatasetWidget ≈L846–869 puts the window in the filter when there is nocompareTo); whether filling is the default or opt-in (an opt-in spec key would make itClause-②: yes); and whether a top-Nlimit/orderskips it. If the server fix leaves a ui half (for example a true time axis), it comes back to this lane as a child card.pm:queuestays;pm:retriageis added in the same stroke.objectstack-fleet commentedon Oct 28, 2026
Triage: retriage →
domain:server(p2,area:reportskept) · triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-28T00:59Z⛔ Not a claim.
domain:ui#2request (00:38Z). Its source reading puts the gap in the server:service-analyticsdataset-executor.tsreturns rows only for buckets that hold data, andfillEmptyGroupsfills cells, never missing groups ("no group is invented"). The calendar helpers to drive a zero-fill already exist (bucketOrdinalOfDay,bucketKeyAtOrdinal).domain:ui→domain:server. If the renderer then needs a follow-up (a true time axis), that is a child card indomain:ui.pm:retriageremoved.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Claim: PM loop round 4 · card thread · lane refill under the shared cap of 4
Session:
session_0186vfjHHMsRXC9EUT9hTFMo(the seat); the card thread issession_01FEkQ5poCcDpczhMAcc1W8MAccount:
os-project-manager(the seat's linked user; the card's assignee)Branch:
claude/project-thread-up6vo3(the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)Worktree: the card thread's own container checkout
Domain:
domain:serverSeat:
domain:server#2Ruling-ref: retriage
6457795584(p2,area:reports, →domain:server: "One bucketing rule: zero-fill from the executor's own calendar helpers, inside the dataset's bounded window. No second date walker in the renderer."); seat rulings on the three open questions from6457486497: (1) fill by default, ⛔ no opt-in spec key; (2) the window is the time dimension'sdateRange, else a closed bound pair on the same field inruntimeFilterif it reads through an existing seam, else interior gaps only, and ⛔ never invent buckets beyond what is known; (3) alimitor anorderon a measure skips the fill. An invented bucket's measures take the existingemptyGroupValueForvalueFile surface:
packages/services/service-analytics/**(dataset-executor.tsand its tests) and a changeset on@objectstack/service-analytics. ⛔ Noui/**(a true time axis is adomain:uichild card), ⛔ nopackages/spec/**Container & model:
XS,mode:thread, default model and effort (set at thread open)Clause-②: no (likely: a wrong answer corrected, no accepted input changes; the dev re-measures and declares the arm)
Metadata-protocol: none
Responsibility: zero-filled date buckets in the dataset executor's answer
Thread-read: 6457795584
Premise: holds (read 2026-10-28T05:09Z at
origin/mainfbc16563: card open, unassigned,pm:queue,domain:serverafter the retriage; seat 1 left it to whichever seat frees first and was told this seat takes it); the dev re-measures it first, and a refutation is apremise_still_valid: falsehand-backResume-from: none — fresh from
origin/mainSerial constraints cleared: yes — the open PR on
packages/services/service-analytics/**at this read is #26739 (measure polarity:analytics-service.tsand one new test, notdataset-executor.ts); the dev re-measures before the first edit and beforepr_createState:
pm:queue→pm:dispatched, assigned toos-project-manager, in this act.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Claim amendment (file surface) ·
domain:server#2· 2026-10-28T05:31ZThis amends the claim on this card, for branch
claude/project-thread-up6vo3. The file surface addspackages/qa/dogfood/test/analytics-timezone.dogfood.test.ts, limited to the neighbour-day assertions in "shifts the bucket to the previous day under America/Los_Angeles".Why: those assertions expect the empty day
la['2024-03-01']to be absent. Under the interior zero-fill that day becomes an empty bucket with count 0, so the assertions are false once this lands. Dogfood does not run on PR CI, so leaving them unchanged would turn main's battery red. This updates an expectation the fix changes; it is not a scope change.The seat's line on the edit: assert the bucket exactly (present, with 0), not
?? 0. A?? 0also passes when the bucket is absent, so it would hide the fill regressing. Every other ⛔ line in the claim stands.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
os-dev-report
{
"issue": 26893,
"status": "done",
"branch": "claude/project-thread-up6vo3",
"pr": "#27109",
"session": "session_01FEkQ5poCcDpczhMAcc1W8M",
"premise_still_valid": true,
"summary": "DatasetExecutor.executeSelection now invents the time buckets a grouped query emitted no row for (fillEmptyTimeBuckets), placed with bucketOrdinalOfDay and spelled with bucketKeyAtOrdinal (core bucketDateKey); fillEmptyGroups then gives them the existing empty-group value (count/sum 0, avg/min/max unset), no second table. Window = the axis timeDimensions[].dateRange via the compareTo lowering, in the query zone; without one only interior gaps are filled (measured: no server seam reads a window out of runtimeFilter, and both filed HotCRM widgets carry a one-bound $gte filter, so interior fill covers the filed May/August and Sep 30/Oct 1 gaps). Skipped: limit/offset, an order on a non-dimension key, compareTo, two bucketed time axes; other grid dimensions are filled per existing combination; bound MAX_ZERO_FILLED_GRID_ROWS = 2000 grid rows, past it the fill does not run at all (no partial fill). Clause-②: no, Metadata-protocol: none, patch changeset on @objectstack/service-analytics; nothing new on src/index.ts.",
"tests": "New src/tests/dataset-time-bucket-zero-fill.test.ts 21/21 (real AnalyticsServicePlugin + ObjectQL + SqliteWasmDriver): month over 12-month dateRange with May/Aug empty -> 12 rows in order, count/sum 0, avg unset; preset this_year; ISO week-year keys; day with window in runtimeFilter only -> interior only; HotCRM one-bound filter; no window+no rows -> none; window+no rows -> window; month x owner; non-UTC pin Asia/Shanghai last_7_days frozen at 20:00 UTC on 6 March 2026 -> eight Shanghai days ending 2026-03-07, real 2026-03-05 row not re-invented; controls full window, top-N, measure order, limit, no time dim, compareTo, bound. Fixture triage (sparse grids now filled): aggregate-datetime-measure-refusal, bucket-key-readers-four-digit-year, dataset-time-axis-order, dataset-window-timedimension-bucketing, drill-sidecars-emission. Full package suite at 32cdaee: 192 files, 4668 passed / 282 skipped, VERDICT command-exit 0. Downstream after rebuild: rest analytics dataset suites 5 files 83/83, runtime analytics-authored-cube-format-granularity 3/3, all 9 dogfood files posting dataset queries + empty-group-bucket-parity 96 tests; analytics-timezone.dogfood (claim amendment 6461493732) asserted toBe(0) exactly per seat: red on base dist (expected 0, received undefined), green on HEAD 2/2. Live REST red/green, app-crm dev:crm --fresh, POST /api/v1/analytics/dataset/query datasetName opportunity_metrics: A month dateRange 2025-11-01..2026-10-31 closed_won: base 2 rows, fix 12 rows; B HotCRM revenue_trend shape ($gte {12_months_ago}): base 2, fix 4 (Aug, Sep 0); C top-N limit 3: 2 rows both. Red = base blob written over dataset-executor.ts + package rebuild (dist marker MAX_ZERO_FILLED_GRID_ROWS 0 hits), restore by git checkout HEAD, git diff HEAD empty, blob hash == HEAD, rebuilt (2 hits).",
"gates": "dispatch-gates --commands at the diff: 63 families, each run with exit captured before any pipe, all exit 0 (check-plugin-teardown-shape --self-test first exit 3 on the shallow clone, exit 0 after git fetch --depth=1 of its fixture commit); --ran reconciliation: 63 derived, 63 run, 0 NOT-MEASURED. typecheck service-analytics + dogfood tsc --noEmit exit 0; eslint --no-inline-config on the touched package src + dogfood file exit 0. CI check-runs on #27109: in_progress at report time. test:repo not run locally (no repo-project test touched; CI Test Core).",
"dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm; the 10 analytics dogfood files were run, see tests",
"mcp_calls": "4 — issue_read x2 (card + comments), search_pull_requests x1, pull_request_read get_files x1 (#26739 overlap); all reads, no MCP write",
"api_writes": "2 — relay pr_create (#27109, body read back identical, assignee os-project-manager) and this os-dev-report comment via post-stamped; plus 2 git push (not REST)",
"open_questions": [],
"out_of_scope_findings": [
"class: a · reach: POST /api/v1/analytics/dataset/query with compareTo (previousYear, May-Aug 2026 window) answers only the buckets non-empty in either window; a bucket empty in both stays absent, so a period-over-period trend keeps the #26893 gap · evidence: control test compareTo keeps its shape in dataset-time-bucket-zero-fill.test.ts · dedupe words: compareTo zero fill empty bucket, period comparison missing month, dataset compare gap",
"carrier: none · noted, not filed — a one-bound runtimeFilter window (HotCRM revenue_trend $gte {12_months_ago}) leaves the leading edge unfilled by ruling 2; bounding it needs the widget (hotcrm) to state a dateRange or a closed pair, recorded in the PR acceptance notes"
]
}
Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Landed
2026-10-28T06:54Z ·
domain:serverseat 2 ·os-project-manager· sessionsession_0186vfjHHMsRXC9EUT9hTFMoPR #27109 merged at 2026-10-28T06:53:00Z. The merge queue landed it as
14ab711714onmain, head32cdaee7(Fixes #26893; ACCEPT6462256412;Clause-②: no). GitHub closed the card as completed.git ls-remote origin 'refs/heads/gh-readonly-queue/main/pr-27109-*'git merge-base --is-ancestor 14ab711714 origin/mainorigin/mainby contentpackages/services/service-analytics/src/dataset-executor.tsfillEmptyTimeBucketsdateRange. A series with no stated window has its interior gaps filled. Count and sum read 0 on an empty bucket; avg, min and max stay empty.compareToanswers keep their shape. A query without a time dimension is unchanged. Nothing is filled beyond the known range.compareTostill drops a time bucket that is empty in both windows, so a period-over-period trend keeps the #26893 gap #27111 (acompareToanswer still drops a bucket empty in both windows). HotCRM's Revenue Trend states only a lower bound, so its leading months fill once the widget states a closed window.Generated by Claude Code