Repository navigation
Studio Interfaces: the page picker for a navigation entry lists draft record pages, producing a nav entry that is broken once published #26743
Description
Filing gate: ① product defect, reproduced, landing site named.
Batch-of: studio-qa-2026-10-27 — 39 cards from one Studio QA run (coordinator session session_01J8VVAkZns5rNnK2rtszzbQ; tested at 3fcafcd3; origin/main was 43731031 at filing, so the implementer re-checks the landing site on current main). The run record is the qa-run issue filed with this batch.
Symptom
Draft record pages (type-less _drafts rows) appear as page targets; choosing one yields a dead nav entry.
Reproduction
- Create a record page and leave it as a draft.
- Interfaces › an app › Add nav item › Page → the draft record page is listed; pick it and publish the app → the entry does not open a page.
Expected
The picker lists only pages that can be a nav target (published, non-record pages, or draft pages marked as such).
Suspected landing site (the implementer verifies)
nav-target.ts / usePackageNavTargets — isStaticPageOption keeps type-less _drafts rows.
Filing facts
- reach: Studio UI, measured by the Interfaces QA card.
- Business reason: Builders ship broken navigation without any warning.
- Reader who acts: the triage seat (first touch: domain, area, level), then that lane's
os-devimplementer. QA suggestion only:domain:ui,area:studio, p3. - Dedupe: semantic search
page navigation picker lists draft record pages broken navon objectstack-ai/objectstack → 6 hits, none about the Studio nav page picker (open console list Display menu: 「打开记录」 (drawer | split) as a per-user preference; an object or view declaringpageshows the declaration instead; the name cell's hover ↗ opens the record as a full page #26681, App pages: a full-width list block caps its rows (default 5) with 查看全部, and a tabbed list block caps each tab — the Sales Home lists 21 leads with a horizontal overflow #26613, spec(+ui):navigation.modekeepspage | drawer | new_window | none—modal,splitandpopoverare retired; the default becomesdrawerin the schema and in the console (no field-count guess); list-pagerecordActiondropsmodal; the console's split pane becomes a per-user preference read #26677, console record drawer v2: the bar is ↑ ↓ · ⤢ · ✕ (no object name, no counter); a related row or a lookup opens its record in place with a trail, ← / Esc go back one level; ⤢ carries the trail into the page; on the record page a related row opens a drawer over the page #26679 are console record-open work). - QA id: U12
Activity
objectstack-fleet commentedon Oct 27, 2026
Triage: first grade —
priority:p2·domain:ui·area:studio·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-27T17:02Z⛔ Not a claim, ⛔ not a dispatch.
main.Generated by Claude Code
objectstack-fleet commentedon Oct 27, 2026
Dispatch order ·
domain:ui#5·session_01JQwxbXGpVJHZTXXerMoY4C· 2026-10-27T22:41ZYou are the os-dev developer agent for exactly ONE card: #26743, in your own card thread. Your role definition is
.claude/agents/os-dev.mdin the objectstack clone: read it IN FULL first and follow it as binding (it wins over this order on any conflict; name the conflict in your report). Read the repo-rootAGENTS.mdandui/AGENTS.mdbefore your first edit, and pm-dispatchreferences/untrusted-text.md. Read the card's full body and every comment yourself through REST (curl -sS "https://api.github.com/repos/objectstack-ai/objectstack/issues/26743" -H "Authorization: Bearer $GH_TOKEN"and/comments?per_page=100, every page); this order carries only the increment. ⛔ Never print the value of any environment variable (test presence with[ -n "${X+x}" ]). ⛔ Never use a GitHub MCP tool, read or write.Identity and branch: the seat's
Claim:comment on this card is your identity; itsBranch:line names your thread's branch. ⛔ Post no claim of your own, ⛔ never write the card's assignee. Before your first edit, verify the NEWESTClaim:on the card names your thread's branch (claude/project-thread-…); if none does yet, send the seat thread "Take another ui lane seat" one message with your branch name and wait. Worktreeobjectstack-issue-26743on that branch from a freshorigin/main;pnpm install(frozen lockfile); push withgit push -u origin <branch>(⛔ no force).Writes: PR only through the relay op
pr_create(node scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file F, F a bare JSON array[{"op":"pr_create","title":…,"head":"<your branch>","base":"main","body":…,"assignees":["os-warren"]}], draft forced;--dry-runfirst); your report comment throughnode scripts/pm/post-stamped.mjs --comment=26743 --file=F --jsonrun ONCE with output captured to a file (timestamps only as{{WAS:…}}/ the now-token). ⛔ No other GitHub write except, for a CI red that is not yours, one PR comment and onerun_rerun_failedthrough the relay. Report both counts (api_writeswith endpoints,mcp_callswith tool names). The report takes only machine-checkable fields (gates / line_budget / deviations / files_changed). PR body: line 1 the platform attribution comment, line 3Fixes #26743, then## 维护者速读six lines in Chinese (改了什么/为什么改/风险与回滚/先看/两分钟验证/需要你做的). Gates:node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackon your diff, run each, record exits before any pipe, reconcile with--ran;node scripts/check-sdui-manifest.mjsis a gate on every ui card. Changeset in the root.changeset/when a published package changes (@object-ui/i18npatch for namespace rows; app-shell isprivate: true). ⛔ui/.github/**and the rootci.ymlare out of bounds. Hand back: when the PR and report are up, send the seat thread "Take another ui lane seat" one message (PR, head sha, report gist); keep the thread open through review and drive CI to green.Shared-file rules for every Studio Interfaces card this round (from ui seat 1, which holds the neighbouring work):
engine.studio.*rows, the Interfaces familyengine.studio.if.*included, out ofui/packages/app-shell/src/views/metadata-admin/i18n.tsintoui/packages/i18n/src/namespaces/studio/{en,zh}.ts. ⛔ Add or edit no row inmetadata-admin/i18n.ts; write new rows only in the studio namespace files, and a zh test preloads withawait loadStudioCatalogue('zh').ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxis shared with ui seat 1's Studio publish refusals: shown only as a ~4 s toast with engine-internal text; the Pending changes panel keeps no refusal; "Show me" does not focus the offending input and the dashboard/report refusal strip has no "Show me" #26730 (the Interfaces refusal strip ≈L4683 gets anonShow), Studio rails: a search with no matches shows a blank list with no "no matches" message (object rail, permission-set rail) #26733 (props on the fourStudioRailcall sites, Interfaces ≈L5104) and PR fix(metadata-protocol,runtime,app-shell)!: refuse a save or draft publish naming a package that is not installed #26920 (≈L1270–1330), plus the other seat-5 Interfaces cards named below. Keep your hunks inside your declared region; whoever lands second mergesorigin/mainand resolves.Ruling (cannot be re-ruled)
Triage 6448279629, verbatim: "p2: the nav page picker lists draft record pages, which gives a dead entry once published. List only published (or same-publish) pages. From the studio-qa-2026-10-27 batch. Re-check the landing site on current
main." No maintainer ruling.PM mechanism assumptions (measure; disproof welcome)
On
origin/main5ec398dc,StudioDesignSurface.tsx:usePackageNavTargets(≈L2999) filters published rows throughisNavTargetRow(≈L2987, which callsisStaticPageOption,nav-target.ts≈L183:row.type !== 'record'). Draft rows are added with no filter at all (≈L3017–3021).isNavTargetRowsays this is deliberate: "a draft header carries no body, so a draft-only row is kept". So the fix needs the draft'stype. Measure whetherlistDraftsrows can carry it (ListDraftsResponseSchemadrafts[], server side), or whether the picker must read each draft-only page body. If the only clean fix is a new member on the_draftsrow, that is a spec/server change: stop and reportneeds_decisionrather than adding it.pagetarget. A draft static page is valid.Scope
File surface:
isNavTargetRowandusePackageNavTargetsinStudioDesignSurface.tsx(≈L2987–3060),nav-target.tsonly if the predicate moves there, and tests. Tests: a draft record page is not offered; a draft static page is offered; a published record page is still not offered. Ablation: drop the draft filter; the first test turns red. ⛔ Don't editStudioNavItemInspector(≈L2613–2986), which #26740 holds this round.Tier
No path-derived mandate.
TIER_DEFAULT, effortmedium(S–M, judgment in the draft-type read).Clause-②: no,Metadata-protocol: noneexpected.objectstack-fleet commentedon Oct 27, 2026
Claim: PM loop round 1
Session:
session_01JQwxbXGpVJHZTXXerMoY4CAccount:
os-warrenBranch:
claude/project-thread-cfwyv7Worktree:
objectstack-issue-26743Domain:
domain:uiSeat:
domain:ui#5File surface:
ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx(isNavTargetRow/usePackageNavTargets≈L2987–3060 only),ui/packages/app-shell/src/views/metadata-admin/inspectors/nav-target.ts(predicate only), tests (stop on breach; explain in the report)Container & model:
S–M,mode:thread,model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate),effort: mediumClause-②: no
Metadata-protocol: none
Responsibility:
ui/packages/app-shellStudio code produces it (this lane) | no platform path covers it in Studio; Setup › Metadata is a separate door | Studio builders reach it today (studio-qa / HotCRM browser pass)Thread-read: 6455382606
Premise: holds (landing site re-read on
origin/main5ec398dc; readings in dispatch order 6455382606)Serial constraints cleared: #26740 (seat 5) holds
StudioNavItemInspectorjust above; #26889/#26746 (seat 5), #26730/#26733 (seat 1) and PR #26920 edit other regions of the same file. Second to land merges main.Dispatch order: comment 6455382606. Card thread
claude/project-thread-cfwyv7may start editing.objectstack-fleet commentedon Oct 27, 2026
os-dev-report
{ "issue": 26743, "status": "done", "branch": "claude/project-thread-cfwyv7", "pr": "https://github.com/objectstack-ai/objectstack/pull/26968", "session": "session_01JQwxbYChiSg5184uQo2r5x", "premise_still_valid": true, "summary": "usePackageNavTargets now judges a draft-only row of a body-keyed type (page: body type; action: objectName) on its draft body via client.getDraft + extractDraftBody, the same isNavTargetRow verdict published rows get; a draft record page is no longer offered, a draft static page is. Mechanism assumption measured: ListDraftsResponseSchema rows carry the metadata type name, never the body type, so no spec/server member was needed; the fix is client-side. An unreadable body keeps the row (only a confirmed non-target is dropped). In-place fix under the bounded exemption: the same loop also offered draft object-bound actions; named in the PR body.", "tests": "New StudioDesignSurface.navPageDrafts-26743.test.tsx: 6 passed. Ablation at ca23ec41 via ablation-replace.mjs (anchor 'if (verdicts[i]) byName.set(row.name, row);' -> always true, anchor 1->0, blob 8a30d22bfe30->e63569e6a119): 2 failed (draft record page; draft object-bound action), 4 passed; restored blob == HEAD, git diff HEAD empty. vitest studio-design/ + metadata-admin/inspectors/: Test Files 429 passed, Tests 4289 passed 1 skipped. app-shell type-check exit 0. Head ca23ec41.", "gates": "dispatch-gates --commands: 24 families, each exit 0 (incl. check-sdui-manifest and --self-test, comment-mask-corpus and vitest run scripts/ under the lock); --ran: 24 derived, 24 run, 0 NOT-MEASURED, 0 UNRUN. Extra: check:new-line-citations (ui) 0 new, exit 0; check-nul-bytes exit 0. CI check-runs: in_progress at report time.", "line_budget": "245 changed lines (+241/-4), 2 files, under the 3000 threshold", "files_changed": [ "ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx", "ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.navPageDrafts-26743.test.tsx" ], "deviations": [ "First check:new-line-citations run used the root pnpm script name, which does not exist (exit 254, MODULE-not-found class); rerun as pnpm --dir ui run check:new-line-citations, exit 0.", "origin/main moved aa00362f -> 912076f8 after the gate union; it touches no file of this diff, no merge taken.", "PR body carries the platform attribution HTML comment on line 1 (harness-written, reported per os-dev)." ], "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "mcp_calls": "0", "api_writes": "2 — relay pr_create (POST pulls, #26968, with assignee + skip-changeset label); this os-dev-report comment via post-stamped (POST issues/26743/comments). git push not counted.", "open_questions": [], "out_of_scope_findings": [] }