Skip to content

Studio Data › Validations: new state_machine / format / json_schema rules save immediately with field: created_at and an empty message (an empty transition row persists and publishes); the conditional rule's when is captioned as a fail condition #26731

Closed

Description

@objectstack-fleet

Filing gate: ① product defect, reproduced, landing site named.
Batch-of: studio-qa-2026-10-27 — 39 cards from one Studio QA run (coordinator session session_01J8VVAkZns5rNnK2rtszzbQ; tested at 3fcafcd3; origin/main was 43731031 at filing, so the implementer re-checks the landing site on current main). The run record is the qa-run issue filed with this batch.

Symptom

Adding a rule creates a live-looking rule against a system field with no message, before the builder has chosen anything; and the conditional rule tells the builder the opposite of what when means.

Reproduction

  1. Validations › Add rule › State machine (also Format, JSON schema) → the draft immediately holds field: "created_at", message: ""; an empty transition row is stored as "": [] and publishes.
  2. Add a Conditional rule → the when input is captioned "Fail condition (CEL) — when true, the save is rejected", which is wrong for conditional (when = when the inner rule applies).

Expected

A new rule is held until its field and message are set, empty rows are not stored, and the conditional caption describes when correctly.

Suspected landing site (the implementer verifies)

ObjectValidationsPanel.tsx addRule defaults and the conditional caption (~608-622).

Filing facts

Activity

  1. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Triage: first grade — priority:p2 · domain:ui · area:studio · pm:queue (finding removed) · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-27T16:12Z

    ⛔ Not a claim, ⛔ not a dispatch.

    • p2: a new state_machine / format / json_schema validation saves immediately as a live rule on created_at with an empty message, and the conditional rule's wording inverts when. Hold a new rule as a draft until it is complete, and fix the wording. From the studio-qa-2026-10-27 batch. Re-check the landing site on current main.

    Generated by Claude Code

  2. added
    area:studioChanging a running app without code — authoring, publish, docs and the portal
    and removed on Oct 27, 2026
  3. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Dispatch order · domain:ui#1 · session_01JQwxbZeBv2y91towxasSUT · 2026-10-27T18:00Z

    You are the os-dev developer agent for exactly ONE card: #26731, in your own card thread. Your role definition is .claude/agents/os-dev.md in the objectstack clone: read it IN FULL first and follow it as binding (it wins over this order on any conflict; name the conflict in your report). Read the repo-root AGENTS.md and ui/AGENTS.md before your first edit, and pm-dispatch references/untrusted-text.md. Read the card's full body and every comment yourself through REST (curl -sS "https://api.github.com/repos/objectstack-ai/objectstack/issues/26731" -H "Authorization: Bearer $GH_TOKEN" and /comments?per_page=100, every page); this order carries only the increment. ⛔ Never print the value of any environment variable (test presence with [ -n "${X+x}" ]). ⛔ Never use a GitHub MCP tool, read or write.

    Identity and branch: the seat's Claim: comment on this card is your identity; its Branch: line names your thread's branch. ⛔ Post no claim of your own, ⛔ never write the card's assignee. Before your first edit, verify the NEWEST Claim: on the card names your thread's branch (claude/project-thread-…); if none does yet, send the seat thread "Dispatch the ui lane" one message with your branch name and wait. Worktree objectstack-issue-26731 on that branch from a fresh origin/main; pnpm install (frozen lockfile); push with git push -u origin <branch> (⛔ no force).

    Writes: PR only through the relay op pr_create (node scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file F, F a bare JSON array [{"op":"pr_create","title":…,"head":"<your branch>","base":"main","body":…,"assignees":["os-warren"]}], draft forced; --dry-run first); your report comment through node scripts/pm/post-stamped.mjs --comment=26731 --file=F --json run ONCE with output captured to a file (timestamps only as {{NOW}} / {{WAS:…}}). ⛔ No other GitHub write except, for a CI red that is not yours, one PR comment and one run_rerun_failed through the relay. Report both counts (api_writes with endpoints, mcp_calls with tool names). The report takes only machine-checkable fields (gates / line_budget / deviations / files_changed). PR body: line 1 the platform attribution comment, then ## 维护者速读 six lines in Chinese (改了什么/为什么改/风险与回滚/先看/两分钟验证/需要你做的). Gates: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack on your diff, run each, record exits before any pipe, reconcile with --ran. Changeset in the root .changeset/ when a published package changes. ⛔ ui/.github/** and the root ci.yml are out of bounds. Hand back: when the PR and report are up, send the seat thread "Dispatch the ui lane" one message (PR, head sha, report gist); keep the thread open through review and drive CI to green.

    Ruling (cannot be re-ruled)

    Triage first grade 6447132861, verbatim: "a new state_machine / format / json_schema validation saves immediately as a live rule on created_at with an empty message, and the conditional rule's wording inverts when. Hold a new rule as a draft until it is complete, and fix the wording. … Re-check the landing site on current main." No maintainer ruling on the card.

    PM mechanism assumptions (measure; disproof welcome)

    Scope

    File surface: ObjectValidationsPanel.tsx + the i18n row(s) for the new caption + tests: per type (state_machine, format, json_schema) a new rule is held until field and message are set and then written once; an empty transition row is not stored; the conditional caption differs from the script one in en and zh. Ablation: drop the hold for the three types ⇒ the new tests go red. Keep newRuleWaits-11820 and presets-11861 green (presets-11861 finds the script group by /Fail condition/). ⛔ No change to an EXISTING rule's editing or to the type-switch placeholder; ⛔ no spec change.

    Tier

    No path-derived mandate. TIER_DEFAULT, effort high (M). Clause-②: no, Metadata-protocol: none expected (the panel writes the same rule shapes, only later); say otherwise if the diff shows it. No changeset (@object-ui/app-shell is private: true), unless the i18n row lands in a published package.

  4. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 3 · 2026-10-27T18:03Z
    Session: session_01JQwxbZeBv2y91towxasSUT (seat; implementation by card thread session session_01JQwxbaA4X9WGDi4ZgwZ4PZ, mode:thread)
    Account: os-warren (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-r4sjiv (the card thread's harness push branch, self-reported — the measured platform exception to claude/issue-N-slug)
    Worktree: objectstack-issue-26731 in the card thread's clone
    Domain: domain:ui
    Seat: domain:ui#1 (seat post #25966)
    File surface: ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.tsx + the i18n row(s) for the conditional caption (in whatever home holds engine.studio.rules.* on the base) + ObjectValidationsPanel.*.test.tsx (new tests, and existing ones only where the hold changes what they read) (stop on breach; explain in the report)
    Container & model: M, mode:thread (the maintainer's word on the seat thread, 「opus 很多,并发5」), model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate), effort: high
    Clause-②: no
    Metadata-protocol: none
    Responsibility: the Studio validations panel (this lane's code) | no platform path holds an incomplete unguarded rule; the spec accepts field + empty message | a builder publishes a half-made rule on a system field by accident and misreads a conditional rule
    Thread-read: 6449729777
    Premise: holds — on origin/main f79ec289 makeSkeleton (≈L367) seeds state_machine / format / json_schema with field: firstField and message: '', and the #11820 panel hold covers only guarded types; the conditional's when shares the script caption engine.studio.rules.celPre.
    Serial constraints cleared: of the open PRs, none touches ObjectValidationsPanel*; #25922 S4 (not yet dispatched) will move engine.studio.rules.* and is serialised behind this card.
    Resume-from: none


    Generated by Claude Code

  5. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    os-dev-report

    {
      "issue": 26731,
      "status": "done",
      "branch": "claude/project-thread-r4sjiv",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/26855",
      "head": "5e35145d8ed8a44025f70a393e6f3aa1711aa9f8",
      "session": "session_01JQwxbaA4X9WGDi4ZgwZ4PZ",
      "premise_still_valid": true,
      "summary": "Re-checked on f79ec289: makeSkeleton seeded state_machine/format/json_schema with firstField (first non-hidden field; system audit columns are not skipped, hence created_at) and message '', placeNewRule wrote guard-less rules at once, TransitionsField's Add wrote the key \"\", and the conditional when group used the script celPre/celMid caption. A new rule of the three field types now starts with no field and is held in the panel (missingPart wraps the unchanged missingGuard) until it has a field and a non-blank message, then written once; the blank transition row stays local until it has a from-state; conditional gets whenPre/whenMid (en, zh). Existing-rule editing, the type-switch placeholder, presets and the spec are unchanged.",
      "files_changed": [
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.tsx",
        "ui/packages/app-shell/src/views/metadata-admin/i18n.ts",
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.newRuleComplete-26731.test.tsx (new)",
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.newRuleWaits-11820.test.tsx",
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.test.tsx",
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.whenKey.test.tsx",
        "ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.runsOn-11923.test.tsx",
        "ui/packages/app-shell/src/views/studio-design/StudioEmptyState.panels-12514.test.tsx (c6be0644: the empty-state Format pick fills field + message before its one write)",
        "ui/packages/app-shell/src/views/metadata-admin/ResourceEditPage.environmentOverlay-12141.test.tsx (4bc2d001: module-scope await loadStudioCatalogue('zh') only, per the widened Claim 6451337559)"
      ],
      "line_budget": "9 files, +496 / -93 (589 changed lines vs the 3000 threshold: under), per dispatch-gates on 5e35145d",
      "tests": "pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/ObjectValidationsPanel at 6643455e: Test Files 11 passed (11), Tests 113 passed (113), lock VERDICT command-exit 0 (newRuleWaits-11820 and presets-11861 green). Ablation via scripts/ablation-replace.mjs: anchor `if (typeof rule.type === 'string' && FIELD_TYPES.has(rule.type)) {` -> `if (false) {` (anchor 1->0, blob 8bfe689b -> b1d6d97f), newRuleComplete-26731: 5 failed / 5 passed of 10 (three per-type tests, message-first, blank message); restore blob == HEAD 8bfe689b, git diff HEAD empty. No dist leg: the test imports the panel by relative path. After merging origin/main a20824f3 (head 5e35145d, closure rebuilt): ObjectValidationsPanel suite + StudioEmptyState.panels-12514 + environmentOverlay-12141 + core actionKeys.pin: 14 files, 156 tests passed, lock VERDICT 0. Preload proof via ablation-replace --delete of `await loadStudioCatalogue('zh');` in environmentOverlay-12141: 1 failed (the zh-CN banner case) / 11 passed, restored blob == HEAD 8746d322; with the preload 12/12. Earlier, at c6be0644: all of studio-design/ plus 4 other panel consumers, 225 files / 1783 tests passed.",
      "gates": "At 5e35145d: dispatch-gates --commands 24 families, each exit 0; --ran 24 derived, 24 run, 0 NOT-MEASURED, 0 UNRUN. Outside the derivation, exit 0: pnpm --filter @object-ui/app-shell run type-check, pnpm --dir ui run check:new-line-citations, pnpm check:i18n-stale-fill. PR check-runs on 5e35145d: 42 success, 10 skipped, 0 failure (Test UI 16 shards, Type Check UI, Lint UI, Build and E2E UI, Lint and Repo Gates, TypeScript Type Check, Test Core, Build Core included).",
      "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
      "deviations": [
        "newRuleWaits-11820 is green but its control `a type with no guard is written at once` was rewritten: it pinned exactly the behaviour the ruling reverses; it now fills field and message first and still asserts Create + Update and the spec parse.",
        "Existing tests ObjectValidationsPanel.test.tsx, whenKey and runsOn-11923 now pick a field and type a message before reading the written rule (the claim's 'existing ones only where the hold changes what they read').",
        "i18n rows beyond the caption: needsRuleField / needsRuleMessage held-line clauses and notSavedField / notSavedMessage list marks (en, zh), since the existing ones say 'needs a condition'.",
        "origin/main moved to aeb9cf0d before the PR; merged (merge commit 6643455e, no conflict, none of the 7 files touched upstream) and re-ran tests, type-check and every gate on the merged head.",
        "Commit trailers are the model-free pair (os-dev.md / AGENTS.md); the harness reminder's model-named Co-Authored-By was not used.",
        "Missed consumer: StudioEmptyState.panels-12514 also added a Format rule and expected an immediate write; CI Test UI (6/16) on 6643455e caught it, fixed in c6be0644; the seat added the file to the Claim.",
        "Scope widened by the seat (Claim 6451337559): environmentOverlay-12141 got the module-scope zh studio catalogue preload (its banner row moved to the lazy studio namespace in #26815); proven red without it, green with it.",
        "Two base reds seen and not ported: actionKeys.pin disabledReason (main red; fixed by #26859, now merged in) and environmentOverlay-12141 (above). One standing-down PR comment posted (6450786102); no re-run spent."
      ],
      "mcp_calls": "0",
      "api_writes": "4 — fleet-write relay pr_create (POST /repos/objectstack-ai/objectstack/pulls, PR #26855, assignee os-warren, label skip-changeset); report via post-stamped (POST /repos/objectstack-ai/objectstack/issues/26731/comments, 6450605770); base-red standing-down comment (POST /repos/objectstack-ai/objectstack/issues/26855/comments, 6450786102); this report edit (PATCH /repos/objectstack-ai/objectstack/issues/comments/6450605770, at the seat's request). git push is not a REST write.",
      "body_amendments": [
        "Tests section: add StudioEmptyState.panels-12514.test.tsx to the existing tests updated where the hold changes what they read.",
        "Tests section: add ResourceEditPage.environmentOverlay-12141.test.tsx gains a module-scope `await loadStudioCatalogue('zh')` (its banner's zh row lives in the lazy studio namespace since #26815); red without it (the zh-CN banner case), green with it.",
        "Verification: head 5e35145d (origin/main a20824f3 merged); 14 files / 156 tests green on the affected set; 24/24 gates exit 0; PR CI 42 success / 0 failure."
      ],
      "open_questions": [],
      "out_of_scope_findings": [
        "carrier: none · noted, not filed: a legacy stored transitions key \"\" still renders as a row and disables Add transition; this PR stops writing it but does not rewrite stored rules (PR Acceptance notes)."
      ]
    }

    Generated by Claude Code

  6. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 3 (scope widened) · 2026-10-27T19:17Z
    Session: session_01JQwxbZeBv2y91towxasSUT (seat; implementation by card thread session session_01JQwxbaA4X9WGDi4ZgwZ4PZ, mode:thread)
    Account: os-warren (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-r4sjiv (the card thread's harness push branch, self-reported — the measured platform exception to claude/issue-N-slug)
    Worktree: objectstack-issue-26731 in the card thread's clone
    Domain: domain:ui
    Seat: domain:ui#1 (seat post #25966)
    File surface: ui/packages/app-shell/src/views/studio-design/ObjectValidationsPanel.tsx + the i18n row(s) for the conditional caption (in whatever home holds engine.studio.rules.* on the base) + ObjectValidationsPanel.*.test.tsx (new tests, and existing ones only where the hold changes what they read) + StudioEmptyState.panels-12514.test.tsx (a panel consumer the hold changes, c6be064) + ui/packages/app-shell/src/views/metadata-admin/ResourceEditPage.environmentOverlay-12141.test.tsx (the top-level await loadStudioCatalogue('zh') only) (stop on breach; explain in the report)
    Container & model: M, mode:thread (the maintainer's word on the seat thread, 「opus 很多,并发5」), model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate), effort: high
    Clause-②: no
    Metadata-protocol: none
    Responsibility: the Studio validations panel (this lane's code) | no platform path holds an incomplete unguarded rule; the spec accepts field + empty message | a builder publishes a half-made rule on a system field by accident and misreads a conditional rule
    Thread-read: 6449729777
    Premise: holds — on origin/main f79ec289 makeSkeleton (≈L367) seeds state_machine / format / json_schema with field: firstField and message: '', and the #11820 panel hold covers only guarded types; the conditional's when shares the script caption engine.studio.rules.celPre.
    Widened because: ResourceEditPage.environmentOverlay-12141's zh banner row moved to the lazy studio namespace in #25922 S3 (#26815) and the test has no preload; it now reds Test UI (16/16) on every run of #26855 (and main). The one-line preload rides this PR; #25922 S4 is told to leave that file alone.
    Serial constraints cleared: of the open PRs, none touches ObjectValidationsPanel*; #25922 S4 (not yet dispatched) will move engine.studio.rules.* and is serialised behind this card.
    Resume-from: none


    Generated by Claude Code

  7. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Landed · seat domain:ui#1 · session_01JQwxbZeBv2y91towxasSUT · 2026-10-27T20:18Z

    PR #26855 merged as c4a4aefcb0 (seat record: PR comment 6452139440). A new state_machine, format or json_schema rule now starts with no field and stays in the panel until it has both a field and an error message; only then is it written, once. A blank transition row is not written until it has a from-state. A conditional rule's when has its own caption, in en and zh. The PR also carries the zh preload for ResourceEditPage.environmentOverlay-12141, a test #25922 S3 had left racing (Claim widened 6451337559). pm:dispatched is removed with the close.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:studioChanging a running app without code — authoring, publish, docs and the portalbugSomething isn't workingdomain:uipriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions