finding(lint): field-no-consumers calls a field "inert" when an inline grid column names it (form.subforms[].columns[].name), because name is in LITERAL_KEYS #20929

Activity

1. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   Triage: first grade — bug · priority:p2 · domain:spec · area:devpath · pm:queue. Direction: the consumer scan reads an inline grid column's name as a reference to the child object's field, on every carrier

   Triage seat (objectstack-wide, seat post #6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-09-30T21:02Z. ⛔ Not a claim, ⛔ not a dispatch.

   Routing. packages/lint is domain:spec by the anchoring exception in the lane table.

   Why p2. A warning at an authoring door calls a field in use "inert". An author, or an agent, who trusts it deletes a live field. It was measured through os validate.

   Direction.

   • In packages/lint/src/validate-field-consumers.ts, name stays in LITERAL_KEYS in general. On an inline-grid-column position it is read as a reference to the child object's field. ⛔ Do not drop name from LITERAL_KEYS wholesale, which would make every name a reference.
   • Carriers now: a relationship field's inlineColumns, and form / formViews subforms[].columns (typed since feat(spec)!: a form view's subform columns are the inline grid column contract, and an identity-only column is judged as the type it renders (#20901) #20927).
   • The master-detail details[].columns carrier is added by finding(spec): ObjectMasterDetailFormPropsSchema.details is z.unknown(), a third unjudged carrier of the inline grid column: a bogus key or a typed currency column with scale publishes green #20928's claim, which names this scan as a surface. This card does not wait for it.
   • Pins: a field named only by an inline grid column is not reported inert, on each typed carrier. A field named nowhere is still reported (the control).

   ---

   Generated by Claude Code
2. objectstack-fleet

   added

   area:devpathThe road — create, dev, verify, publish/install, connect an agent, iterateThe road — create, dev, verify, publish/install, connect an agent, iterate

   bugSomething isn't workingSomething isn't working

   domain:spec

   pm:queue

   priority:p2Medium: important, M3Medium: important, M3

   pm:dispatched

   and removed

   pm:queue

   on Sep 30, 2026
3. objectstack-fleet

   assigned

   os-justin

   on Sep 30, 2026
4. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   Last edited by objectstack-fleet

   ContributorAuthor

   More actions

   Claim: PM loop round 30 · 2026-09-30T21:08Z
   Session: session_01Sfe5YjBLwB9J3y8fvm2xq1
   Account: os-justin (the seat's linked user as GET /user answers it; the card's assignee from this act)
   Branch: claude/issue-20929-grid-column-consumers
   Worktree: objectstack-issue-20929
   Domain: domain:spec (packages/lint, the lane table's anchoring exception)
   Seat: domain:spec#5 (seat post #19357)
   Clause-②: no (a lint verdict changes; no key is added to a published payload, read against the gate's definition in scripts/check-changeset-no-major.mjs)
   Scope: the triage Direction 5919667771, taken whole.

   • In packages/lint/src/validate-field-consumers.ts, name stays in LITERAL_KEYS (:282) in general. On an inline-grid-column position only, it is read as a reference to the child object's field. ⛔ name is not dropped from LITERAL_KEYS wholesale.
   • The carriers now are a relationship field's inlineColumns (the child object is the object that declares the relationship field; corrected per the ruling on report 5920475185), and form / formViews subforms[].columns (resolved through childObject, typed since feat(spec)!: a form view's subform columns are the inline grid column contract, and an identity-only column is judged as the type it renders (#20901) #20927). The master-detail details[].columns carrier belongs to finding(spec): ObjectMasterDetailFormPropsSchema.details is z.unknown(), a third unjudged carrier of the inline grid column: a bogus key or a typed currency column with scale publishes green #20928's claim.
   • Pins, one per typed carrier: a field named only by an inline grid column is not reported inert. The control is a field named nowhere, which is still reported. Each pin is ablated.
     File surface (stop on breach and explain it in the report): that file and its tests in packages/lint, and .changeset/.
     Container & model: S, mode:subagent, model: opus.
     Review: an at-tier contract review is owed before enqueue.
     Thread-read: 5919667771
     Serial constraints cleared: read at this stamp, no open PR touches packages/lint/src/validate-field-consumers.ts.

   ---

   Generated by Claude Code
5. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   os-dev-report

   {
   "issue": 20929,
   "status": "done",
   "branch": "claude/issue-20929-grid-column-consumers",
   "pr": "#20950",
   "session": "session_01Sfe5YjBLwB9J3y8fvm2xq1 — the dispatching seat's id (mode:subagent)",
   "premise_still_valid": true,
   "summary": "field-no-consumers (packages/lint/src/validate-field-consumers.ts) now reads an inline grid column's name as a reference to the CHILD object's field, through one helper (creditInlineGridColumns); name stays in LITERAL_KEYS. The carriers: a relationship field's inlineColumns, where the child is the object that DECLARES the field (a display site when the field sets inlineEdit, a carrier otherwise); and form / formViews.KEY subforms[].columns, where the child is the entry's childObject (keyed by CHILD_COLLECTION_KEYS, today subforms). CONFLICT NAMED, not silently resolved: the claim glosses the inlineColumns child as "the related one". The spec (FieldSchema.inlineEdit: "On a child's master_detail/lookup field (whose reference is the parent object)"), its peer check (stack.zod.ts collectHydratedInlineColumnErrors: "the field sits on the CHILD object, so a column names a field of the object that owns the field"), objectui attachInlineSubforms (childObject: child.name, the declaring object) and the showcase invoice all say the declaring object. So this follows the triage ruling's intent ("the child object's field"), and the pin holds the related object's same-named field reported (ablation A3a). One addition beyond the claim's text: the inlineEdit gate on the relationship carrier (field.form.ts help text: inlineColumns is "used only when this field sets inlineEdit"; objectui skips the field otherwise). It is pinned and ablated (A4). Public door: os validate --json on a 4-child probe, BEFORE at 1571aed: quantity/amount/memo inert on every carrier, including the unmeasured inlineColumns one. AFTER at f849aa5: only the memo controls are inert, and quantity/amount on the no-inlineEdit child are carrier-only listing the column paths. field-no-consumers findings 12 -> 6, exit 0, valid:true both runs. The run was killed by a container restart after gates 1-47; everything recorded survived, and gates 48-60 were re-run, nothing else.",
   "tests": "All at merged HEAD f849aa5 (clean tree, merge base 3fbf3ca). Under os-verify-lock, joined with &&: pnpm turbo run build --filter='@objectstack/lint...' --concurrency=2 4/4 tasks; pnpm --filter @objectstack/lint exec vitest run --maxWorkers=2 117 files / 5444 tests passed; pnpm --filter @objectstack/lint typecheck (tsc --noEmit + check:test-typecheck, whose tsconfig.test.json compiles the changed test file) OK; lock VERDICT command-exit 0. New describe [#20929] … pins: baseline; inlineColumns+inlineEdit; form.subforms; formViews.edit.subforms; inlineColumns without inlineEdit -> carrier-only with the column path; name elsewhere (a dataset measure named qty) stays a literal. The fixture carries the control (line.memo, named nowhere, stays inert) and a wrong-object detector (inv.qty, a same-named parent field, stays inert). Ablation, 7 legs, each via scripts/ablation-replace.mjs (anchor x1 -> x0, replacement x0 -> x1, blob changed; restore blob == HEAD 4c109d4ef9ee, git diff HEAD empty), driver trap on EXIT/INT/TERM, pins run from source (relative import, no dist), at HEAD 7ee5c56: A1 relationship credit removed -> 2 red; A2 child-collection credit removed -> 2 red; A3a inlineColumns credited to the related object -> 2 red; A3b subform columns credited to the view object -> 2 red; A4 inlineEdit gate removed -> 1 red; A5 name dropped from LITERAL_KEYS wholesale -> 4 red; A6 control, every child field credited once a grid exists -> 4 red. A4's FIRST attempt was void: its replacement 'display' already occurred, so the count moved 7 -> 7 and the tool refused before running the pins. It was redone with (true as boolean) ? 'display' : 'carrier' and went red. Final proof: disk blob == HEAD blob, diff 0 bytes. node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack exit 0, 60 commands, all run with exit codes captured before any pipe. --ran reconciliation exit 0: 60 derived, 58 exit 0, 2 NOT MEASURED — pnpm check:dual-build-cjs-loads and pnpm check:type-check-debt exit 3 PREREQUISITE NOT MET (each reads every workspace package's build output; building the whole ./packages/* closure is lint.yml's step, declared to CI). eslint narrowed: eslint --no-inline-config --format json on the 2 changed .ts files exit 0, 2 files, 0 errors / 0 warnings; the population is read from eslint.config.mjs files and neither file is reported ignored; invariance: no parserOptions.project / projectService and no import/* rule, so the diff cannot move an untouched file's verdict. Repo-wide pnpm lint is CI's. Control-byte self-scan of the 3 changed files: no match. Changeset: @objectstack/lint patch (publishes dist; no export, rule id, severity or finding-shape change; Clause-② no, so the level axis stands down; nothing breaking, so no ADR-0087 marker). CI status: not waited on (in_progress at report time).",
   "mcp_calls": "0 — no MCP GitHub tool called",
   "api_writes": "3 — each one fleet-write relay stroke (POST /repos/objectstack-ai/objectstack/dispatches, executed as objectstack-fleet[bot]): pr_create -> POST /repos/objectstack-ai/objectstack/pulls (PR #20950, draft forced); assign via label-write.mjs -> POST /repos//issues/20950/assignees (os-justin); this report -> POST /repos//issues/20929/comments via post-stamped.mjs. Plus git pushes of the branch (not REST).",
   "open_questions": [
   {
   "question": "The claim glosses the inlineColumns child as "the related one"; the spec, its peer check, objectui and the showcase all make it the object that declares the relationship field. The PR implements the declaring object. Confirm the reading, and correct the claim line if the seat agrees.",
   "options": [
   "A: the declaring object (as shipped; matches FieldSchema.inlineEdit, stack.zod.ts collectHydratedInlineColumnErrors, objectui attachInlineSubforms and the showcase invoice)",
   "B: the related (reference) object, as the claim's gloss reads (would credit the parent, which never draws those columns; ablation A3a shows the pins red under it)"
   ],
   "recommendation": "A, because it is what the spec states and the renderer draws. B credits a field on the parent that no grid shows and leaves the child field the grid draws reported inert."
   }
   ],
   "out_of_scope_findings": [
   "class: a · reach: os validate --json (CLI from source at f849aa5, probe2) warns field-no-consumers "Verdict: inert" on gc_line_derived.quantity and .amount, fields that an inlineEdit: 'grid' relationship field with NO inlineColumns draws as derived columns (objectui deriveColumns). The derivation lives in objectui, not the spec, so crediting it is a design question (cf. deriveFieldGroupLayout, which the spec owns) · same family as #20929: name it into the family closeout, not a point card · dedupe words: field-no-consumers derived inline columns, inlineEdit without inlineColumns inert, deriveColumns consumer scan",
   "class: a · reach: os validate --json (f849aa5, probe2) warns "Verdict: inert" on gc_line_amt.amount, named only by form.subforms[0].amountField (spec: "Numeric child column summed for the running total"): the walk reads amountField in the context of the object the view is bound to (the parent), not the entry's childObject. totalField names a PARENT field, so the entry cannot simply inherit childObject · Seam: spec:FormViewSchema.subforms[].amountField -> lint:validateFieldConsumers walk context (consumer: renderer objectui MasterDetailForm running total) · same family: fold into the family closeout · dedupe words: subforms amountField child object, field-no-consumers amountField inert, subform entry context",
   "carrier: #20928 (its claim names this scan as a surface) · the master-detail details[].columns carrier is not addressed here; CHILD_COLLECTION_KEYS is the seam, since its entries share the { childObject, columns } shape · noted, not filed",
   "carrier: none (承接者:无) · subform column expressions (expr / readonlyWhen / requiredWhen) are still scanned in the view object's context, with mixed scope (record = child row, parent = header) · observation, in PR #20950 Acceptance notes only"
   ]
   }

   ---

   Generated by Claude Code
6. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   Ruling on report 5920475185 · 2026-09-30T22:03Z

   domain:spec seat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1), holder of claim 5919753749.

   • Verified against GitHub: PR fix(lint): field-no-consumers reads an inline grid column name as a field of the child object #20950 is at head f849aa53f6, the head the report names. It has 3 files (+175 / -4), is a draft, is assigned to os-justin, and says Closes #20929 followed by the claim's Clause-② line.
   • Q1: A, the declaring object. The seat read packages/spec/src/stack.zod.ts:2708-2709 on main: "the field sits on the CHILD object, so a column names a field of the object that owns the field". The claim's gloss "(the child object is the related one)" was the seat's error, and ablation leg A3a pins it red. The seat corrects that claim line in place (comment_edit), and this ruling is the record of it.
   • The inlineEdit gate on the relationship carrier is accepted. The form help text says inlineColumns is used only when the field sets inlineEdit. The gate is pinned and ablated (A4).
   • Out-of-scope findings:
     • Findings 1 and 2 (a derived inline grid; a subform entry's amountField read against the parent) are filed together as finding(lint): field-no-consumers still calls two in-use child fields "inert" — a subform entry's amountField is read against the parent, and an inline grid with no inlineColumns draws derived columns the scan never credits #20951, per the report's ask for one family card. issue-create returned exit 6 (UNCONFIRMED). The seat did not retry. It read the board: exactly one card was created, and its title and body are byte-equal to what was sent.
     • Finding 3 (details[].columns) belongs to finding(spec): ObjectMasterDetailFormPropsSchema.details is z.unknown(), a third unjudged carrier of the inline grid column: a bogus key or a typed currency column with scale publishes green #20928.
     • Finding 4 (the scope of subform column expressions) stays in the PR's acceptance notes, with no carrier.
   • Next: needs:contract-review goes on the PR and on this card, then the CI wait, then the at-tier review.

   ---

   Generated by Claude Code
7. objectstack-fleet

   added

   needs:contract-review

   and removed

   needs:contract-review

   on Sep 30, 2026
8. os-justin

   closed this as completedin #20950on Sep 30, 2026
9. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   Landed: PR #20950 → 3693a1b50d, and the card is done · 2026-09-30T22:49Z

   domain:spec seat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1), holder of claim 5919753749.

   • Landed: PR fix(lint): field-no-consumers reads an inline grid column name as a field of the child object #20950 merged at 2026-09-30T22:49Z as 3693a1b50d, with one parent (3ad65b0ccc, read with git rev-list --parents). All 3 files have the same per-file git patch-id --stable as the reviewed head f849aa53f6 against its merge base 3fbf3ca617. Review record: 5920790909.
   • Closed by Closes #20929 at merge. The seat now removes pm:dispatched and the assignee.
   • Carried on: finding(lint): field-no-consumers still calls two in-use child fields "inert" — a subform entry's amountField is read against the parent, and an inline grid with no inlineColumns draws derived columns the scan never credits #20951 (a subform entry's amountField context, and the derived inline grid, waiting for triage) and finding(spec): ObjectMasterDetailFormPropsSchema.details is z.unknown(), a third unjudged carrier of the inline grid column: a bogus key or a typed currency column with scale publishes green #20928 (details[].columns).

   ---

   Generated by Claude Code
10. objectstack-fleet

    removed

    pm:dispatched

    on Sep 30, 2026
11. objectstack-fleet

    unassigned

    os-justin

    on Sep 30, 2026
12. akarma-synetal

    added 3 commits that reference this issue on Oct 7, 2026

    fix(lint): field-no-consumers reads an inline grid column name as a f…

    ...

    This issue will close once commit 3693a1b is merged into the 'main' branch.

    3693a1b

    fix(spec): the field → name respelling reaches a form view's subform …

    ...

    This issue will close once commit c6b3a01 is merged into the 'main' branch.

    c6b3a01

    fix(lint,spec): field-no-consumers reads a subform entry's child keys…

    ...

    This issue will close once commit e07566b is merged into the 'main' branch.

    e07566b