Skip to content

[finding] Two major-18 D3 entries print CurrencyConfigSchema.precision … unchanged through os migrate meta, which PR #20251 makes false in the same major #20379

Description

@objectstack-fleet

Filing gate: ① a defect with a named landing site, finding class (b). The reach: exception is release text: os migrate meta prints these entries to authors, and protocol 18 is unreleased, so this is fixable before any release.

Found by the base-merge round on #19992 (PR #20251; report on this seat's session, out_of_scope_findings[0]). Filed by the domain:spec execution seat 1 (session_01Rjy9MeetSfq34PKn81CRiN, seat post #6017). ⛔ Filed bare: routing and grading belong to triage. ⛔ Not a claim.

What is false

PR #20251 retires CurrencyConfigSchema.precision in major 18 (conversion currency-config-precision-removed, D3 currency-config-precision-retired). The maintainer approved it at 33f53b5e, and it is armed. Once it lands, two sibling D3 entries of the same major still say the key is unchanged:

  • packages/spec/src/migrations/entries/semantic/18.field-scale-precision-integer-refused.ts (about :24–25): 「CurrencyConfigSchema.precision (under currencyConfig) is a different surface with its own bounds and alias table and is unchanged.」
  • packages/spec/src/migrations/entries/semantic/18.ui-form-field-precision-scale-integer-refused.ts (about :29–30): 「⚠️ CurrencyConfigSchema.precision and the gantt scale enum are different surfaces and are unchanged.」

What the fix is (for the dispatch to confirm)

  • Reword only the CurrencyConfigSchema.precision clause in each entry: it is removed in this same major by currency-config-precision-removed. Put no tracker number in the field text.
  • Keep the gantt scale clause, which is still true.
  • Run gen:migration-registry, then check:migration-registry, retired-key-migrate-sentence.test.ts and migrations.test.ts. The fix is text only.
  • Serial after PR feat(spec)!: retire currencyConfig.precision — a currency's decimal places are its currency's (ADR-0049) #20251 lands. It was not folded into that PR because the maintainer approved and armed its exact head.

Dedupe

The two sentences were measured by the #19992 round against origin/main; git grep "CurrencyConfigSchema.precision" packages/spec/src/migrations/entries/semantic/ gives exactly these 2 hits. No open card carries them: this is a sibling-text consequence of PR #20251, found in its round.

Dedupe words: CurrencyConfigSchema.precision unchanged D3 entry · stale sibling retirement prose migrate meta

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratebugSomething isn't workingdocumentationImprovements or additions to documentationdomain:specpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions