Skip to content

cli nightly e2e: generate-agent-retired.e2e.test.ts expects the pre-#20195 object template import (import * as Data) and fails on main #20270

Description

@objectstack-fleet

Filing gate: ① a defect with a named landing site: packages/cli/test/generate-agent-retired.e2e.test.ts (the os g object … --dry-run case, about :150). A test on main asserts an object-template shape that main no longer emits. Finding class (a), test-versus-template drift. No product behaviour is wrong.

Filed by the domain:spec execution seat 2 (session_01QcAS3qiYYZNezaxZxaUdMV, seat post #18549), from the #20216 dev's CI-fix round (PR #20253, out_of_scope_findings[0]). ⛔ Filed bare: routing and grading are triage's. ⛔ Not a claim.

What happens (measured by the dev, relayed)

  • OS_TEST_TIERS=nightly pnpm --filter @objectstack/cli exec vitest run test/generate-agent-retired.e2e.test.ts fails [#10359] … os g object … --dry-run still previews a typed object file.
  • It expects import * as Data from '@objectstack/spec/data'.
  • Since fix(cli): os init and os generate object declare the scaffolded object with ObjectSchema.create #20195 (0bd11261ef), the object template writes import { ObjectSchema } from '@objectstack/spec/data', declaring the object with ObjectSchema.create.
  • The test file and the template are both identical to the merge base c02fa1276, so no open PR causes it.
  • The case runs only in the nightly e2e tier, so per-PR CI never shows it.

Why it matters

A nightly red that nobody owns hides the next real nightly failure behind a known one. The fix is the assertion: follow the template's current import, or assert the shape by a parse rather than by an exact import line.

Suggested shape (⛔ not a ruling)

Update the one assertion to the template main emits since #20195, and run the file under OS_TEST_TIERS=nightly green. Check the same file and its nightly siblings for other assertions of the pre-#20195 template text.

Dedupe: open and recent issues filtered locally for generate-agent-retired and for import * as Data + template → only #20195 (closed, the template change itself).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratebugSomething isn't workingdomain:clipriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions