Skip to content

view.columns / view.sort / view.tabs repeater row properties show English column heads in every locale — the #17508 ruling-A landing for the three view repeaters #19955

Description

@objectstack-fleet

Filing gate: ③ a task the maintainer directed. The maintainer's words, in the chat of session session_019c3Hi6ZMU1p6m6aA6Bz45d while handing over PR #19917 for landing: 「合并后还要补一张本地化跟进卡」. It is also a class (a) defect from the #17507 round (report 5800494895).
Hand that acts: the next domain:spec claim, dispatched in the shape ruling A of #17508 already settled (below).
Dedupe (including closed), run by the filing seat: view repeater columns sort tabs row properties localization view.form.ts metadataForms titles English Studio → 2 hits (#8042, #5084; neither is this); repeater-row-properties view enumerates no repeater row properties translation → 4 hits (#17507, closed by PR #19917 — the titles half; #17508, closed by PR #19345 — the ruling, which fenced these three repeaters out; #17506 and #17505 — sibling carriers, done). No open card covers it.

The defect

PR #19917 (merged as f5a7250b7a) gave the row items of view.columns (14 properties), view.tabs (9) and view.sort (2) an English JSON Schema title. packages/spec/src/ui/view.form.ts enumerates no row children for these three repeaters. So os i18n extract emits no metadataForms.view.fields key for any of the 25 row properties, and Studio in zh-CN / ja-JP / es-ES now shows the new English titles as the column heads. Before the merge those heads were raw keys.

packages/platform-objects/src/apps/translations/repeater-row-properties.test.ts still asserts that view is OUTSIDE its population ("view enumerates no repeater row properties yet"). That pin is the one to flip.

Already ruled — the dispatch shape is inherited, not re-asked

#17508 ruling A (decision batch #120 item 3, maintainer 「17508 A AI负责翻译就行」): one coherent landing — the *.form.ts child enumeration plus all four catalogs (en + AI-authored zh-CN / ja-JP / es-ES) in the same PR, each child's label equal to the item schema's own .meta({ title }). PR #19345 applied that ruling to fifteen carriers and fenced these three out to #17507 (report 5749897882: 「#17507 must add the leaves with the titles」). This card is that remainder.

Expected landing: packages/spec/src/ui/view.form.ts (25 row children), the four translation catalogs, and the repeater-row-properties.test.ts population (view moves inside it; the test's last case — a translated leaf is never an en echo — then covers these leaves too). Reuse the catalog's existing renderings, as PR #19345's review record did.

Dedupe words: view.form.ts repeater row children · view columns sort tabs localisation · metadataForms view columns · repeater-row-properties view · view repeater column heads English


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions