Skip to content

Update ruling D (#18375): the maintainer lifts the ban — skip-changeset may go on a PR that only corrects a pending changeset; four carriers in the repo still say the opposite #19806

Description

@os-support-ai

③ — a maintainer-directed task. The maintainer's words, verbatim, with provenance:

Filed by that seat. ⛔ Ungraded and unrouted: routing is triage's, and this card spans a governed surface and a non-governed one, so it may be split.

The ruling being updated

Batch #158 item 1 on #18375 (5729188290, maintainer 「同意」 2026-09-18): ② B — a PR that edits an existing changeset is confirmed in writing on the PR, and the gate stays advisory red; ⛔ skip-changeset is never applied to it. ① D — no workflow mechanics change; only the texts say so.

The update, as this seat reads the words (⚠️ the maintainer corrects this if it is wrong)

A PR that only corrects a pending changeset (every .changeset row M/D, none A) may take skip-changeset. No per-PR maintainer confirmation is required. Nothing in the words asks for a workflow mechanics change, so this round changes texts only, the same scope ① D had.

Applied already, before the texts change, on the maintainer's direct instruction: #19746 and #19747 carry skip-changeset and are in the merge queue. Provenance is on each PR (5790571940, 5790573062).

The carriers that still say the opposite (re-read on origin/main, cited by content)

# file what it says today governed?
1 .github/workflows/pr-automation.yml route 0 of the 「Require a changeset」 message: 「do NOT apply 'skip-changeset' … LEAVE THIS CHECK RED」, and its paragraph 「Ruled on #18375 (ruling D …) the 'skip-changeset' label is never applied to a PR that edits an existing changeset」; the ::error:: line repeats it no
2 scripts/check-empty-changeset.mjs the DELIBERATE CORRECTION refusal: 「no label and no diff shape makes that safe … this gate stays red either way」 no
3 .claude/agents/os-dev.md 「PR 改到已有的 .changeset/*.md:⛔ 永不打 skip-changeset,门禁红着是对的,确认走 PR 文字。」 yes (Tier S)
4 .claude/skills/pm-dispatch/SKILL.md 「改到已有 .changeset/*.md 的 PR ⛔ 不打 skip-changeset;确认取维护者原话或出处三件转述。」 yes (Tier S)

Not a carrier: AGENTS.md's 「A bug fix in a released package takes a patch changeset — never none, and ⛔ never skip-changeset」. That is a different rule, for a PR that ships a fix, and this update does not touch it.

What the executing round must state, so the maintainer knows what the label now waives

The label is read by the changeset job's own guards. When applied, the job is skipped: that is how PR #18765 merged on 2026-09-18 with nothing in the job run. ⇒ The PR that rewrites the texts should list, from the workflow as it stands, which checks in that job stop running on a correction PR once the label is on. For example: whether the edited changeset's frontmatter or bump level is still validated anywhere else. ⛔ It does not change those mechanics unless the maintainer asks. It only states them.

Constraints for whoever takes it

Dedupe

Repo-scoped issue search (mcp__github__search_issues), 「skip-changeset deliberate correction pending changeset ruling D route 0 label confirmation」: 10 shown (total_count 32, ranked by relevance, ⛔ not a count of matches). None is an open card updating this ruling. Nearest: #18375 (closed, the ruling's home), #19729 / #19735 (the cards behind #19746 / #19747), #18160 and #18404 (closed, the same gate's earlier rulings).


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions