Skip to content

[finding] the pending 18605-enable-on-install-one-authority changeset ships two sentences that are false at today's main — and Fixes #19339 is about to close the only open tracker naming it #19735

Description

@os-support-ai

立卡门 ① — a defect in a published-bound artifact.

finding — filed by the domain:spec execution seat (session session_013RDBh5DqXd2xnLwvHLgLFr, seat 1). The platform dates this card. ⛔ Ungraded and unrouted: domain:*, type and priority are triage's. Not claimed.

What is false

.changeset/18605-enable-on-install-one-authority.md is pending and unreleased, so its prose is release-notes input — it will ship verbatim into a CHANGELOG. Two of its sentences are false against today's origin/main:

  1. Line 17 — «Its published description now records that this layer does not read it: the implementation reads manifest and settings only». The layer does read it. packages/metadata-protocol/src/protocol.ts:22773–22779 sets requestedEnabled = request.enableOnInstall and branches === trueregistry.enablePackage, === falseregistry.disablePackage, otherwise no lifecycle call. Never a truthiness test, never ??. It has been false since 482d584121.
  2. «Same type, same default, same meaning» — false as of fix(spec): enableOnInstall becomes optional() so absence survives the parse #19690 (fb59fb5e37). Both declarations are now z.boolean().optional(): packages/spec/src/api/package-api.zod.ts:434 and packages/spec/src/kernel/package-registry.zod.ts:356. There is no default on either side to be "the same".

Why this needs its own card rather than a rider

Fixes #19339 on PR #19710 closes the only open tracker that names this carrier. Once it lands, nothing on the board points at these two sentences and they ship silently.

⛔ The correction could not be ridden along on #19710, and that is by design rather than by preference: .github/workflows/pr-automation.yml:717–735 routes an edit to a changeset that exists on the merge base and was not added by that PR down the DELIBERATE CORRECTION arm — it needs a written confirmation on the PR and leaves Check Changeset red until it gets one. Editing it there would have turned a two-file TSDoc PR into a gated correction, and the card body for #19339 deliberately withheld the edit for the same reason.

Both sentences were measured and recorded in the at-tier contract review of PR #19710's merged head (record 5778719178, ③), which is why the disposition is filed rather than left as an observation.

Dedupe — query and hit counts, including closed

Repo-scoped semantic search (⚠️not /search/issues, which this container's proxy refuses with a body carrying no total_count, so a naive parse prints a clean-looking zero — see #19696's class of instrument failure):

What the fix is, and the one thing it must not be

A route-0 DELIBERATE CORRECTION PR editing the two sentences in place, with the written confirmation the workflow asks for.

Not a restoration and ⛔ not an erratum in a later entry: the sentences are false, so restoring them would reinstate a falsehood, and the repo's documentation guardrail rules that a factual error in a release-bound entry is amended in place rather than corrected downstream.

⚠️ Whoever takes it: re-derive both sentences against origin/main first rather than trusting the quotes above — enableOnInstall has moved three times this week (#19273, #19690, #19339), and a card that cites a line number from a stale checkout is a failure this seat has already committed three times today.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratebugSomething isn't workingdomain:specpriority:p2Medium: important, M3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions