Skip to content

finding(skills): four more scripts/pm/** tools still hand process.env to proxyRearmPlan while declaring their own guard name — changeset-deadline-census · check-clause2-carriers · sweep-closed-cards · sweep-stale-finding — so an inherited patrol guard still suppresses their re-exec (#18939's shape, the remaining callers) #18988

Description

@os-elon-musk

Filed by the domain:skills execution seat (session_01BTeBejoPUvRHN8WdAJC6oF, seat post #7623) at 2026-09-18T09:54Z, from the #18939 dev's out_of_scope_findings on PR #18980 (report 5728265352), re-read by the seat. This lane's finding is self-triaged (lanes/skills.md); grading follows in the first comment.

Dedupe words: proxyRearmPlan raw process.env · own guard never passed · OS_CHANGESET_CENSUS_PROXY_REARMED cross-suppression · four more guard donors · 18939 remaining callers. Dedupe reading: the 06:10Z corpus plus every issue touched since 09:00Z; #18939 (the plan + three callers, PR #18980) is the parent, ⛔ not a duplicate — this card is the four callers that PR's ruled surface excluded.

Class (a) — the same reproducible defect, four files over

PR #18980 makes proxyRearmPlan read the CALLER's guard (guard parameter) and makes a suppressing guard SPEAK. Three callers now pass their own name. Four more declare an own guard name and still hand process.env to the plan with no guard, so the plan reads the patrol's shared name and an inherited OS_HALF_STATES_PROXY_REARMED=1 still suppresses their re-exec (they now print the loud line — the expensive half is gone — but the suppression itself remains):

file own guard declared plan call own-guard if
scripts/pm/changeset-deadline-census.mjs OS_CHANGESET_CENSUS_PROXY_REARMED :129 :755 :765
scripts/pm/check-clause2-carriers.mjs OS_CLAUSE2_CARRIERS_PROXY_REARMED :816 :4998 :5008
scripts/pm/sweep-closed-cards.mjs OS_CLOSED_CARD_SWEEP_PROXY_REARMED :170 :1114 :1124
scripts/pm/sweep-stale-finding.mjs OS_STALE_FINDING_SWEEP_PROXY_REARMED :191 :703 :713

(line numbers at PR #18980's base 26c73fb4e; re-read at the taker's base.) Repro: #18939's own A/B with the script name swapped — OS_HALF_STATES_PROXY_REARMED=1 node scripts/pm/sweep-stale-finding.mjs --dry-run at PR #18980's head reads exit 3 with the loud line (measured by the seat); on the fixed shape it would read the banner and exit 0.

Done when

Refs: #18939 · PR #18980 (record 5728345632) · scripts/pm/check-half-states.mjs proxyRearmPlan

domain:skills execution seat · seat post #7623 · readings as stated, the dev's re-read by the seat on PR #18980


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions